<feed xmlns='http://www.w3.org/2005/Atom'>
<title>mirrors/foot.git/notify.c, branch 1.18.0</title>
<subtitle>A fast, lightweight and minimalistic Wayland terminal emulator</subtitle>
<id>https://git.0x0f.dev/mirrors/foot.git/atom?h=1.18.0</id>
<link rel='self' href='https://git.0x0f.dev/mirrors/foot.git/atom?h=1.18.0'/>
<link rel='alternate' type='text/html' href='https://git.0x0f.dev/mirrors/foot.git/'/>
<updated>2024-08-02T06:24:03Z</updated>
<entry>
<title>notify: codespell: notificaton -&gt; notification</title>
<updated>2024-08-02T06:24:03Z</updated>
<author>
<name>Daniel Eklöf</name>
<email>daniel@ekloef.se</email>
</author>
<published>2024-08-02T06:22:57Z</published>
<link rel='alternate' type='text/html' href='https://git.0x0f.dev/mirrors/foot.git/commit/?id=1a895387008e99f181dd72e3cb1404f80804ed08'/>
<id>urn:sha1:1a895387008e99f181dd72e3cb1404f80804ed08</id>
<content type='text'>
</content>
</entry>
<entry>
<title>osc: kitty notifications: cleanup and update to latest version of spec</title>
<updated>2024-08-02T06:07:13Z</updated>
<author>
<name>Daniel Eklöf</name>
<email>daniel@ekloef.se</email>
</author>
<published>2024-08-02T06:07:13Z</published>
<link rel='alternate' type='text/html' href='https://git.0x0f.dev/mirrors/foot.git/commit/?id=ea2f0e7c3f29f2ba83ad71e36c6751bb571f826f'/>
<id>urn:sha1:ea2f0e7c3f29f2ba83ad71e36c6751bb571f826f</id>
<content type='text'>
* Don't store a list of unfinished notifications. Use a single one. If
  the notification ID of the 'current' notification doesn't match the
  previous, unfinished one, the 'current' notification replaces the
  previous one, instead of updating it.

* Update xstrjoin() to take an optional delimiter (for example ','),
  and use that when joining categories and 'alive IDs'.

* Rename ${action-arg} to ${action-argument}

* Update handling of the 'n' parameter (symbolic icon name); the spec
  allows it to be used multiple times, and the terminal is supposed to
  pick the first one it can resolve. Foot can't resolve icons at all,
  neither can 'notify-send' or 'fyi' (which is what foot typically
  executes to display a notification); it's the notification daemon that
  resolves icons.

  The spec _could_ be interpreted to mean the terminal should lookup
  .desktop files, and use the value of the 'Icon' key from the first
  matching .desktop files. But foot doesn't read .desktop files, and I
  don't intend to implement XDG directory scanning and parsing of
  .desktop files just to figure out which icon to use.

  Instead, use a simple heuristics; use the *shortest* symbolic
  names. The idea is pretty simple: plain icon names are typically
  shorter than .desktop file IDs.
</content>
</entry>
<entry>
<title>notify: don't forget terminating NULL when patching notify helper's argv</title>
<updated>2024-07-31T16:33:24Z</updated>
<author>
<name>Daniel Eklöf</name>
<email>daniel@ekloef.se</email>
</author>
<published>2024-07-31T16:31:18Z</published>
<link rel='alternate' type='text/html' href='https://git.0x0f.dev/mirrors/foot.git/commit/?id=18b87b2e206536d2fdda36e8c42cce270c77a54b'/>
<id>urn:sha1:18b87b2e206536d2fdda36e8c42cce270c77a54b</id>
<content type='text'>
</content>
</entry>
<entry>
<title>osc: kitty notifications: buttons, icons, app-name, categories etc</title>
<updated>2024-07-31T14:22:17Z</updated>
<author>
<name>Daniel Eklöf</name>
<email>daniel@ekloef.se</email>
</author>
<published>2024-07-31T14:22:17Z</published>
<link rel='alternate' type='text/html' href='https://git.0x0f.dev/mirrors/foot.git/commit/?id=76ac910b118147beba276748d2e2aaca0ee066de'/>
<id>urn:sha1:76ac910b118147beba276748d2e2aaca0ee066de</id>
<content type='text'>
First, icons have been finalized in the specification. There were only
three things we needed to adjust:

* symbolic names are base64 encoded
* there are a couple of OSC-99 defined symbolic names that need to be
  translated to the corresponding XDG icon name.
* allow in-band icons without a cache ID (that is, allow applications
  to use p=icon without having to cache the icon first).

Second, add support for the following new additions to the protocol:

* 'f': custom app-name, overrides the terminal's app-id
* 't': categories
* 'p=alive': lets applications poll for currently active notifications
* 'id' is now 'unset' by default, rather than "0"
* 'w': expire time (i.e. notification timeout)
* "buttons": aka actions. This lets applications add additional (to
  the terminal defined "default" action) actions. The 'activated' event
  has been updated to report which button/action was used to activate
  the notification.

To support button/actions, desktop-notifications.command had to be
reworked a bit.

There's now a new config option:
desktop-notifications.command-action-arg. It has two template
arguments ${action-name} and ${action-label}.

command-action-arg gets expanded for *each* action.

${action-name} and ${action-label} has been replaced by ${action-arg}
in command. This is a somewhat special template, in that it gets
replaced by *all* instances of the expanded actions.
</content>
</entry>
<entry>
<title>notify: disable debug logging</title>
<updated>2024-07-30T15:31:15Z</updated>
<author>
<name>Daniel Eklöf</name>
<email>daniel@ekloef.se</email>
</author>
<published>2024-07-30T15:31:15Z</published>
<link rel='alternate' type='text/html' href='https://git.0x0f.dev/mirrors/foot.git/commit/?id=d87b81dd523a6235638685873434b5490effcae3'/>
<id>urn:sha1:d87b81dd523a6235638685873434b5490effcae3</id>
<content type='text'>
</content>
</entry>
<entry>
<title>notify: remove debug assertion</title>
<updated>2024-07-30T15:24:48Z</updated>
<author>
<name>Daniel Eklöf</name>
<email>daniel@ekloef.se</email>
</author>
<published>2024-07-30T15:24:48Z</published>
<link rel='alternate' type='text/html' href='https://git.0x0f.dev/mirrors/foot.git/commit/?id=259a75e957a8eb0f9d541594e8edf45e77274874'/>
<id>urn:sha1:259a75e957a8eb0f9d541594e8edf45e77274874</id>
<content type='text'>
(FD 0 _is_ valid, after all)
</content>
</entry>
<entry>
<title>notify: ${icon}: don't fallback to app-id</title>
<updated>2024-07-30T15:16:02Z</updated>
<author>
<name>Daniel Eklöf</name>
<email>daniel@ekloef.se</email>
</author>
<published>2024-07-30T15:16:02Z</published>
<link rel='alternate' type='text/html' href='https://git.0x0f.dev/mirrors/foot.git/commit/?id=ba79bf1602c93ebf357f1b9c95f42b2fc0372fc8'/>
<id>urn:sha1:ba79bf1602c93ebf357f1b9c95f42b2fc0372fc8</id>
<content type='text'>
* Revert --icon to ${app-id}
* Use --hint STRING:image-path:${icon} instead
* ${icon} no longer expands to ${app-id} if notification has no icon
</content>
</entry>
<entry>
<title>notify: don't close FD 0</title>
<updated>2024-07-30T14:33:19Z</updated>
<author>
<name>Daniel Eklöf</name>
<email>daniel@ekloef.se</email>
</author>
<published>2024-07-30T14:33:19Z</published>
<link rel='alternate' type='text/html' href='https://git.0x0f.dev/mirrors/foot.git/commit/?id=0a5ba708e4a8448a0d29d4e263f939c9d1d2b953'/>
<id>urn:sha1:0a5ba708e4a8448a0d29d4e263f939c9d1d2b953</id>
<content type='text'>
This fixes a regression where closing a terminal instance, or hard- or
soft-resetting a terminal caused FD 0 to be closed.

This meant it became re-usable. Usually, by memfd_create() when
allocating a new surface buffer. So far nothing _really_ bad has
happened.

But what if FD 0 is now used by a memfd, and we close _another_
terminal instance?

This causes our memfd to be closed. And then, when e.g. trying to
scroll the terminal content: fallocate() fails with bad FD.
</content>
</entry>
<entry>
<title>notify: close notification by sending SIGINT to helper</title>
<updated>2024-07-26T14:28:47Z</updated>
<author>
<name>Daniel Eklöf</name>
<email>daniel@ekloef.se</email>
</author>
<published>2024-07-26T14:23:17Z</published>
<link rel='alternate' type='text/html' href='https://git.0x0f.dev/mirrors/foot.git/commit/?id=9cf99ea4bffd667ae59e4328a28b86dcefacb3f4'/>
<id>urn:sha1:9cf99ea4bffd667ae59e4328a28b86dcefacb3f4</id>
<content type='text'>
If the user hasn't configured a custom 'desktop-notifications.close'
command, try to close the notification by sending SIGINT to the
notification helper.

This is best-effort:

* If there's no helper running, we do nothing (except warn)
* We don't verify, in any way, the notification is actually closed
* We don't send any other signals, under any circumstances. That is,
  no SIGTERM, no SIGKILL. Ever.
</content>
</entry>
<entry>
<title>osc: kitty notifications: implement the 'close' request</title>
<updated>2024-07-25T17:24:28Z</updated>
<author>
<name>Daniel Eklöf</name>
<email>daniel@ekloef.se</email>
</author>
<published>2024-07-25T17:24:28Z</published>
<link rel='alternate' type='text/html' href='https://git.0x0f.dev/mirrors/foot.git/commit/?id=c4d9f8a8ff4d65b43defb8d63e775e8b91f82bed'/>
<id>urn:sha1:c4d9f8a8ff4d65b43defb8d63e775e8b91f82bed</id>
<content type='text'>
Add a new config option, desktop-notifications.close, defining what to
execute to close a notification. It has a single template parameter,
${id}, that is expanded to the external notification ID foot may have
picked up from the notification helper.

notify-send does not support closing notifications, and it appears
impossible to pass an *unsigned* integer as argument to gdbus. Hence
no default value for the new 'close' option.

Example:

    printf '\e]99;i=123;this is a notification\e\\'
    printf '\e]99;i=123:p=close;\e\\'
</content>
</entry>
<entry>
<title>osc: kitty notification: implement 'close' events</title>
<updated>2024-07-25T16:47:23Z</updated>
<author>
<name>Daniel Eklöf</name>
<email>daniel@ekloef.se</email>
</author>
<published>2024-07-25T16:47:23Z</published>
<link rel='alternate' type='text/html' href='https://git.0x0f.dev/mirrors/foot.git/commit/?id=c7972229305cfa76d402507a852af321198fdd2c'/>
<id>urn:sha1:c7972229305cfa76d402507a852af321198fdd2c</id>
<content type='text'>
Application can now request to receive a 'close' event when the
notification is closed (but not necessarily activated), by adding
'c=1' to the notification request.
</content>
</entry>
<entry>
<title>notify: rename 'report' -&gt; 'report_activated'</title>
<updated>2024-07-25T16:45:58Z</updated>
<author>
<name>Daniel Eklöf</name>
<email>daniel@ekloef.se</email>
</author>
<published>2024-07-25T16:35:15Z</published>
<link rel='alternate' type='text/html' href='https://git.0x0f.dev/mirrors/foot.git/commit/?id=d53f0aea7560c71c8262c7688bdf7735d5b3fa26'/>
<id>urn:sha1:d53f0aea7560c71c8262c7688bdf7735d5b3fa26</id>
<content type='text'>
</content>
</entry>
<entry>
<title>notify: kitty notifications: fix ID string in activation event</title>
<updated>2024-07-25T16:45:04Z</updated>
<author>
<name>Daniel Eklöf</name>
<email>daniel@ekloef.se</email>
</author>
<published>2024-07-25T16:45:04Z</published>
<link rel='alternate' type='text/html' href='https://git.0x0f.dev/mirrors/foot.git/commit/?id=0ce4ef60006b8c2feb855d6b7a992a74bac40ad7'/>
<id>urn:sha1:0ce4ef60006b8c2feb855d6b7a992a74bac40ad7</id>
<content type='text'>
We forgot to prefix the notification ID with 'i='
</content>
</entry>
<entry>
<title>osc+notify: strcmp() -&gt; streq()</title>
<updated>2024-07-24T14:04:14Z</updated>
<author>
<name>Daniel Eklöf</name>
<email>daniel@ekloef.se</email>
</author>
<published>2024-07-24T14:04:14Z</published>
<link rel='alternate' type='text/html' href='https://git.0x0f.dev/mirrors/foot.git/commit/?id=a6bc9cafafd2edb2d88286cbdf4e57e331a86347'/>
<id>urn:sha1:a6bc9cafafd2edb2d88286cbdf4e57e331a86347</id>
<content type='text'>
</content>
</entry>
<entry>
<title>notify: try to read the daemon assigned notification ID from stdout</title>
<updated>2024-07-24T14:02:19Z</updated>
<author>
<name>Daniel Eklöf</name>
<email>daniel@ekloef.se</email>
</author>
<published>2024-07-24T14:02:19Z</published>
<link rel='alternate' type='text/html' href='https://git.0x0f.dev/mirrors/foot.git/commit/?id=f56da385fe4c4434bfc10c362cbdda58c63d238f'/>
<id>urn:sha1:f56da385fe4c4434bfc10c362cbdda58c63d238f</id>
<content type='text'>
And document the things we recognize in the notification helper's
stdout.
</content>
</entry>
<entry>
<title>notify: don't create icon file on disk when we're not going to use it</title>
<updated>2024-07-24T13:59:52Z</updated>
<author>
<name>Daniel Eklöf</name>
<email>daniel@ekloef.se</email>
</author>
<published>2024-07-24T13:59:52Z</published>
<link rel='alternate' type='text/html' href='https://git.0x0f.dev/mirrors/foot.git/commit/?id=37ab3b1603ce3697d69d28129b5941dac843e992'/>
<id>urn:sha1:37ab3b1603ce3697d69d28129b5941dac843e992</id>
<content type='text'>
We always prefer the symbolic name. Thus, there's no need to write raw
PNG data to disk if we have a symbolic name.

Furthermore, keep the file open until the cache entry is evicted.
</content>
</entry>
<entry>
<title>notify: split up the ${action} template parameter</title>
<updated>2024-07-23T17:08:21Z</updated>
<author>
<name>Daniel Eklöf</name>
<email>daniel@ekloef.se</email>
</author>
<published>2024-07-23T17:08:21Z</published>
<link rel='alternate' type='text/html' href='https://git.0x0f.dev/mirrors/foot.git/commit/?id=ecbec57a4749cc4162d2bb55dd14e1890b6dff31'/>
<id>urn:sha1:ecbec57a4749cc4162d2bb55dd14e1890b6dff31</id>
<content type='text'>
Split it up into two, ${action-name} and ${action-label}.

Dunstify, for example, has a different syntax compared to notify-send:

notify-send: default=foobar
dunstify: default,foobar
</content>
</entry>
<entry>
<title>notify: bug: always adjust amount of data left in stdout buffer</title>
<updated>2024-07-23T16:48:45Z</updated>
<author>
<name>Daniel Eklöf</name>
<email>daniel@ekloef.se</email>
</author>
<published>2024-07-23T16:48:45Z</published>
<link rel='alternate' type='text/html' href='https://git.0x0f.dev/mirrors/foot.git/commit/?id=d5c773a58b2cdadf7aee2fe16664c168e750b953'/>
<id>urn:sha1:d5c773a58b2cdadf7aee2fe16664c168e750b953</id>
<content type='text'>
</content>
</entry>
<entry>
<title>notify: name the activation action 'default'</title>
<updated>2024-07-23T14:48:15Z</updated>
<author>
<name>Daniel Eklöf</name>
<email>daniel@ekloef.se</email>
</author>
<published>2024-07-23T14:48:15Z</published>
<link rel='alternate' type='text/html' href='https://git.0x0f.dev/mirrors/foot.git/commit/?id=79832c16e2db2bef79c03aa5eba7cf863436dd67'/>
<id>urn:sha1:79832c16e2db2bef79c03aa5eba7cf863436dd67</id>
<content type='text'>
This is less unique, but also works better with notification daemons
that trigger the 'default' action when e.g. clicked.
</content>
</entry>
<entry>
<title>notify: don't focus/report on notification dismissal</title>
<updated>2024-07-23T14:41:52Z</updated>
<author>
<name>Daniel Eklöf</name>
<email>daniel@ekloef.se</email>
</author>
<published>2024-07-23T14:41:52Z</published>
<link rel='alternate' type='text/html' href='https://git.0x0f.dev/mirrors/foot.git/commit/?id=045ead985c1e320f289704b6a995d48a5eccf59e'/>
<id>urn:sha1:045ead985c1e320f289704b6a995d48a5eccf59e</id>
<content type='text'>
Only do it when the notification was activated.

Here, activated means the 'click to activate' notification action was
triggered.

How do we tie everything together?

First, we add a new template parameter, ${action}. It's intended to be
used with e.g. notify-send's --action option.

When the action is triggered, notify-send prints its name on stdout,
on a separate line. Look for this in stdout. Only if we've seen it do
we focus/report the notification.
</content>
</entry>
</feed>
