diff options
| author | Craig Barnes <craigbarnes@protonmail.com> | 2021-01-04 05:25:14 +0000 |
|---|---|---|
| committer | Daniel Eklöf <daniel@ekloef.se> | 2021-01-21 10:52:41 +0000 |
| commit | f22d4e9587edf7624dcd6a4c60b8eafa73373e3e (patch) | |
| tree | 29e9c33cfa85cb812bed70cecd5929ebda070545 | |
| parent | Add myself to Contributors (diff) | |
uri: use nibble2hex() instead of isxdigit(3) to check valid hex digits
| -rw-r--r-- | uri.c | 10 |
1 files changed, 6 insertions, 4 deletions
@@ -2,7 +2,6 @@ #include <stdlib.h> #include <string.h> -#include <ctype.h> #include <limits.h> #include <unistd.h> #include <assert.h> @@ -12,6 +11,10 @@ #include "log.h" #include "xmalloc.h" +enum { + HEX_DIGIT_INVALID = 16 +}; + static uint8_t nibble2hex(char c) { @@ -27,8 +30,7 @@ nibble2hex(char c) return c - 'A' + 10; } - assert(false); - return 0; + return HEX_DIGIT_INVALID; } bool @@ -199,7 +201,7 @@ uri_parse(const char *uri, size_t len, encoded_len -= prefix_len; decoded_len += prefix_len; - if (isxdigit(next[1]) && isxdigit(next[2])) { + if (nibble2hex(next[1]) <= 15 && nibble2hex(next[2]) <= 15) { *p++ = nibble2hex(next[1]) << 4 | nibble2hex(next[2]); decoded_len++; encoded_len -= 3; |
