aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeLines
* meson: bump version to 1.19.01.19.0releases/1.19Daniel Eklöf2024-10-23-1/+1
|
* changelog: prepare for 1.19.0Daniel Eklöf2024-10-23-5/+8
|
* uri: skip query/fragment parsing when dealing with file:// URIsDaniel Eklöf2024-10-23-0/+19
| | | | | | | Also, ignore invalid query/fragments (i.e. if the fragment comes before the query). Closes #1840
* Revert "url-mode: don't strip the file:// prefix from localhost URIs"Daniel Eklöf2024-10-23-2/+31
| | | | This reverts commit 54722369d8ca0c6b90c6d874b0f712e133cd4925.
* config: add color.sixelN optionsDaniel Eklöf2024-10-23-38/+64
| | | | These options allows you to configure the default sixel color palette.
* render: remove unnecessary call to wl_surface_damage_buffer()Daniel Eklöf2024-10-06-2/+0
| | | | | The damage region(s) are translated to wl_surface_damage_buffer() calls after the entire frame has been rendered.
* render: sixels: update damage region when rendering sixelsDaniel Eklöf2024-10-05-2/+10
| | | | | | | | | | | | | | This fixes flickering when foot is forced to double-buffer (e.g when running under KDE, or smithay based compositors). Since the damage region isn't updated, the sixel images aren't included in the memcpy that is done to transfer the last frame's updated regions to the next frame. As a result, every other frame will have the sixels, while the others don't. Closes #1851
* changelog: #1715: "ghost" lines when selecting textDaniel Eklöf2024-09-21-0/+4
|
* render: do dirty/clean consistency check before rendering sixelsDaniel Eklöf2024-09-21-6/+6
| | | | | Since the sixels may render some of the cells, we want the check to happen before the sixels.
* selection: set row->dirty when clearing the cell->attrs.clean bitDaniel Eklöf2024-09-21-1/+4
| | | | Closes #1715
* render: double-buffer: optimization: skip clean rowsDaniel Eklöf2024-09-21-0/+5
| | | | | | | | | | | | When scanning the grid for all-dirty rows (that we can remove from the damage region we're about to memcpy from the old frame), check the row->dirty bit, and skip scanning the cells of that row altogether. We're only looking for rows where all cells are dirty - those rows can be removed from the region we copy from the old frame, since the entire row will be re-rendered anyway. If a row is clean, it *must* be copied from the old frame.
* render: (debug): assert row->dirty vs. cell->attrs.clean consistencyDaniel Eklöf2024-09-21-0/+24
|
* shm: fix compilation when FORCED_DOUBLE_BUFFERING is enabledDaniel Eklöf2024-09-21-2/+2
|
* render: xcursor_is_valid(): don't crash when there's no theme loadedDaniel Eklöf2024-09-21-0/+4
| | | | | | | | | | | | When trying to set a custom cursor shape, we first validate it. This is done by checking against known server-side names, and then trying to load the cursor from the client side cursor theme. But, if we're using server side names, there is no theme loaded, and foot crashed. Fix by checking if we have a theme loaded, and if not, fail the cursor shape name validation.
* render: add missing include, limits.hDaniel Eklöf2024-09-15-1/+2
|
* Merge branch 'toplevel-icon'Daniel Eklöf2024-09-13-25/+248
|\
| * changelog: remove escape sequences we've revertedDaniel Eklöf2024-09-13-4/+0
| |
| * csi: revert implementation of CSI 20 tDaniel Eklöf2024-09-13-10/+1
| |
| * osc: OSC-1 does not set the icon, it sets the icon _label_Daniel Eklöf2024-09-13-46/+8
| | | | | | | | | | | | | | | | | | | | In fact, there appears there *is* no escape sequence to set the icon. Keep most of the logic in place, but in practice, we'll always set the icon to the app-id. That is, at startup, we set it to the configured app-id (either from config, or the command line). OSC-176, which sets the app-id, also updates the icon (to the app-id).
| * main: include toplevel-icon support in --version outputDaniel Eklöf2024-09-13-8/+24
| |
| * pgo: add missing stub for render_refresh_icon()Daniel Eklöf2024-09-13-0/+1
| |
| * toplevel-icon: implement OSC-1, CSI 20/21/22/23 tDaniel Eklöf2024-09-13-26/+214
| | | | | | | | | | | | | | | | | | | | | | | | | | | | * The toplevel icon is now set to the app-id, unless "overridden" by OSC-1 or OSC-0. * Implemented OSC-1 * OSC-0 extended to also set the icon * Implemented CSI 20 t - report window icon * Implemented CSI 21 t - report window title * Implemented CSI 22 ; 1 t - push window icon * Implemented CS 23 ; 1 t - pop window icon * Extended CSI 22/23 ; 0 t to also push/pop the icon * Verify app-id set by OSC-176 is valid UTF-8 * Verify icon set by OSC-0/1 is valid UTF-8
| * changelog: xdg-toplevel-icon-v1Daniel Eklöf2024-09-13-0/+1
| |
| * toplevel-icon: set to app-id, instead of hardcoding to "foot"Daniel Eklöf2024-09-13-4/+29
| | | | | | | | And, special case "footclient", and map it to "foot".
| * wayland: set toplevel iconDaniel Eklöf2024-09-13-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the xdg-toplevel-icon-v1 protocol is available, and we have the corresponding manager global, set the toplevel icon to "foot". Note: we do *not* provide any pixel data. This is by design; we want to keep things simple. To be able to provide pixel data, we would have to either: * embed the raw pixel data in the foot binary * link against either libpng or/and e.g. nanosvg, locate, at run-time, the paths to our own icons, and load them at run-time. * link against either libpng or/and e.g. nanosvg, and, at run-time, do a full icon lookup. This would also require us to add a config option for which icon theme to use. Of the two, I would prefer the first option. But, let's skip this completely for now. By providing the icon as a name, the compositor will have to lookup the icon itself. Compositors supporting icons is likely to already support this. So what do we gain by implementing this protocol? Compositors no longer has to parse .desktop files and map our app-id to find the icon to use. There's one question remaining. With this patch, the icon name is hardcoded to "foot", just like our .desktop files. But, perhaps we should use the app-id instead? And if so, should we also change the icon when the app-id changes? My gut feeling is, yes, we should use the app-id instead, and yes, we should update the icon when the app-id is changed at run-time.
| * wayland: bind the xdg-toplevel-icon manager globalDaniel Eklöf2024-09-13-0/+23
| |
| * meson: detect wayland-protocols >= 1.37, and conditionally enable xdg-toplevel-icon-v1Daniel Eklöf2024-09-13-0/+9
|/
* xsnprintf: various improvements related to xvsnprintf() and xsnprintf()Craig Barnes2024-09-13-35/+54
| | | | | | | | | | | | | | | | | | | | | | Summary of changes: * Make xvsnprintf() static * restrict-qualify pointer arguments (as done by the libc equivalents) * Make comments and spec references more thorough * Remove pointless `n <= INT_MAX` assertion (see comment) * Use FATAL_ERROR() instead of xassert() (since the assertion is inside a shared util function but the caller is responsible for ensuring the condition holds true) * Change some callers to use size_t instead of int for the return value (negative returns are impossible and all subsequent uses are size_t) The updated comments and code were taken (and adapted) from: https://gitlab.com/craigbarnes/dte/-/blob/49260bb154bca0434462a41c061e512540ec2e49/src/util/xsnprintf.c#L6-50 This work was entirely authored by me and I hereby license this contribution under the MIT license (stated explicitly, so that there's no ambiguity w.r.t. the original license).
* readme: typo: foot-ctlseq -> foot-ctlseqsCraig Barnes2024-09-11-1/+1
|
* render: resize(): don't overflow the number of scrollback linesDaniel Eklöf2024-09-09-4/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The config system allows setting the scrollback lines to 2**32-1. However, the total number of grid lines is the scrollback lines plus the window size, and then rounded *up* to the nearest power of two. Furthermore, the number of rows is represented with a plain 'int' throughout the code base. The largest positive integer that fits in an int is 2**31-1. That however, is not a power of two. The largest positive integer, that also is a power of two, that fits in an int is 2**30, or 1073741824. Ideally, we'd just cast the line count to a 64-bit integer, and call __builtin_clzl{,l}() on it, and then take the smallest value of that, or 2**30. But, for some reason, __builtin_clzl(), and __builtin_clzll() appears to ignore bits above 32, despite they being typed to long and long long. Bug? Instead, ensure we never call __builtin_clz() on anything larger than 2**30. Closes #1828
* readme: update mastodon linkDaniel Eklöf2024-09-08-1/+1
|
* desktop: rename to foot{,client,-server}.desktopDaniel Eklöf2024-09-08-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | That is, skip the reverse DNS naming scheme suggested by the .desktop specification, and directly match our app-ids ("foot", and "footclient"). This simplifies .desktop -> window instance mapping, allowing DEs to match the filenames directly, without having to look at the StartupWMClass key in the .desktop files. These are the original names of the .desktop files. There were renamed (to use the reverse DNS syntax) to please the flathub people, who *required* this scheme to accept the foot package. But, since: * We don't package foot ourselves * We don't go out of our way to support non-distro packaging schemes * Flathub still hasn't merged the foot PR (it's now 2 years old) * There are no know issues in any known DE that prevents a non-reverse DNS .desktop filename from working * There are plenty of other applications that doesn't use reverse DNS names (a very clear majority, in my case) Let's just revert back to the simpler naming scheme. Closes #1607
* .desktop: remove StartupWMClass cludgeDaniel Eklöf2024-09-08-2/+0
|
* metainfo: add recent releases, update feature listDaniel Eklöf2024-09-08-0/+6
|
* sixel: default bg color is now taken from the sixel palette, not the ANSI bg colorDaniel Eklöf2024-09-05-33/+7
| | | | | | | | | | | | | | | | The wording in the original VT340 documentation is vague: Pixel positions specified as 0 are set to the current background color. What does that mean? We _thought_ it meant the current ANSI background color, as set with e.g. CSI 4x m. It's still all a bit vague, but seeing that we have separate palettes for text and graphic (should we?), it doesn't make sense to use the ANSI background color as the default sixel background color. So, use entry 0 from the sixel palette instead.
* notifications: BEL and OSC-777 now focuses the window on notification activationDaniel Eklöf2024-09-05-4/+14
| | | | | | | | | | | Or put more propertly; if the notification daemon, and the notification helper used by foot has been configured properly (i.e. they both support XDG activation tokens), notifications generated by BEL and OSC-777 will now raise/focus the window when the default action of the notification is activated - typically by clicking the notification. Closes #1822
* changelog: strikeout-thicknessDaniel Eklöf2024-08-26-0/+1
|
* add setting for strikeout thicknessOleh Hushchenkov2024-08-26-2/+32
|
* changelog: mbsntoc32() failure checksDaniel Eklöf2024-08-20-0/+6
|
* term_set_window_title(): fix bad check for invalid UTF-8Daniel Eklöf2024-08-20-1/+1
| | | | mbsntoc32() returns (size_t)-1 on failure, not (char32_t)-1.
* osc: notify: fix bad check for invalid UTF-8Daniel Eklöf2024-08-20-2/+2
| | | | mbsntoc32() returns (size_t)-1 on failure, not (char32_t)-1.
* changelog: resize-keep-gridDaniel Eklöf2024-08-20-0/+8
|
* changelog: add missing reference to #1787Daniel Eklöf2024-08-20-0/+2
|
* feature: add resize-keep-grid to allow text reflow on font changesAndrew J. Hesford2024-08-20-1/+23
|
* render: follow cursor.unfocused-style regardless of cursor.styletokyo4j2024-08-20-12/+17
| | | | | Before this commit, cursor.unfocused-style was effective only with cursor.style=block
* term: thrd_join() returns thrd_success on success, not 0Daniel Eklöf2024-08-15-1/+1
| | | | Closes #1812
* changelog: add new 'unreleased' sectionDaniel Eklöf2024-08-14-0/+11
|
* Merge branch 'releases/1.18'Daniel Eklöf2024-08-14-6/+7
|\
| * meson: bump version to 1.18.11.18.1releases/1.18Daniel Eklöf2024-08-14-1/+1
| |
| * changelog: prepare for 1.18.1Daniel Eklöf2024-08-14-5/+6
| |
| * Merge branch 'master' into releases/1.18Daniel Eklöf2024-08-14-84/+369
| |\ | |/ |/|
* | osc: regression: fix OSC-111 handling of alpha changesDaniel Eklöf2024-08-14-1/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | When the background alpha changes from fully opaque, to transparent, or vice versa, we need to do more than just repaint the affected cells. For example, we need to create new surfaces with the correct pixel format. OSC-11 (set background color) already does this, but the same alpha checking logic was missing in OSC-111 (reset background color). Fixes #1801
* | utils/xtgettcap: fix possible NULL deref, found by -fanalyzerDaniel Eklöf2024-08-14-0/+3
| |
* | main: spell out the most common reason for setlocale() to failDaniel Eklöf2024-08-13-1/+2
| |
* | main: invalid locale != non-UTF-8 localeDaniel Eklöf2024-08-13-18/+35
| | | | | | | | | | | | | | | | When doing locale fallback, and printing user notifications and log warnings, better separate the case "locale is invalid" from "locale is valid but not UTF-8". Closes #1798
* | slave: prefix user notifications with 'foot'Daniel Eklöf2024-08-09-1/+3
| | | | | | | | To make it clearer _who_ is emitting the warning/errors
* | osc: kitty: update 's' to the latest specDaniel Eklöf2024-08-09-1/+17
| | | | | | | | | | | | | | * The spec now defines a couple of "standard" names. Translate these to the freedesktop compliant names. * The query response no longer contains 'xdg-names', but instead list the supported standard names.
* | doc: foot.ini: document the Unicode ranges covered by the builtin glyphsDaniel Eklöf2024-08-09-3/+11
| |
* | csd: track pointer when rendering and handling CSD button clicksDaniel Eklöf2024-08-09-12/+98
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Render button as highlighted only when pointer is above them * Releasing the mouse button while *not* on the button does *not* activate the button When pressing, and holding, a mouse button, the compositor keeps sending motion events for the surface where the button was pressed, even if the mouse has moved outside it. We also don't get any surface leave/enter events. This meant that the button was rendered as highlighted, and a click registered, if the user pressed the mouse button while on the button, and then moved the cursor away from the button before releasing the button. This patch fixes it, by checking if the current cursor coordinates fall within the button surface.
* | input: CSD buttons are now triggered when releasing the mouse buttonDaniel Eklöf2024-08-09-3/+19
| | | | | | | | | | | | | | | | | | | | | | | | This is how most UIs work. Note that we (at least on River) don't get any surface enter/leave events while a button is held. This means we can't detect if the user pressed the mouse button while on a CSD button, but then moves the mouse outside. Releasing the mouse button will still activate the CSD button. Closes #1787
* | meson: add "prefix: '#include <unistd.h>" to cc.has_function()Daniel Eklöf2024-08-09-2/+5
| | | | | | | | When checking for execvpe, include <unistd.h>
* | meson: fix false positive detection of `memfd_create`Shogo Yamazaki2024-08-09-1/+2
| | | | | | | | | | Add the arguments to `has_function` to properly detect availability of the function on SDK environments.
* | readme: remove CI badges for gitlab and sr.htDaniel Eklöf2024-08-07-2/+0
| |
* | readme: repology: use four columns instead of threeDaniel Eklöf2024-08-07-1/+1
| |
* | readme: repology: use three columns instead of oneDaniel Eklöf2024-08-07-1/+1
| |
* | changelog: osc-99: sound supportDaniel Eklöf2024-08-04-0/+8
| |
* | osc: kitty notifications: add support for XDG sound namesDaniel Eklöf2024-08-04-9/+31
| |
* | osc: kitty notifications: implement s=silentDaniel Eklöf2024-08-04-11/+43
| | | | | | | | | | | | | | | | This implements part of the new 's' (sound) parameter; the 'silent' value. When s=silent, we set the ${muted} template argument to "true". It is intended to set the 'suppress-sound' hint: notify-send --hint BOOLEAN:suppress-sound:${muted}
* | term: reload_fonts(): don't ignore return value of thrd_join()Daniel Eklöf2024-08-04-2/+4
| | | | | | | | | | | | | | | | | | | | This should fix the ‘ret’ may be used uninitialized warning Closes #1789
* | Merge branch 'xstrjoin3'Craig Barnes2024-08-03-29/+42
|\ \
| * | xmalloc: remove delim param from xstrjoin() and add separate xstrjoin3()Craig Barnes2024-08-03-29/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This avoids the need for an unused third argument for most xstrjoin() calls and replaces the cases where it's needed with a more flexible function. Code generation is the same in both cases, when there are 2 string params and a compile-time known delimiter. This commit also converts 4 uses of xasprintf() to use xstrjoin*(). See also: https://godbolt.org/z/xsjrhv9b6
* | | osc: kitty notifications: ignore invalid IDsDaniel Eklöf2024-08-03-3/+33
|/ / | | | | | | | | | | | | | | | | | | | | | | | | Notification IDs must only use characters from [a-zA-Z0-9_-+.] Terminals **must** sanitize ids received from client programs before sending them back in responses, to mitigate input injection based attacks. That is, they must either reject ids containing characters not from the above set, or remove bad characters when reading ids sent to them. Foot implements the first: reject IDs containing characters not from the above set.
* | changelog: add new 'unreleased' sectionDaniel Eklöf2024-08-02-0/+11
| |
* | Merge branch 'releases/1.18'Daniel Eklöf2024-08-02-5/+11
|\|
| * meson: bump version to 1.18.01.18.0Daniel Eklöf2024-08-02-1/+1
| |
| * changelog: prepare for 1.18.0Daniel Eklöf2024-08-02-4/+10
|/
* readme: typo: foot -> foot'sDaniel Eklöf2024-08-02-1/+1
|
* readme: xtgettcap: mention tigetstr() compabilityDaniel Eklöf2024-08-02-0/+4
|
* changelog: more template parameters we've added to desktop-notificationsDaniel Eklöf2024-08-02-2/+3
|
* Remove a number of unused includesDaniel Eklöf2024-08-02-8/+0
|
* notify: codespell: programatically -> programmaticallyDaniel Eklöf2024-08-02-1/+1
|
* notify: codespell: notificaton -> notificationDaniel Eklöf2024-08-02-1/+1
|
* doc: foot.ini: codespell: furhermore -> furthermoreDaniel Eklöf2024-08-02-1/+1
|
* osc: kitty notifications: cleanup and update to latest version of specDaniel Eklöf2024-08-02-244/+293
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Don't store a list of unfinished notifications. Use a single one. If the notification ID of the 'current' notification doesn't match the previous, unfinished one, the 'current' notification replaces the previous one, instead of updating it. * Update xstrjoin() to take an optional delimiter (for example ','), and use that when joining categories and 'alive IDs'. * Rename ${action-arg} to ${action-argument} * Update handling of the 'n' parameter (symbolic icon name); the spec allows it to be used multiple times, and the terminal is supposed to pick the first one it can resolve. Foot can't resolve icons at all, neither can 'notify-send' or 'fyi' (which is what foot typically executes to display a notification); it's the notification daemon that resolves icons. The spec _could_ be interpreted to mean the terminal should lookup .desktop files, and use the value of the 'Icon' key from the first matching .desktop files. But foot doesn't read .desktop files, and I don't intend to implement XDG directory scanning and parsing of .desktop files just to figure out which icon to use. Instead, use a simple heuristics; use the *shortest* symbolic names. The idea is pretty simple: plain icon names are typically shorter than .desktop file IDs.
* notify: don't forget terminating NULL when patching notify helper's argvDaniel Eklöf2024-07-31-6/+10
|
* osc: kitty notifications: buttons, icons, app-name, categories etcDaniel Eklöf2024-07-31-78/+580
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | First, icons have been finalized in the specification. There were only three things we needed to adjust: * symbolic names are base64 encoded * there are a couple of OSC-99 defined symbolic names that need to be translated to the corresponding XDG icon name. * allow in-band icons without a cache ID (that is, allow applications to use p=icon without having to cache the icon first). Second, add support for the following new additions to the protocol: * 'f': custom app-name, overrides the terminal's app-id * 't': categories * 'p=alive': lets applications poll for currently active notifications * 'id' is now 'unset' by default, rather than "0" * 'w': expire time (i.e. notification timeout) * "buttons": aka actions. This lets applications add additional (to the terminal defined "default" action) actions. The 'activated' event has been updated to report which button/action was used to activate the notification. To support button/actions, desktop-notifications.command had to be reworked a bit. There's now a new config option: desktop-notifications.command-action-arg. It has two template arguments ${action-name} and ${action-label}. command-action-arg gets expanded for *each* action. ${action-name} and ${action-label} has been replaced by ${action-arg} in command. This is a somewhat special template, in that it gets replaced by *all* instances of the expanded actions.
* notify: disable debug loggingDaniel Eklöf2024-07-30-1/+1
|
* notify: remove debug assertionDaniel Eklöf2024-07-30-3/+1
| | | | (FD 0 _is_ valid, after all)
* notify: ${icon}: don't fallback to app-idDaniel Eklöf2024-07-30-8/+5
| | | | | | * Revert --icon to ${app-id} * Use --hint STRING:image-path:${icon} instead * ${icon} no longer expands to ${app-id} if notification has no icon
* notify: don't close FD 0Daniel Eklöf2024-07-30-4/+11
| | | | | | | | | | | | | | | This fixes a regression where closing a terminal instance, or hard- or soft-resetting a terminal caused FD 0 to be closed. This meant it became re-usable. Usually, by memfd_create() when allocating a new surface buffer. So far nothing _really_ bad has happened. But what if FD 0 is now used by a memfd, and we close _another_ terminal instance? This causes our memfd to be closed. And then, when e.g. trying to scroll the terminal content: fallocate() fails with bad FD.
* readme: IRC: update link to point to the web interfaceDaniel Eklöf2024-07-27-2/+3
|
* readme: update mastodon linkDaniel Eklöf2024-07-27-1/+1
|
* notify: close notification by sending SIGINT to helperDaniel Eklöf2024-07-26-29/+65
| | | | | | | | | | | | | If the user hasn't configured a custom 'desktop-notifications.close' command, try to close the notification by sending SIGINT to the notification helper. This is best-effort: * If there's no helper running, we do nothing (except warn) * We don't verify, in any way, the notification is actually closed * We don't send any other signals, under any circumstances. That is, no SIGTERM, no SIGKILL. Ever.
* pgo: add notify_close() stubDaniel Eklöf2024-07-25-0/+5
|
* osc: kitty notifications: implement the 'close' requestDaniel Eklöf2024-07-25-9/+92
| | | | | | | | | | | | | | | | Add a new config option, desktop-notifications.close, defining what to execute to close a notification. It has a single template parameter, ${id}, that is expanded to the external notification ID foot may have picked up from the notification helper. notify-send does not support closing notifications, and it appears impossible to pass an *unsigned* integer as argument to gdbus. Hence no default value for the new 'close' option. Example: printf '\e]99;i=123;this is a notification\e\\' printf '\e]99;i=123:p=close;\e\\'
* osc: kitty notification: implement 'close' eventsDaniel Eklöf2024-07-25-6/+30
| | | | | | Application can now request to receive a 'close' event when the notification is closed (but not necessarily activated), by adding 'c=1' to the notification request.
* notify: rename 'report' -> 'report_activated'Daniel Eklöf2024-07-25-5/+5
|
* notify: kitty notifications: fix ID string in activation eventDaniel Eklöf2024-07-25-2/+2
| | | | We forgot to prefix the notification ID with 'i='
* Merge branch 'kitty-notifications'Daniel Eklöf2024-07-25-99/+1087
|\
| * osc+notify: strcmp() -> streq()Daniel Eklöf2024-07-24-13/+13
| |