| Commit message (Collapse) | Author | Age | Lines |
| | |
|
| | |
|
| |
|
|
|
| |
This was disabled while implementing multi-seat support, and I forgot
to fix and re-enable before that feature was merged.
|
| | |
|
| |\
| |
| |
| | |
Closes https://codeberg.org/dnkl/foot/issues/29
|
| | |\
| |/
|/| |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When we're handling the initial set of globals, the data-device and
primary-selection-device objects may, or may not be registered before
the seat(s).
We need to handle both cases.
When adding a seat, instantiate the data-device and
primary-selection-device **if available**.
When adding the device objects, instantiate them on **all** currently
available seats.
|
| | | |
|
| | |
| |
| |
| |
| | |
When all cells were empty, we'll have written 0 bytes to the buffer
and hence it will still be un-allocated (i.e. NULL).
|
| | |\
| |/
|/| |
|
| | |
| |
| |
| |
| |
| |
| |
| | |
Remove assertion that row be less than the scrolling region end. The
cursor may in fact be *inside* the margin.
Inside the margin, content never scrolls, but we must make sure we
don't move the cursor outside the grid.
|
| | |
| |
| |
| |
| | |
Two sixel may in fact exist on the same row, assuming their columns
don't overlap.
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| | |
This ensures *all* bytes mapped to action_print() have wcwidth == 1.
DEL has wcwidth == -1, and would thus have been ignored by
term_print() anwyway.
|
| | | |
|
| |\ \
| | |
| | |
| | | |
Closes https://codeberg.org/dnkl/foot/issues/38
|
| | | | |
|
| |/ / |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| |
| |
| | |
Since it isn't NULL-terminated.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The pipe command can contain almost all printable characters. In
particular, we can expect it to contain '='.
Having the pipe command as part of the key breaks the key/value
splitting.
Change it so that it is instead an optional initial part of the value,
enclosed in '[]'.
I.e. instead of
pipe-visible:cmd=binding
we now need to write
pipe-visible=[cmd] binding
|
| | | |
|
| | |
| |
| |
| |
| | |
If the bindings has different pipe command associated with them, treat
them as different actions.
|
| | | |
|
| | |
| |
| |
| |
| | |
If not -1, spawn() will redirect the child's stdin/stdout/stderr to
these FDs.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
A key binding may now have an optional ':<cmd>' string appended to the
key.
This is intended to be used like so:
pipe-scrollback:sh -c "cat > file"=Print
TODO: we still only allow one *action*. Meaning you still cannot
specify multiple pipe-scrollback bindings, for example.
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| | |
These functions extract the current view, or the entire scrollback as
an UTF-8 encoded byte buffer.
|
| | |
| |
| |
| |
| |
| | |
This allows us to safely call extract_finish() when extract_one()
failed, and we'll get the expected result; false, indicating
extract_finish() failed.
|
| | |
| |
| |
| |
| | |
extract_one() takes const pointers, while the callback argument to
foreach() expects non-const.
|
| | | |
|
| | | |
|
| |/ |
|
| |
|
|
| |
This reverts commit b2dec8db164645cebb82a114564ce231518e6494.
|
| | |
|
| |
|
|
|
|
|
|
| |
As that breaks e.g. selection marking (SPACER cells didn't get
inverted when rendered).
Instead, skip them in extract_one() only. I.e. when copying text from
the grid.
|
| | |
|
| | |
|
| |\ |
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| | |
And refactor: break out spacer-writing code to a function, since we do
exactly the same thing in two places.
|
| | |
| |
| |
| |
| | |
This is handled by the generic foreach() functions, which now simply
skips spacer cells.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
Ignore *old* cells containing spacers.
Pad new grid with spacers if a multi-column character doesn't fit at
the end of a line.
Insert spacers after a multi-column character.
|
| | |
| |
| |
| | |
Otherwise we end up overwriting the character in the last column
|
| | |
| |
| |
| |
| |
| | |
When printing a multi-column character, write CELL_MULT_COL_SPACER
instead of '0' to both padding cells (when character doesn't fit at
the end of the line), and to the cells following the actual character.
|
| |/ |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
When printing a multi-column character at the end of the line, and it
doesn't fit, we currently insert a forced line-wrap. This means the
last character(s) on the previous line will be empty, followed by a
multi-column character in the first cell on the next line.
Without special code to handle this, the selection text extraction
code will insert a hard newline, since this is normally the correct
thing to do.
Add a TODO, to consider writing a special place holder value to these
padding cells.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
We know we're within bounds, and thus we don't need the extra overhead
of term_cursor_right().
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
| |
While this might seem like it would slow down things, it should in
fact help the compiler optimize: the "normal" code path, that prints
regular ASCII characters, always call term_print() with width == 1.
|
| |
|
|
|
| |
line-wrap is in the hot path, and term_cursor_down/left adds
additional checks that we don't need.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
There's nothing wrong with using term_cursor_right(), but it is
unnecessary since we already check for the end-of-line.
|
| | |
|
| |
|
|
|
|
| |
LF should always clear LCF. Previously, it was done implicitly in
term_cursor_down(). I.e it was cleared as long as the cursor wasn't at
the bottom of the scrolling region
|
| |
|
|
|
|
| |
According to the specification, HT **should** clear LCF. However,
nearly all emulators do not. In particular, XTerm doesn't. So we
follow suite.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
| |
Previously, C0::VT was implemented as a simple 'cursor down'. I.e. it
would behave as LF **until** it reached the bottom of the screen,
where instead of scrolling, it became a no-op.
See https://vt100.net/docs/vt102-ug/chapter5.html
|
| | |
|
| | |
|
| | |
|
| | |
|
| |\
| |
| |
| | |
Closes #35
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The commit log says that was needed to get tiling in GNOME
working. However, I don't know *which* extension that was.
Force resizing in a configure event means we'll trash a perfectly
valid buffer on e.g. 'activated' state changes.
So, let's revert this for now, and if this breaks GNOME, let's try to
find another solution. If worse comes to worse, we can detect if we're
running under GNOME and do a force-resize then, but not on sane
compositors.
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When applying scroll damage, we may have to re-render the
margins.
This is because when we SHM-scroll, we actually move the entire
surface, and thus we end up overwriting the top margin area with old
window content, and scroll in uninitialized memory in the bottom
margin.
But, we don't have to tell the compositor about this - the last frame
always contains correct margins; i.e. there's no change between the
last frame and current frame being rendered.
TODO: we _could_ micro-optimize and only damage the margins after a
surface resize. We do it slightly more often now, when dealing with
state changes in screen flash or scrollback searching. But I don't
think it's worth the effort.
|
| | | |
|
| | |
| |
| |
| |
| | |
This fixes an issue where e.g. failing to initialize the Wayland
backend would leave cwd un-free:d
|
| | | |
|
| | |
| |
| |
| | |
All calls to render_margin() set top=true and bottom=true anyway.
|
| |/ |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of locking the queue for each dirty row we append, and
signaling a condition variable, just keep the lock while going through
the visible rows.
Release the lock once done.
Since we take the lock *before* posting the 'start' semaphore, all
workers will be waiting for the lock to be released.
Then, one at a time they'll get the lock and pick a row to
render. The queue will never get empty - when all rows have been
rendered, each worker will pick a 'frame done' "job" from the queue,
and break the rendering loop.
|
| |\ |
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Previously, we had to explicitly render the old cursor cell *before*
applying scrolling damage.
We then rendered all the dirty rows, *without* rendering the cursor -
even if the cursor cell was among the dirty rows.
Finally, when everything else was done, we explicitly rendered the
cursor cell.
This meant a lot of code, and unnecessary render_cell() calls, along
with unnecessary wl_surface_damage_buffer() calls.
This was a necessary in the early design of foot, but not anymore.
We can simply mark both the old cursor cell, and the current one, as
dirty and let the normal rendering framework render it. All we need to
do is pass the cursor column to render_row(), so that it can pass
has_cursor=true in the appropriate call to render_cell(). We pass -1
here for all rows, except the cursor's row, where we pass the actual
cursor column.
With this, there's no need to calculate whether the cursor is visible
or not; just mark it's cell as dirty, and if that row is visible, the
normal rendering will take care of it.
This also simplifies the state needed to be saved between two frames;
we only need a row pointer, and the cursor column index.
Part of https://codeberg.org/dnkl/foot/issues/35
|
| |/ |
|
| | |
|
| | |
|
| | |
|