aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeLines
* meson/pkgbuild: bump version to 1.5.41.5.4releases/1.5Daniel Eklöf2020-12-01-2/+2
|
* input: relax requirements for overriding keypad application modeDaniel Eklöf2020-12-01-9/+1
| | | | | | Don’t require NumLock to be locked. Foot has no idea _which_ modifier the user has mapped NumLock to, meaning we really cannot require it to be locked.
* keymap: add ‘CSI 27;<mod>;27~’ escapes for Esc with modifiersDaniel Eklöf2020-12-01-0/+16
|
* doc: foot.5: minor highlighting fixesDaniel Eklöf2020-12-01-5/+6
|
* doc: foot.1: no need to say foot.ini twiceDaniel Eklöf2020-12-01-1/+1
|
* changelog: update contributorsDaniel Eklöf2020-12-01-0/+5
|
* render: don’t call term_arm_blink_timer() from multiple threadsDaniel Eklöf2020-12-01-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | We call term_arm_blink_timer() from render_cell(), which runs in multiple threads. This caused multiple blink timer FDs to be created and registered with the FDM, later causing read failures after one of those FDs had been closed again. This rarely happened under normal circumstances, but was easy to trigger when the whole screen was full of blinking text. As a small optimization, we don’t bother taking the lock if the timer FD already is valid. This is safe, because: 1) If the timer FD isn’t valid, we take the lock and then call term_arm_blink_timer(), which again checks if the FD is already valid. 2) The blink timer FD cannot be closed while we’re rendering cells. It is only disabled in the FDM callback, which cannot execute while we’re rendering.
* sixel: fix crash when an explicit sixel size had a height less than 6 pixelsDaniel Eklöf2020-12-01-4/+2
|
* client: fix handling of "-m" command-line flagCraig Barnes2020-12-01-1/+2
|
* render: allow-overflow: require a space in the next cellDaniel Eklöf2020-12-01-1/+5
| | | | | | | | When checking if we should allow a single-width character double-width glyph to overflow into the next cell, require the next cell to either be empty, or contain a space. Closes #203
* keymap: fix alt+return combosDaniel Eklöf2020-12-01-11/+12
| | | | | | | | All alt+return combos mapped to the same escape sequence as alt+return itself. With this patch, alt+<mod(s)>+return map to a standard ‘CSI 27;x;13~’ sequence.
* keymap: use same lookup table for Tab and ISO_Left_TabDaniel Eklöf2020-12-01-7/+5
| | | | | | | | | | | | | | With XKB, Shift+Tab maps to XKB_KEY_ISO_Left_Tab, not XKB_Key_Tab. Previously, we had two different lookup tables for the two. The tab table was correctly populated, while the ISO-left tab wasn’t. As a result, all Shift+Tab combos (except Shift+Tab itself) was wrong, and resulted in the same escape sequence as Shift+Tab. Fix by using the same table for both tab and ISO-left tab. Closes #210
* readme: don’t uppercase titlesDaniel Eklöf2020-12-01-2/+2
|
* config: enable allow-overflowing-double-width-glyphs by defaultDaniel Eklöf2020-12-01-5/+9
|
* changelog: fix link to readme#keypadDaniel Eklöf2020-12-01-2/+3
|
* readme/doc:foot.1: document the (new) keypad behaviorDaniel Eklöf2020-12-01-1/+44
|
* input: enforce ‘numerical’ keypad mode when Num Lock override is enabledDaniel Eklöf2020-12-01-4/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | When num lock override has been enabled via “CSI?1035h” (the default), keypad is always considered to be in ‘numerical’ mode. This affects how keypad keys are translated to escape sequences when Num Lock is active. The keypad has four modes: * Num Lock off, numerical mode * Num Lock off, application mode * Num Lock on, numerical mode * Num Lock on, application mode The keymap is identical for numerical and application mode when Num Lock is off, meaning the keypad effectively has three different modes. In XTerm, numerical and application mode _can_ be the same, **if** the ‘numLock’ resource is set to true (the default). It is only when ‘numLock’ is false that the application mode is actually used. This patch changes foot to do the same. We don’t expose an option, but do implement “CSI ? 1035”. Closes #194
* input: track num lock stateDaniel Eklöf2020-12-01-0/+6
|
* csi: implement “CSI ? 1035” - toggle Num Lock overrideDaniel Eklöf2020-12-01-0/+12
| | | | | This adds a num_lock_modifier state to the terminal, and hooks up “CSI?1035h/l” to toggle it.
* input: use XKB_MOD_NAME_* macros instead of hard-coded stringsDaniel Eklöf2020-12-01-4/+4
|
* wayland: preempt render scheduling in ‘configure’ eventsDaniel Eklöf2020-12-01-5/+17
| | | | | | | | | | | | | | | | | | | | | | | | A configure event must be “committed”. In case of resizing, that means rendering a new frame and committing that surface. render_resize() will resize the grid and *schedule* a render refresh. However, if one is already pending, the refresh will take a very (relatively) long time - until the next frame callback is received. This poses a problem when the window is hidden, since in this case, the frame callback *never* comes. This in turn means we fail to commit a new surface in response to the ‘configure’ event. And that means the compositor needs to wait for a transaction timeout before continuing. The end effect is very slow and jerky window resizing when a hidden foot window is being resized. This can happen in tiled compositors, like Sway, where a window can be tabbed (and thus invisible), but still resized when its container is resized. Closes #190
* changelog: add entry for 1.5.4Daniel Eklöf2020-12-01-0/+7
|
* meson/pkgbuild: bump version to 1.5.31.5.3Daniel Eklöf2020-11-06-2/+2
|
* selection: fix enum typeDaniel Eklöf2020-11-06-1/+1
| | | | | | | | enum selection_scroll_direction is used when extending a selection by auto-scrolling the terminal content while the mouse is outside the grid. What we want is enum selection_direction.
* selection: explicitly set direction when right-click extendingDaniel Eklöf2020-11-06-0/+8
| | | | | | | Fixes an issue where right-click-and-dragging to extend a selection caused one cell being removed from the selection. Closes #180
* input: don’t use seat->kbd_focus as terminal when processing a key pressDaniel Eklöf2020-11-06-15/+27
| | | | | | | | | | | | When converting mouse scroll events to keyboard input (in alternate scroll mode), we need to use seat->mouse_focus, not seat->kbd_focus. To enable this, break out key press/release handling code to a separate function that takes an explicit term argument. Call this function from keyboard_key(), input_repeat() and in alternate scroll mode. Closes #179
* tiocswinsz: fix compilation error on e.g. ppc64Daniel Eklöf2020-11-06-2/+5
| | | | | | | | | | | | | | | | | | | | | | | On some platforms, TIOCSWINSZ has a very large value, > 0x80000000. On some platforms, the `request` argument to `ioctl(3)` is an `int`. For platforms where both of the above is true, gcc will warn (and error out if compiled with `-Werror`) on: ioctl(fd, TIOCSWINSZ, ...) To silence this warning, we need to cast `TIOCSWINSZ` to an integer. However, doing this on platforms where `request` is an `unsigned long` will result in `TIOCSWINSZ` being sign-extended (and thus we end up with an invalid value). It seems that casting to `unsigned int` works in both cases; it silences the long -> int conversion warning, while also preserving the correct value in all cases.
* main: remove trailing ‘, ’ from arch log lineDaniel Eklöf2020-11-06-1/+1
|
* input: handle XKB errorsDaniel Eklöf2020-11-06-58/+74
| | | | | | | | | | | * Don’t de-reference the xkb context/keymap/state if we failed to instantiate them. * Don’t try to send a translated utf8 key sequence if the translation failed. * Handle xkb_compose_state_get_utf8() and xkb_state_key_get_utf8() returning more than 64 bytes. This _may_ fix #171.
* input: don’t allow diagonal resize when tiledDaniel Eklöf2020-11-06-8/+13
|
* wayland: properly restore window size when being un-tiledDaniel Eklöf2020-11-06-17/+52
| | | | | | | | Bind to xdg-shell version 2 if available, as this enables us to track our window’s ‘tiled’ state in the ‘configure’ events. This in turn allows us to stash the ‘old’ window size when being tiled, to be used again when restoring the window size when un-tiled.
* input: don’t crash if xkbcommon cannot find a compose fileDaniel Eklöf2020-11-06-8/+28
| | | | | | | | Handle xkb_compose_table_new_from_locale() returning NULL. When this happens, log a warning that “dead keys” will be disabled, and make sure to never de-reference the compose table pointer. Closes #170
* changelog: prepare for 1.5.3Daniel Eklöf2020-11-06-0/+5
|
* shm: MAP_UNINITIALIZED is a linux only mmap flagDaniel Eklöf2020-10-13-0/+4
|
* meson/pkgbuild: bump version to 1.5.21.5.2Daniel Eklöf2020-10-13-2/+2
|
* input: regression: don’t pass on mouse click to application if we consumed itDaniel Eklöf2020-10-13-7/+18
| | | | | | | | | | | | | When we ‘consume’ a mouse button event (i.e. when we have a shortcut mapped to it), the event should *not* be passed on to the client application. In 5f64c5c33590a41afd3f621870c6abd89b859073, button handling was refactored and unfortunately introduced a regression where we once again started passing consumed button presses to the client application. Fixes #168
* meson/pkgbuild: bump version to 1.5.11.5.1Daniel Eklöf2020-10-11-2/+2
|
* changelog: prepare for 1.5.1Daniel Eklöf2020-10-11-6/+3
|
* changelog: remove duplicate entryDaniel Eklöf2020-10-11-4/+0
|
* readme/doc: add shift+insert to list of default key bindingsDaniel Eklöf2020-10-11-0/+6
|
* changelog: update ‘contributors’ listDaniel Eklöf2020-10-11-0/+1
|
* selection: use appropriate check for PRIMARY pasteSergey Nazaryev2020-10-11-2/+3
| | | | | | Assume it could be a copy-paste typo. We should check PRIMARY, not CLIPBOARD. Without this fix, we can't use PRIMARY until we copy anything to CLIPBOARD.
* config: bind shift+insert to primary-paste by defaultDaniel Eklöf2020-10-11-2/+6
|
* changelog: add contributorDaniel Eklöf2020-10-11-0/+2
|
* config: fix "-Wformat-nonliteral" warningsCraig Barnes2020-10-11-3/+3
|
* readme: minor rewrite of server/daemon sectionDaniel Eklöf2020-10-11-7/+5
|
* csi: only respond to Primary DA when Ps == 0Daniel Eklöf2020-10-11-0/+6
|
* readme: clearer descriptions of secondary and tertiary DA responsesDaniel Eklöf2020-10-11-9/+5
|
* term: remove unused bit in xtsave structDaniel Eklöf2020-10-11-1/+0
|
* changelog: we’ve fixed several sixel+reflow related bugsDaniel Eklöf2020-10-11-0/+2
|
* sixel: reflow: drop sixels that crosses the scrollback history’s endDaniel Eklöf2020-10-11-0/+23
| | | | | This fixes various crashes that occurred after a reflow due to the sixel image list invariants no longer being true.
* sixel: unhook: do overwrite *after* linefeedingDaniel Eklöf2020-10-11-2/+5
| | | | | This ensures the overwrite is done when the scrollback history is in the same state as when we then insert the new image.
* sixel: overwrite: use pixman to calculate new the sixel boundariesDaniel Eklöf2020-10-11-75/+74
| | | | | | When punching a hole in a sixel (and thus splitting it up into up to four new sixels), use pixman to calculate the new sixel coordinates and sizes.
* sixel: ovewrite-by-rectangle: in debug builds, cross-reference against pixmanDaniel Eklöf2020-10-11-2/+38
| | | | | Use pixman to calculate the intersection of the rectangle being overwritten, and the sixel(s). Verify our code matches.
* sixel: verify scrollback consistency: new verify functionDaniel Eklöf2020-10-11-0/+26
| | | | Verifies sixels have been scrolled out correctly
* sixel: add comments to verify_*() functionsDaniel Eklöf2020-10-11-0/+23
|
* sixel: verify-*: don’t return anything; rely on asserts onlyDaniel Eklöf2020-10-11-18/+7
|
* sixel: scroll up/down: early return when list is emptyDaniel Eklöf2020-10-11-0/+6
| | | | Branch tagged as ‘likely’ for performance reason
* sixel: cell-size-changed: don’t verify sixels hereDaniel Eklöf2020-10-11-2/+0
| | | | | | | | | | | | | The state after this function is an intermediate state and isn’t necessarily valid. This sixels needs to be ‘reflowed’ to ensure a valid state. This is something that should be done by the caller after the text grid has been reflowed and the sixel coordinates have been re-mapped to the new grid. TODO: can/should we update the sixel cols/rows in sixel_reflow() instead?
* sixel: unhook: look total number of sixelsDaniel Eklöf2020-10-11-0/+3
| | | | | This helps debug sixel overwrites, as it makes it more visible when there are sixels that _should_ have been removed.
* sixel: scroll-up: don’t break out early of loopDaniel Eklöf2020-10-11-2/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This function loops the list of sixels, and discards those that would be scrolled out if the grid offset is moved forward by the specified number of rows. The criteria is when the rebased row value is less than the number of rows to scroll. A rebased row number is a zero-based number starting at the beginning of the scrollback. Thus, when scrolling 5 rows, rows with a rebased row number between 0-4 will be scrolled out. For performance reasons, we used to break out of the loop as soon as a row number *larger* than the scroll count. This however does not work. The sixels are sorted by their *end* row. While this works in most cases (think images outputted in the shell in the normal screen), it doesn’t always. In the alt screen, where applications can print images just about anywhere, it is possible to have *any* start row number anywhere in the sixel list. Just as long as their *end* row numbers are sorted. For example, a huuuge sixel that covers the entire scrollback. This sixel will naturally be first in the list (and thus sixel_scroll_up() will visit it *last*, since it iterates the list in reverse), but should still be destroyed when scrolling.
* sixel: verify-list-order: add an ‘index’ variableDaniel Eklöf2020-10-11-0/+4
| | | | This will make it easier when debugging assertions in this function.
* sixel: overwrite-by-rectangle: assert sixels don’t cross scrollback wrap-aroundDaniel Eklöf2020-10-11-4/+7
|
* sixel: scroll: call sixel_erase() instead of sixel_destroy()Daniel Eklöf2020-10-11-2/+2
| | | | | This ensures the screen is updated correctly. Without this, the sixel image would remain on screen until force-refreshed by some other means.
* sixel: TOOD -> TODO (fixes codespell build error)Daniel Eklöf2020-10-11-1/+1
|
* sixel: verify-no-overlap: free pixman regionsDaniel Eklöf2020-10-11-0/+5
|
* sixel: verify-no-overlap: initialize ‘intersection’ pixman regionDaniel Eklöf2020-10-11-0/+1
|
* render: resize: call sixel_reflow() after reflowing gridsDaniel Eklöf2020-10-11-0/+3
|
* sixel: unhook: only call render_refresh() onceDaniel Eklöf2020-10-11-2/+3
|
* sixel: implement reflowDaniel Eklöf2020-10-11-54/+51
| | | | | | | Move sixel reflow from grid_reflow() to sixel_reflow(). This lets us use internal sixel functions to update the sixels. Note that grid_reflow() still needs to remap the sixelss coordinates.
* term: update sixel rows/cols *after* cell dimension change, *before* resizeDaniel Eklöf2020-10-11-39/+27
| | | | | This fixes an issue where we resized+reflowed with bad rows/cols values in the sixels.
* sixel: verify-sixels: check for bad list order lastDaniel Eklöf2020-10-11-2/+2
|
* sixel: verify-no-wraparound-crossover: fix calculation of ‘end’ rowDaniel Eklöf2020-10-11-1/+1
|
* sixel: add sixel_cell_size_changed()Daniel Eklöf2020-10-11-0/+25
| | | | | This function should be called *after* the cell dimensions have changed, but *before* resizing/reflowing the grids.
* sixel: debug: more fine-grained verification of sixel image listDaniel Eklöf2020-10-11-5/+63
| | | | | * Verify no sixel crosses the scrollback wrap-around * Verify no sixels overlap
* grid: reflow: re-insert sixels *after* new grid offset has been setDaniel Eklöf2020-10-11-40/+51
| | | | | | Also make sure to destroy sixels that are too big to fit in the scrollback. Fixes issues with the sixel list not being sorted correctly.
* sixel: overwrite: calculate split-up image pieces’ rows/cols from their width/heightDaniel Eklöf2020-10-11-8/+3
|
* sixel: overwrite: remove assertsDaniel Eklöf2020-10-11-12/+1
| | | | Sixels may extend outside the visible screen area
* term: re-calculate sixel images’ rows/cols values when cell size changesDaniel Eklöf2020-10-11-0/+14
|
* sixel: fix sheared image when image crosses scrollback wrap-aroundDaniel Eklöf2020-10-11-1/+14
| | | | | | | | | | | | | | | When a sixel image crosses the scrollback wrap-around, it is split up into (at least) two pieces. We use cursor->point.col for all pieces’ x-coordinate. This caused the final image to appear sheared, since we do a carriage-return (after a number of linefeeds) after each piece - this causes the cursor’s position to be reset to the left margin. The solution is simple; remember the cursor’s initial x-coordinate, and use that to position all image pieces. Closes #151.
* sixel: overwrite-by-rectangle expects ‘width’ to not exceed screenDaniel Eklöf2020-10-11-1/+4
| | | | | | | | This fixes a crash when the emitted sixel extends beyond the right margin. The crash only happens when there are other sixel images already emitted. Fixes part of #151
* sixel: fold long lineDaniel Eklöf2020-10-11-1/+3
|
* doc: foot.1: remove ‘--’ from example command lineDaniel Eklöf2020-10-11-1/+1
|
* doc: foot.ini: mention that ‘lines’ is rounded up to nearest power of 2Daniel Eklöf2020-10-11-1/+3
|
* doc: foot.ini: “top at” -> “top of”Daniel Eklöf2020-10-11-1/+1
|
* doc: foot.ini: it’s foot.ini, not foot.initDaniel Eklöf2020-10-11-1/+1
|
* render: apply opacity correctly when in reverse video modeDaniel Eklöf2020-10-11-2/+9
|
* doc: foot.ini: the tweak section is called ‘tweak’, not ‘tweaks’Daniel Eklöf2020-10-11-1/+1
|
* config: ignore key/value pairs following an invalid section nameDaniel Eklöf2020-10-11-0/+9
| | | | | | | | | | | When we detected an invalid section name, we correctly logged this and warned the user. However, the internal state machine now had an invalid section enum value. This caused a crash when the next key/value pair was to be parsed and we tried to lookup which parser function to call. Closes #159.
* changelog: trackpad scrolling: ‘multiplier’ is in the ‘scrollback’ sectionDaniel Eklöf2020-10-11-2/+2
|
* changelog: multiplier: the option belongs to the ‘scrollback’ sectionDaniel Eklöf2020-10-11-2/+2
|
* changelog: multiplier default value changed from 1.0 -> 3.0Daniel Eklöf2020-10-11-0/+5
|
* config: change default multiplier from 1.0 -> 3.0Daniel Eklöf2020-10-11-3/+3
|
* changelog: reword trackpad scrolling speed entryDaniel Eklöf2020-10-11-0/+5
|
* input: trackpad scroll: correctly convert pixel movements to line movementsDaniel Eklöf2020-10-11-4/+12
| | | | | | | | | | | | Trackpad scroll movements are in pixels. Foot previously “translated” these directly to line movements (i.e. a one pixel scroll event was translated into a one line scroll). Now we use the line height of the terminal and correctly convert pixels to lines. This makes the trackpad scroll speed in foot consistent with the scroll speed in e.g. Alacritty and Kitty.
* grid: reflow: fix release build; ‘idx’ is only used in an assert()Daniel Eklöf2020-10-11-1/+2
|
* grid: reflow: handle viewport being too far down when enlarging the windowDaniel Eklöf2020-10-11-2/+17
| | | | | | If the viewport is close to the bottom, but not *at* the bottom, and we’re enlarging the window, the translated viewport will be too far down.
* grid: reflow: retain scrollback positionDaniel Eklöf2020-10-11-1/+12
| | | | Closes #142
* changelog: fixed color flashes with OSC 4,10,11Daniel Eklöf2020-10-11-0/+2
|
* render: remove render_refresh_margins()Daniel Eklöf2020-10-11-9/+0
|