aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeLines
...
| * render: scrollback indicator: subtract visible rows from populated rowsDaniel Eklöf2020-08-26-1/+1
| | | | | | | | | | This prevents the indicator from starting too high up when the number of used scrollback rows is low.
| * render: scrollback position: only count _used_ scrollback linesDaniel Eklöf2020-08-25-3/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | When calculating where in the scrollback history we are, we previously did this against the total number of scrollback lines. I.e. the `scrollback.lines` setting in `footrc`. Now, we count only the used/allocated scrollback lines. Note that the initial indicator position might still seem to start a bit high up, if the number of used scrollback lines is low. This is because we use the *top* of the screen for the current position. Thus, we'll never be at the bottom (except for the special case when we're *really* at the bottom).
* | Merge branch 'block-input-events-while-pasting' into masterDaniel Eklöf2020-08-27-64/+218
|\ \ | | | | | | | | | Closes #101
| * | selection: don't initiate a paste when we're already pastingDaniel Eklöf2020-08-25-0/+10
| | |
| * | selection: must use term_paste_data_to_slave() for paste dataDaniel Eklöf2020-08-25-1/+1
| | |
| * | term: enqueue data: cleanupDaniel Eklöf2020-08-25-14/+8
| | |
| * | selection: clipboard callback: assert we're in sending-paste-data modeDaniel Eklöf2020-08-25-0/+1
| | |
| * | changelog: fixed input events from getting mixed with paste dataDaniel Eklöf2020-08-25-0/+2
| | |
| * | selection: block non-paste data from being sent to client while pastingDaniel Eklöf2020-08-25-51/+131
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | While pasting data from the clipboard, block *all* other data from being sent to the client. This includes keyboard and mouse events, but also replies for VT queries. This is particularly important when bracketed paste has been enabled, since then the client will interpret *everything* between the bracketed paste start and end as paste data.
| * | selection: add a 2 second timeout when receiving clipboard dataDaniel Eklöf2020-08-25-11/+78
| | | | | | | | | | | | | | | | | | | | | | | | When reading clipboard data, a malicious clipboard provider could stall us forever, by not sending any data, and not closing the pipe. This commit adds a timer_fd based timeout of 2 seconds. If the timer triggers, we abort the clipboard receive.
* | | Merge branch 'xcalloc-fix' into masterDaniel Eklöf2020-08-26-4/+3
|\ \ \
| * | | xmalloc: fix edge case handling in xcalloc() functionCraig Barnes2020-08-25-4/+3
|/ / /
* | | Merge branch 'type-limit-fixes' into masterDaniel Eklöf2020-08-25-3/+5
|\ \ \ | |/ / |/| |
| * | fix some buggy comparisons relating to signed/unsigned typesCraig Barnes2020-08-25-3/+5
|/ /
* | Merge branch 'pedantic' into masterDaniel Eklöf2020-08-25-97/+145
|\ \ | |/ |/|
| * meson/pkgbuild: bump tllist requirement to 1.0.4Daniel Eklöf2020-08-25-2/+2
| | | | | | | | This is the first version of tllist that compiles with '-pedantic'.
| * meson: build with -pedanticDaniel Eklöf2020-08-23-1/+2
| |
| * selection: don't do "return function_returning_void()" in functions returning voidDaniel Eklöf2020-08-23-11/+22
| |
| * vt: hide pedantic warnings around the VT state machine's switch casesDaniel Eklöf2020-08-23-0/+9
| | | | | | | | | | | | The switch statements use the GCC extension "case X ... Y", and here it doesn't really make any sense to convert it to "case X: case Y:", so hide the warnings instead.
| * Don't use "case X ... Y:", if possible/where it makes senseDaniel Eklöf2020-08-23-7/+25
| |
| * Cast printf formatter %p arguments to void*Daniel Eklöf2020-08-23-23/+31
| |
| * log: include 'fmt' in __VA_ARGS__Daniel Eklöf2020-08-23-26/+27
| | | | | | | | | | This ensures all calls have at least one __VA_ARGS__ argument, thus making them ISO C99 compliant.
| * don't use empty struct initializersDaniel Eklöf2020-08-23-27/+27
| |
* | Merge branch 'message-fix' into masterDaniel Eklöf2020-08-23-1/+1
|\ \ | |/ |/|
| * synchronize config-error-message with available field valuesJonas 'cherti' Große Sundrup2020-08-23-1/+1
|/
* config: add user-configured search-binding to the correct binding listDaniel Eklöf2020-08-23-2/+2
| | | | Search bindings were added to the normal key binding list...
* Merge branch 'colorterm' into masterDaniel Eklöf2020-08-23-0/+3
|\
| * slave: set $COLORTERM environment variable to "truecolor"Craig Barnes2020-08-23-0/+3
|/ | | | | | | This is also done by libvte, alacritty, kitty and several other terminal emulators as a way to indicate support for 24-bit RGB colors. It generally also implies support for the xterm 256-color palette and basic ECMA-48 colors.
* Merge branch 'timespec-compare-fix' into masterDaniel Eklöf2020-08-23-3/+9
|\
| * csi: avoid using memcmp() to compare timespec structsCraig Barnes2020-08-23-3/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This struct may contain padding bytes, whose values are indeterminate after any store operation[1]. It may also contain unnamed members, whose values are always indeterminate[2]. Using memcmp() isn't a reliable way to compare structs where either of these may be present. [1]: ISO/IEC 9899:1999 §6.2.6.1, paragraph 6 [2]: ISO/IEC 9899:1999 §6.7.8, paragraph 9 See also: * https://wiki.sei.cmu.edu/confluence/display/c/EXP42-C.+Do+not+compare+padding+data * https://sourceware.org/git/?p=glibc.git;a=blob;f=time/bits/types/struct_timespec.h;hb=756c306502498f9
* | Merge branch 'dont-send-mouse-events-to-client-when-binding-consumed-it' into masterDaniel Eklöf2020-08-23-36/+62
|\ \ | |/ |/|
| * input: inhibit mouse events to client when a binding has consumed itDaniel Eklöf2020-08-22-36/+62
| | | | | | | | | | | | | | | | | | | | This introduces a new state to a seat's mouse struct, 'consumed'. It is set on a mouse *press* event that is claimed by a mouse binding. It is cleared after a mouse *release* event. While set, *no* mouse motion or button events are sent to the client application.
* | config: don't pass -1 to mbstowcs(), silences linker(?) warningDaniel Eklöf2020-08-22-2/+4
|/ | | | | | | | | | | | 'n' _is_ ignored when 'dest' is NULL, but you can still get the following warning: In function ‘mbstowcs’, inlined from ‘parse_section_scrollback’ at ../config.c:429:26: /usr/include/bits/stdlib.h:129:10: warning: ‘__mbstowcs_alias’ specified size 18446744073709551612 exceeds maximum object size 9223372036854775807 [-Wstringop-overflow=] 129 | return __mbstowcs_alias (__dst, __src, __len); To silence this warning, pass 0 instead, since it is ignored anyway.
* ci: sr.ht: run a codespell task at the endDaniel Eklöf2020-08-22-0/+5
|
* ci: gitlab: install pipDaniel Eklöf2020-08-22-0/+1
|
* ci: gitlab: the package is called 'python3', not 'python'Daniel Eklöf2020-08-22-1/+1
|
* ci: gitlab: pip install codespellDaniel Eklöf2020-08-22-1/+2
| | | | Alpine has no codespell package
* ci: gitlab: run codespell in the 'build' stageDaniel Eklöf2020-08-22-2/+1
| | | | This makes it run in parallel with the compilation steps
* ci: gitlab: run a codespell stage on all *.c and *.h filesDaniel Eklöf2020-08-22-0/+8
|
* Merge branch 'dont-emit-newlines-when-copying-empty-cells' into masterDaniel Eklöf2020-08-21-5/+13
|\ | | | | | | Closes #97
| * extract: only emit newlines if followed by non-empty cellsDaniel Eklöf2020-08-20-5/+13
|/ | | | Closes #97
* Merge branch 'no-async-unwind' into masterDaniel Eklöf2020-08-19-1/+3
|\
| * meson: use "-fno-asynchronous-unwind-tables" for non-debug buildsCraig Barnes2020-08-19-1/+3
|/ | | | | | | This removes the DWARF stack unwinding tables, which shrinks the ".eh_frame" and ".eh_frame_hdr" sections by about 24KiB. Stack unwinding tables are pretty useless to a C program compiled in release mode.
* Merge branch 'selection-exclude-trailing-empty-cells' into masterDaniel Eklöf2020-08-19-11/+56
|\
| * changelog: trailing empty cells are not highlighted in mouse selectionsDaniel Eklöf2020-08-18-0/+1
| |
| * selection: don't highlight trailing empty cells in a selectionDaniel Eklöf2020-08-18-11/+55
| | | | | | | | | | This makes it clear which cells contain spaces (that will be copied) or are empty (will *not* be copied).
* | Merge branch 'update-grid-on-default-fg-bg-change' into masterDaniel Eklöf2020-08-19-47/+65
|\ \ | | | | | | | | | Closes #94
| * | osc: dirty grids on *all* color modifying sequencesDaniel Eklöf2020-08-18-47/+65
| | | | | | | | | | | | | | | | | | | | | We only updated the grid for OSC 4 - Set color <idx>. But we did *not* do it for 104 (reset color <idx>), 10 - set default foreground, 11 - set default background, 110 - reset default foreground, or 111 - reset default background.
* | | Merge branch 'fallthrough' into masterDaniel Eklöf2020-08-19-2/+2
|\ \ \
| * | | csi: add 2 missing "break" statements in csi_dispatch()Craig Barnes2020-08-18-2/+2
|/ / /
* | | csi: xtrestore: add 'default' caseDaniel Eklöf2020-08-18-0/+2
| | | | | | | | | | | | | | | Don't call decset_decrst() with an unhandled parameter (and with 'enabled' uninitialized!)
* | | csi: xtrestore: add missing breakDaniel Eklöf2020-08-18-1/+1
| |/ |/|
* | Merge branch 'xtsave-xtrestore' into masterDaniel Eklöf2020-08-18-312/+341
|\ \ | |/ |/| | | Closes #91
| * csi: xtsave/xtrestore: implement \E[?12s and \E[?12rDaniel Eklöf2020-08-18-3/+19
| | | | | | | | I.e. save/restore cursor-blink state.
| * csi: decset/decrst: only clear mouse tracking/reporting if mode matchesDaniel Eklöf2020-08-18-9/+24
| | | | | | | | | | | | | | | | E.g. only set mouse reporting to NONE, if mouse reporting mode is SGR and an DECRST SGR is issued. Do *not* reset the mouse mode if e.g. mouse reporting mode is SGR and an DECRST URXVT is issued.
| * changelog: xtsave/xtrestoreDaniel Eklöf2020-08-16-0/+2
| |
| * csi: implement XTRESTOREDaniel Eklöf2020-08-16-16/+34
| |
| * term: xtsave: store state in a bitfieldDaniel Eklöf2020-08-16-20/+20
| | | | | | | | | | These shouldn't be accessed in any performance critical paths, so lets save some memory and use a bitfield.
| * csi: xtsave: store modes' SET state, not the current stateDaniel Eklöf2020-08-16-22/+25
| |
| * csi: implement CSI ? Pm s - XTSAVEDaniel Eklöf2020-08-16-16/+2
| |
| * csi: add xtsave()Daniel Eklöf2020-08-16-6/+58
| | | | | | | | This function stores the current state of DECSET private modes.
| * csi: decrst: spell decset correctlyDaniel Eklöf2020-08-16-1/+1
| |
| * csi: add DEC names to a couple of DECSET modesDaniel Eklöf2020-08-16-1/+6
| |
| * csi: break out decset/decrstDaniel Eklöf2020-08-16-274/+206
|/
* Merge branch 'spelling-fix' into masterDaniel Eklöf2020-08-16-1/+1
|\
| * Fix spelling mistake in vt.cCraig Barnes2020-08-16-1/+1
|/
* changelog: add ordoviz to contributorsDaniel Eklöf2020-08-16-0/+1
|
* Merge branch 'typos' into masterDaniel Eklöf2020-08-16-6/+6
|\
| * Fix typosLennard Hofmann2020-08-15-6/+6
|/
* Merge branch 'spelling-fixes' into masterDaniel Eklöf2020-08-15-12/+12
|\
| * Fix some spelling mistakesCraig Barnes2020-08-15-12/+12
| |
* | Merge branch 'typo' into masterDaniel Eklöf2020-08-15-1/+1
|\ \ | |/ |/|
| * Fix typoBirger Schacht2020-08-15-1/+1
|/
* readme: ctrl+shift+n: add link to wikiDaniel Eklöf2020-08-15-3/+4
|
* changelog: remove duplicate entries (caused by bad merge)Daniel Eklöf2020-08-14-4/+0
|
* render: render the render timer *before* committing the main surfaceDaniel Eklöf2020-08-14-17/+17
|
* render: render-timer: position sub-surface similar to the scrollback indicatorDaniel Eklöf2020-08-14-1/+5
|
* Merge branch 'mouse-binding-actions' into masterDaniel Eklöf2020-08-14-53/+160
|\ | | | | | | Closes #79. Closes #75.
| * input: mouse motion: don't update selection while scrollback searchingDaniel Eklöf2020-08-14-2/+4
| | | | | | | | | | When we are doing a scrollback search, the selection *is* ongoing. We still don't want to update the selection when the mouse moves.
| * input: bindings: calculate 'cursor_is_on_grid' once onlyDaniel Eklöf2020-08-14-18/+8
| |
| * footrc: fix combo for select-begin-blockDaniel Eklöf2020-08-14-1/+1
| | | | | | | | Typo: should be a '+', not a '='.
| * input: mouse-bindings: ignore ShiftDaniel Eklöf2020-08-14-3/+9
| | | | | | | | | | | | | | | | Shift is used to enable selection when the client application is grabbing the mouse. As such, mouse bindings *never* have Shift as a modifier, but should still trigger when Shift is being pressed.
| * config: don't allow Shift in mouse bindingsDaniel Eklöf2020-08-14-0/+9
| | | | | | | | | | Shift is a special modifier that is used to enable selection when the client application is grabbing the mouse.
| * input: mouse-bindings: check selection is enabled/possible and that pointer is on gridDaniel Eklöf2020-08-14-13/+33
| | | | | | | | | | | | | | | | | | | | We shouldn't start or modify a selection if selection isn't possible (i.e. client application is grabbing the mouse, and user isn't holding Shift). We also shouldn't start or modify a selection if the pointer is outside the grid (updating an ongoing selection on motion events is an exception to this).
| * doc: footrc: mouse-bindings: clean up descriptionDaniel Eklöf2020-08-14-14/+10
| |
| * changelog: new mouse actionsDaniel Eklöf2020-08-14-0/+6
| |
| * config: mouse bindings: add select-begin-block and select-rowDaniel Eklöf2020-08-14-19/+40
| |
| * selection: extend: set ongoing to trueDaniel Eklöf2020-08-14-0/+2
| |
| * selection: finalize: clear ongoing selectionDaniel Eklöf2020-08-14-3/+3
| | | | | | | | | | | | | | | | | | | | Check for ongoing selection, and *clear* it before bailing out due to the selection not having an end-point. This fixes an issue where a selection was kept as ongoing, even though the button had been released. Typically triggered by clicking without moving the mouse; this started a new selection, then (tried to) finalize it, but failed since the selection didn't have an end-point.
| * selection: update: don't update if there's no ongoing selectionDaniel Eklöf2020-08-14-0/+3
| |
| * doc: footrc: document the new mouse actionsDaniel Eklöf2020-08-14-0/+18
| |
| * config: add mouse specific bind actionsDaniel Eklöf2020-08-14-38/+68
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This extends the "normal" bind action enum with mouse specific actions. When parsing key bindings, we only check up to the last valid keyboard binding, while mouse bindings support *both* key actions and mouse actions. The new actions are: * select-begin: starts an interactive selection * select-extend: interactively extend an existing selection * select-word: select word under cursor * select-word-whitespace: select word under cursor, where the only word separating characters are whitespace characters. The old hard-coded selection "bindings" have been converted to instead use these actions, via default bindings added to the configuration.
| * changelog: click count in mouse bindingsDaniel Eklöf2020-08-14-0/+2
| |
| * changelog: modifier support in mouse bindingsDaniel Eklöf2020-08-14-0/+2
|/
* Merge branch 'click-count-in-mouse-bindings' into masterDaniel Eklöf2020-08-14-32/+65
|\ | | | | | | Closes #78
| * changelog: click count in mouse bindingsDaniel Eklöf2020-08-14-0/+2
| |
| * doc: footrc: document click count in mouse bindingsDaniel Eklöf2020-08-14-3/+12
| |
| * config: mouse bindings: add support for click countDaniel Eklöf2020-08-14-2/+26
| | | | | | | | Specified by appending "-X", where X is a number.
| * config: wrap LOG_AND_NOTIFY_*() in do {} while (0)Daniel Eklöf2020-08-14-27/+25
|/ | | | This allows us to use these macros in if-statement without braces.
* Merge branch 'modifiers-in-mouse-bindings' into masterDaniel Eklöf2020-08-14-318/+589
|\