aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeLines
...
* fdm: verify FDs are non-blocking (debug builds only)Daniel Eklöf2020-01-10-0/+10
|
* fcft: bumpDaniel Eklöf2020-01-09-0/+0
|
* completions: zsh: add empty completions for options with required argumentDaniel Eklöf2020-01-09-1/+1
|
* selection: finalize: ignore whether selections are 'enabled' or notDaniel Eklöf2020-01-06-3/+0
| | | | | | This fixes an issue where a "forced" selection (shift being pressed while slave is tracking mouse events) would not finalize if the user released shift *before* releasing the mouse button.
* selection: update: don't dirty cells that don't change stateDaniel Eklöf2020-01-06-21/+50
| | | | | | | | | | | | | | | | Previously when updating a selection, we would unmark *all* cells in the old selection, and then mark all cells in the new selection. This caused *all* cells to be dirtied and thus re-rendered. Avoid this, by adding a temporary state to the cells' selected state. Before unmarking the old selection, pre-mark the new selection using a temporary state. When unmarking the old selection, ignore cells in this temporary state. When marking the new selection, ignore cells in this temporary state (except clearing the temporary state).
* selection: foreach_selection_*: must wrap row numberDaniel Eklöf2020-01-05-2/+6
| | | | | Fixes occasional crashes when we're at the end of the grid and selection wraps around.
* search: rename render.search_offset -> render.search_glyph_offsetDaniel Eklöf2020-01-05-8/+8
|
* Merge branch 'search-render-improvements'Daniel Eklöf2020-01-05-6/+29
|\
| * render: ensure cursor is always visible in the search boxDaniel Eklöf2020-01-05-6/+29
|/ | | | | | | | | | | | | | | | | | Maintain a view 'offset' (which glyph from the search string to start rendering at). This defines the start of the viewable area. The end is the offset + the search box size (which is limited to the window size). Adjust this offset whenever the cursor moves outside the viewable area. For now, this is always done in the same way: set the offset to the cursor position. This means that when we're entering text at the end of the search criteria (i.e. the normal case; we're simply typing), and the search box reaches the window size, the cursor will jump to the start of the search box, which will be empty. This could be confusing, but let's go with for now.
* README: add 'git submodule update --init' step to how-to-installDaniel Eklöf2020-01-05-1/+8
|
* render: xcursor: remove render_xcursor_refresh()Daniel Eklöf2020-01-04-18/+17
|
* doc: slight change of wording for mouse-drag-to-selectDaniel Eklöf2020-01-04-5/+5
|
* README: abuse of definition list to get multiple paragraphsDaniel Eklöf2020-01-04-5/+5
|
* README: let's see if codeberg understands these paragraphs belong togetherDaniel Eklöf2020-01-04-1/+1
|
* renderer: destroy: actually free the renderer instance (doh!)Daniel Eklöf2020-01-04-0/+2
|
* wayland: wayl_flush: re-initialize fd array before each pollDaniel Eklöf2020-01-04-5/+13
|
* wayland: add commentDaniel Eklöf2020-01-04-0/+4
|
* wayland: only call wl_display_prepare_read() if we read any eventsDaniel Eklöf2020-01-04-3/+4
| | | | | | That is, only call it if we have POLLIN. If not, then we never read any events and we still hold the read lock and thus we shouldn't try to acquire it again.
* wayland: use a low priority FDM hook to flush the wayland socketDaniel Eklöf2020-01-04-3/+14
| | | | | | | | This way, we don't have to manually insert flushes in code paths that may execute outside of a wl_display_dispatch_pending(). (Those that execute inside a wl_display_dispatch_pending() are subject to the flush performed at the end of the normal wayland FDM handler).
* fdm: add hook prioritiesDaniel Eklöf2020-01-04-17/+69
| | | | | | | | | | There are now three hook priorities: low, normal, high. High priority hooks are executed *first*. Normal next, and last the low priority hooks. The renderer's terminal refresh hook now runs as a normal priority hook.
* render: throttle xcursor updatesDaniel Eklöf2020-01-04-76/+136
| | | | | | | | | | | | | | | | | | | | | | | With a bad behaving client (e.g. 'less' with mouse support enabled), we can end up with a *lot* of xcursor updates (so much, that we flooded the wayland socket before we implemented a blocking wayl_flush()). Since there's little point in updating the cursor more than once per frame interval, use frame callbacks to throttle the updates. This works more or lesslike normal terminal refreshes: render_xcursor_set() stores the last terminal (window) that had (and updated) the cursor. The renderer's FDM hook checks if we have such a pending terminal set, and if so, tries to refresh the cursor. This is done by first checking if we're already waiting for a callback from a previous cursor update, and if so we do nothing; the callback will update the cursor for the next frame. If we're *not* already waiting for a callback, we update the cursor immediately.
* input: scroll: call term_mouse_up() once, after all term_mouse_down()Daniel Eklöf2020-01-04-0/+1
| | | | | Note that scroll button release events are not actually sent to the client, but this makes the code more correct, logically.
* wayland: wl_display_flush() never blocksDaniel Eklöf2020-01-04-4/+46
| | | | | | | | | | | | | | | | | | | Since it doesn't block, we need to detect EAGAIN failures and ensure we actually flush everything. If we don't, we sooner or later end up in a wayland client library call that aborts due to the socket buffer being full. Ideally, we'd simply enable POLLOUT in the FDM. However, we cannot write *anything* to the wayland socket until we've actually managed to send everything. This means enabling POLLOUT in the FDM wont work since we may (*will*) end up trying to write more data to it before we've flushed it. So, add a wrapper function, wayl_flush(), that acts as a blocking variant of wl_display_flush(), by detecting EAGAIN failiures and calling poll() itself, on the wayland socket only, until all data has been sent.
* render: remove debug loggingDaniel Eklöf2020-01-04-5/+2
|
* Merge branch 'render-refresh-optimize'Daniel Eklöf2020-01-04-11/+125
|\
| * term: more comments in the 'render' sub-structDaniel Eklöf2020-01-04-3/+4
| |
| * render: attrs_to_font() is not used outside of render.cDaniel Eklöf2020-01-04-1/+1
| |
| * render: trigger terminal refreshes in an FDM hookDaniel Eklöf2020-01-04-8/+68
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In some cases, we end up calling render_refresh() multiple times in the same FDM iteration. This means will render the first update immediately, and then set the 'pending' flag, causing the updated content to be rendered in the next frame. This can cause flicker, or flashes, since we're presenting one or more intermediate frames until the final content is shown. Not to mention that it is inefficient to render multiple frames like this. Fix by: * render_refresh() only sets a flag in the terminal * install an FDM hook; this hook loops all terminals and executes what render_refresh() _used_ to do (that is, render immediately if we're not waiting for a frame callback, otherwise set 'pending' flag). for all terminals that have the 'refresh_needed' flag set.
| * fdm: add support for hooksDaniel Eklöf2020-01-04-0/+53
|/ | | | | Hooks are functions executed just before going into a poll(). Or just after executing all FD handlers, if you like.
* doc: document how to do block selectionsDaniel Eklöf2020-01-04-0/+2
|
* doc: add descriptions for ctrl+w and ctrl+shift+w in scrollback searchDaniel Eklöf2020-01-04-0/+9
|
* doc: add headers to keyboard shortcuts for normal+scrollback searchDaniel Eklöf2020-01-04-2/+3
|
* README: mention that ctrl+mouse creates a block selectionDaniel Eklöf2020-01-04-0/+2
|
* PKGBUILD: remove old *.gcda filesDaniel Eklöf2020-01-04-1/+2
|
* Merge branch 'block-selection'Daniel Eklöf2020-01-04-127/+267
|\
| * selection: min_bufsize_for_extraction: add one extra column for *all* rowsDaniel Eklöf2020-01-04-7/+4
| |
| * selection: rename selection_cell_count -> min_bufsize_for_extractionDaniel Eklöf2020-01-04-2/+2
| |
| * selection: cell count now adds one extra column per row, for \nDaniel Eklöf2020-01-04-3/+11
| | | | | | | | | | | | | | | | When we extract text, we may insert '\n' at the end of each line (or last column of selection, for block selections). These newlines doesn't occupy any physical cells, and thus we must **make** room for them in the extraction buffer.
| * selection: fix bug where first column on all rows but the first was lostDaniel Eklöf2020-01-04-10/+12
| | | | | | | | | | | | | | | | | | | | When extracting text from the selection, we lost the first column on all rows but the first. This is because the algorithm changed slightly when we moved to foreach_selection(); the end-of-line detection is now done on the first column of the new line, instead of the last column on the previous line.
| * selection: simplify extraction by converting to UTF-8 at the endDaniel Eklöf2020-01-04-21/+25
| | | | | | | | | | Instead of converting a cell at a time to UTF-8, copy the wide characters as is, and then convert everything at once at the end.
| * selection: extract_selection now uses foreach_selected()Daniel Eklöf2020-01-04-57/+105
| | | | | | | | | | This "automagically" adds support for block selections, since foreach_selected already handles block selections.
| * term: mouse_grabbed: ctrl may be pressed too (for block selection)Daniel Eklöf2020-01-04-1/+1
| |
| * selection: selection_cancel() now sets 'kind' to SELECTION_NONEDaniel Eklöf2020-01-04-1/+6
| |
| * selection: store cell 'selected' state in the cells' attributesDaniel Eklöf2020-01-04-78/+129
| | | | | | | | | | | | | | | | | | Instead of having the renderer calculate, for each cell, whether that cell is currently selected or not, make selection_update() mark/unmark the selected cells. The renderer now only has to look at the cells' 'selected' attribute. This makes the renderer both smaller and faster.
| * render: coord_is_selected: handle block selectionsDaniel Eklöf2020-01-03-8/+22
| |
| * selection: track selection type; normal or block selectionDaniel Eklöf2020-01-03-7/+18
|/
* wayland: window: optimize: set opaque regionDaniel Eklöf2020-01-03-0/+11
| | | | | | | When background alpha is 1.0 (0xffff), i.e. completely opaque, tell the compositor this, via wl_surface_set_opaque_region(). This allows it to optimize drawing of surfaces _behind_ our window.
* term: background alpha is not a floating point numberDaniel Eklöf2020-01-03-1/+1
|
* wayland: don't use wl_display_dispatch()Daniel Eklöf2020-01-03-8/+30
| | | | | | | | | | | | | | | | | | | | | | wl_display_dispatch() calls poll(), which is unnecessary since we already know the FD is readable. Use the more lower level wl_display_read_events() + wl_display_dispatch_pending(). These require wl_display_prepare_read() to have been called. The idea is to call wl_display_prepare_read() **before** calling poll(). Thus, we do this more or less last in wayl_init(), and at the **end** of the FDM handler. However, having taking this lock also means we no longer can call wl_display_roundtrip() directly (it will hang). So, add a wrapper, wayl_roundtrip(), that cancels the read intent, does the roundtrip, and then re-acquires the read intent.
* selection: remove unneeded wayland display roundtripsDaniel Eklöf2020-01-03-2/+0
|
* term: init: don't resize if compositor has already resized usDaniel Eklöf2020-01-03-13/+16
|
* term: no need to call render_refresh() when starting/stopping blink timerDaniel Eklöf2020-01-03-2/+1
|
* wayland: flush after commit new pointer surfaceDaniel Eklöf2020-01-03-0/+1
|
* wayland: configure: resize before changing visual focusDaniel Eklöf2020-01-03-2/+2
| | | | | | | | | | | | | | This hopefully fixes and issue where the visual focus in/out caused a render refresh with the *old* size. This caused the occasional flicker at startup, or when resizing the window. By placing the resize call before the visual focus in/out, we ensure the refresh uses the new size. This is a temporary workaround. The correct solution is to ensure we only call refresh() once.
* render: refresh: ensure window has been configuredDaniel Eklöf2020-01-03-0/+5
|
* Merge branch 'cleanup-wayland-window-callbacks'Daniel Eklöf2020-01-03-84/+59
|\
| * render: remove 'refresh' from render_resize()Daniel Eklöf2020-01-03-9/+8
| |
| * wayland: window: apply all configure changes after acking the eventDaniel Eklöf2020-01-03-22/+25
| |
| * wayland: remove wayl_terminal_from_xdg_{surface,toplevel}Daniel Eklöf2020-01-03-30/+0
| |
| * wayland: window: pass window pointer to xdg toplevel callbacksDaniel Eklöf2020-01-03-6/+6
| |
| * wayland: window: pass window pointer to xdg-surface-listener callbacksDaniel Eklöf2020-01-03-3/+4
| |
| * wayland: window: pass window pointer to wl-surface callbacksDaniel Eklöf2020-01-03-8/+8
| |
| * wayland: window now keeps pointer to owning terminal, not waylandDaniel Eklöf2020-01-03-8/+10
|/
* render: render_resize(): don't do anything if width or height is 0Daniel Eklöf2020-01-03-2/+4
|
* wayland: fix release buildDaniel Eklöf2020-01-03-2/+4
|
* Merge branch 'visual-focus'Daniel Eklöf2020-01-03-67/+173
|\
| * wayland: debug log state changes in xdg-toplevel-configureDaniel Eklöf2020-01-03-3/+45
| |
| * wayland: xdg-surface-configure: refresh terminalDaniel Eklöf2020-01-03-1/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Any changes done in any of the configure events are ignored before we've ack:ed the configure event. In particular, this means the resize done in xdg-toplevel-configure isn't displayed until the next time we call render_refresh(). Unless we do something ourselves, this can take quite some time, since we're basically need the slave to write something. So, in xdg-surface-configure, *after* having ack:ed the configure event, call render_refresh() to make the changes done in xdg-toplevel-configure visible as soon as possible.
| * term: render_resize() now takes a 'refresh' argumentDaniel Eklöf2020-01-03-1/+1
| |
| * wayland: render_resize() now takes a 'refresh' argumentDaniel Eklöf2020-01-03-4/+8
| |
| * render: resize() now only calls refresh() if asked toDaniel Eklöf2020-01-03-3/+4
| |
| * Merge branch 'master' into visual-focusDaniel Eklöf2020-01-03-1/+1
| |\ | |/ |/|
* | render: use a unique buffer cookie for the 'search' surfaceDaniel Eklöf2020-01-03-1/+1
| | | | | | | | | | | | | | | | This fixes an issue where rendering the 'search' box caused the last normal buffer from being purged. This meant the terminal had a pointer to a now freed buffer, which we de-referenced and occasionally memcpy:ied from.
| * wayland: term_visual_focus_{in,out} handles already being focused/defocusedDaniel Eklöf2020-01-03-2/+2
| |
| * term: visual_focus_{in,out}: do nothing if already focused/defocusedDaniel Eklöf2020-01-03-0/+6
| |
| * wayland: xdg-toplevel-configure: no need to detect early configure eventsDaniel Eklöf2020-01-03-7/+2
| | | | | | | | | | | | | | | | We can now lookup terminal instances at all times, making it unnecessary to detect "early" configure events. Note that we still need to prevent a resize from happening when width/height is 0.
| * term: term_init() calls wl_display_roundtrip()Daniel Eklöf2020-01-03-3/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | Instead of having `wayl_win_init()` call `wl_display_roundtrip()` (which it itself doesn't need), call it from `term_init()`. This allows us to add ourselves (the new terminal instance) to the terminal list in the wayland backend, before triggering the wayland events caused by `wayl_win_init()`. This is turn allows the wayland backend to find/lookup the new terminal when those events occur..
| * term: spell 'initialize' correctlyDaniel Eklöf2020-01-03-1/+1
| |
| * render: draw_cursor: use terminal's visual focus to determine cursor shapeDaniel Eklöf2020-01-02-5/+3
| |
| * wayland: xdg-top-level-configure: call term_visual_focus_{in,out}Daniel Eklöf2020-01-02-1/+5
| |
| * term: add term_visual_focus_{in,out}Daniel Eklöf2020-01-02-8/+19
| | | | | | | | | | | | | | These functions should be called when the terminal gets or loses visual focus. Note that this isn't necessarily the same as having keyboard focus.
| * input: keyboard-leave: move comment to where it belongsDaniel Eklöf2020-01-02-3/+3
| |
| * term: rename term_focus_{in,out} -> term_kbd_focus_{in,out}Daniel Eklöf2020-01-02-6/+6
| |
| * Merge branch 'master' into visual-focusDaniel Eklöf2020-01-02-0/+0
| |\ | |/ |/|
* | fcft: ignore `embeddedbitmap` for non-scalable fontsDaniel Eklöf2020-01-02-0/+0
| |
| * wayland: xdg-toplevel-configure: check for stateless configure callsDaniel Eklöf2020-01-02-8/+11
| | | | | | | | | | Ignore configure calls without state, instead of checking for width/height == 0.
| * wayland: ignore early configure callsDaniel Eklöf2020-01-02-3/+4
| | | | | | | | | | At this point, not everything has been setup and we crash when trying to convert the surface pointer to a terminal pointer.
| * term: add visually focused attribute to terminal structDaniel Eklöf2020-01-02-4/+14
| |
| * wayland: rename focused/moused to kbd_focus/mouse_focusDaniel Eklöf2020-01-02-34/+34
|/
* README: add missing '+' in keyboard shortcut ctrl+shift+wDaniel Eklöf2020-01-01-1/+1
|
* wayland: warn when presentation timings have been requested but is not supportedDaniel Eklöf2020-01-01-0/+4
|
* Merge branch 'readme-pimping'Daniel Eklöf2020-01-01-55/+48
|\
| * README: use footnoteDaniel Eklöf2020-01-01-2/+5
| |
| * README: add keyboard::normal-mode and keyboard::scrollback-search to indexDaniel Eklöf2020-01-01-0/+2
| |
| * README: use headings to separate normal key bindings from scrollback search bindingsDaniel Eklöf2020-01-01-3/+3
| |
| * Revert "README: try removing empty lines between list items"Daniel Eklöf2020-01-01-0/+4
| | | | | | | | This reverts commit 7e39d113b7471b67a50db2cfb22923898b6850f4.
| * Revert "README: that didn't work - try with a hard line break"Daniel Eklöf2020-01-01-2/+2
| | | | | | | | This reverts commit 7489cae576edbfbf1f0b6db36a3c657c0260f91c.
| * README: that didn't work - try with a hard line breakDaniel Eklöf2020-01-01-2/+2
| |
| * README: try removing empty lines between list itemsDaniel Eklöf2020-01-01-4/+0
| |
| * README: list items should be indented by **4** spacesDaniel Eklöf2020-01-01-8/+9
| |