aboutsummaryrefslogtreecommitdiff
path: root/config.c (follow)
Commit message (Collapse)AuthorAgeLines
...
* themes: starlight: update to V4Daniel Eklöf2023-07-18-12/+12
| | | | | | | This also updates the default theme in foot, as well as the documentation. Closes #1409
* config: add csd.double-click-to-maximize=no|yes optionDaniel Eklöf2023-07-14-0/+4
| | | | | | | | | When enabled, double-clicking the CSD titlebar will (un)maximize the window. Defaults to ‘yes’ (since this is the old hard-coded behavior). Closes #1293
* config: make ‘starlight’ the default color themeDaniel Eklöf2023-07-14-17/+17
| | | | Closes #1321
* bind control-shift-u to unicode-input, move urls to oAntoine Beaupré2023-07-10-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Having a keybinding to invoke arbitrary unicode characters is very useful. It's often used as a method of last resort to communicate with people outside of your main language. For example, if you want to type the last letter of my real name, you can invoke the latin-1 character 0xe9 or unicode 0x00e9. You can also use this to type special characters, for example, unicode U+1F4A9 is of course, the infamous PILE OF POO, which is sure to produce million laughs everywhere you go. In foot, there's no keybinding by default to invoke the very useful unicode-input command. There is no "standard" (as in "ISO") keybinding this either. But there *is* a de-facto standard currently deployed by *both* GTK and Qt (a rare feat) *and* Chrome OS (an even rarer feat) and it's control-shift-u. Alternatives include Control-x 8 (emacs), Control V u (vim), Alt (Windows, LibreOffice), or Option (Mac). I doubt we want to adopt any of those. So let's use control-shift-u for this. Unfortunately, it's currently assigned to show-urls-launch, which is unfortunate, but insurmountable. We can reassign this keybinding elsewhere. I have picked control-shift-o in my configuration, because "o" is a good mnemonic for "open URLs". Others have suggested "m" instead. Closes: #1183
* input: add basic support for touchscreen inputCismonX2023-07-05-0/+20
| | | | Closes #517
* config: dpi-aware: remove ‘auto’ value, and default to ‘no’Daniel Eklöf2023-06-29-12/+3
| | | | | | | | | | We now default to scaling fonts using the scaling factor, not monitor DPI. The ‘auto’ value for dpi-aware has been removed. Documentation (man pages and README) have been updated to reflect the new default.
* config: unittest: explicitly call fcft_init() + fcft_fini()Daniel Eklöf2023-06-26-0/+4
| | | | | This plugs a memory leak, caused by fontconfig functions being called as part of the unit test implicitly allocating global objects.
* .desktop: remove StartupWMClass from server, use distinct StartupWMClass for foot and footclientjdevdevdev2023-05-22-3/+4
| | | | | | | | | | | | | | | For this to work, the default app-id of footclient has been changed from ‘foot’ to ‘footclient’. By using distinct StartupWMClasses, the compositor can connect a running foot/footclient instance to the correct .desktop-file. This ensures the correct icon is being used in e.g. docks, and that actions like “open another window” works correctly. Note that the user can override the app-id, either by setting app-id in foot.ini, or with the -a,--app-id command line option. Closes #1355
* utmp: rewrite utmp loggingDaniel Eklöf2023-05-22-11/+30
| | | | | | | | | | | | | | | | | | | | | | | This patch generalizes the utmp support, to not only support libutempter, but also ulog (and in the future, even more interfaces). * Rename config option main.utempter to main.utmp-helper * Add meson option -Dutmp-backend=none|libutempter|ulog|auto * Rename meson option -Ddefault-utempter-path to -Dutmp-default-helper-path * utmp is no longer detected at compile time, but at runtime instead. Meson will configure the following pre-processor macros, based on the selected utmp backend: * UTMP_ADD - argument to pass to utmp helper when adding a record (starting foot) * UTMP_DEL - argument to pass to utmp helper when removing a record (exiting foot) * UTMP_DEL_HAVE_ARGUMENT - if defined, UTMP_DEL expects an extra argument ($WAYLAND_DISPLAY) * UTMP_DEFAULT_HELPER_PATH - path to the default utmp helper binary The documentation has been updated to mention which arguments are passed to the helper binary. Closes #1314
* config: apply fontconfig rules if user didn’t set an explicit font sizeDaniel Eklöf2023-03-06-6/+34
| | | | | | | | | | | | | | | | | | | | | | | If the user didn’t explicitly set the font size (e.g. font=monospace, instead of font=monospace:size=12), our initial attempt to read the FC_SIZE and FC_PIXEL_SIZE attributes will fail, and we used to fallback to setting the size to 8pt. Change this slightly, so that when we fail to read the FC_*_SIZE attributes, apply the fontconfig rules, but *without expanding* them (i.e. without calling FcDefaultSubstitute()). Then try reading FC_*_SIZE again. If that too fails, _then_ set size to 8pt. This allows us to pick up rules that set a default {pixel}size: <fontconfig> <match> <edit name="pixelsize" mode="append"><double>14</double></edit> </fontconfig> Closes #1287
* config: don’t double-free key binding auxiliary dataDaniel Eklöf2023-01-15-0/+3
| | | | | | | | | | | | | | | | Key bindings with multiple key mappings share auxiliary data (e.g. the command to execute in pipe-* bindings, or the escape sequence in text-bindings). The first one is the designated “master” copy. Only that one should be freed. This fixed a double-free on exit, with e.g. [text-bindings] \x1b\x23=Mod4+space Mod4+equal Closes #1259
* config: change default grapheme-width-method from wcswidth to double-widthDaniel Eklöf2023-01-01-1/+1
| | | | | | | | | | | | | | | | | | The old default, wcswidth, simply calls wcswidth() on the grapheme cluster. This was supposedly the implementation with the highest application compatibility. Except we never even tried to measure it. It was just assumed. A lot of modern applications have better implementations. Let’s try to push support for better emoji support by changing our default method from wcswith to double-width. While far from correct (it’s not based on the Unicode tables), the ‘double-width’ method produces accurate results anyway. double-width is like wcswidth(), in that it adds together the individual wcwidths of all codepoints in the grapheme cluster. But, it limits the maximum width to 2.
* config: font-size-adjustment: don’t allow empty %-values (key=%)Daniel Eklöf2022-12-17-1/+1
|
* config: value_to_pt_or_px(): don’t allow empty px values (key=px)Daniel Eklöf2022-12-17-1/+1
|
* config: add ‘font-size-adjustment=N[px|%]’ optionDaniel Eklöf2022-12-17-0/+26
| | | | | | | | | | | This patch adds a new config option, font-size-adjustment. It lets you configure how much the font size should be incremented/decremented when zooming in or out (ctrl-+, ctrl+-). Values can be specified in points, pixels or percent. Closes #1188
* slave: unsetenv() env vars that have been set to the empty stringDaniel Eklöf2022-12-06-11/+12
| | | | | | | | | | | That is, users can now *clear* environment variables by doing: [environment] VAR=”” Note that the quotes are required. Closes #1225
* config: allow string values to be quotedDaniel Eklöf2022-12-06-1/+41
| | | | | | | | | | | * Both double and single quotes are recognized. There’s no difference in how they are handled. * The entire string must be quoted: - “a quoted string” - OK - quotes “in the middle” of a string - NOT ok * Two escape characters are regonized: - Backslash - The quote character itself
* Add support for creating utmp recordsDaniel Eklöf2022-09-23-0/+19
| | | | | | | | | | | | | | | | | This patch adds support for creating utmp records using the ‘utempter’ helper binary from the ‘libutempter’ package. * New config option ‘main.utempter’ * New meson command line option, -Ddefault-utempter-path. Defaults to auto-detecting the path. The default value of the new ‘main.utempter’ config option depends on the meson command line option ‘-Ddefault-utempter-path’. If ‘main.utempter’ is *not* set to ‘none’, foot will try to execute the utempter helper binary to create utmp records when a new terminal is instantiated. The record is removed when the terminal instance is destroyed.
* config: fix "maybe-uninitialized" error when compiling with CFLAGS=-OgCraig Barnes2022-09-17-0/+3
| | | | | | | | | | | | | | | Using GCC 12.2.0 with the following build steps: CFLAGS=-Og meson bld ninja -C bld ...produces the compiler error: ../config.c:2000:18: error: ‘sym_equal’ may be used uninitialized [-Werror=maybe-uninitialized] This commit fixes that by using BUG() to assert that all possible values are accounted for in the offending switch statement.
* config: change default ‘pad’ to 0x0 (i.e. no padding)Daniel Eklöf2022-09-03-2/+2
|
* theme: change default color theme to solarized-dark-normal-brightsDaniel Eklöf2022-08-22-17/+17
| | | | | | | | | This is my variant of the solarized theme, were only the first eight colors (i.e. the "normal") colors are from the solarized theme. The remaining eight (the "bright" colors) are brightened versions of the "normal" colors. This results in a theme that is usually in all applications, not just those that are "aware" that the terminal color theme is "solarized".
* config: add setting for underline thicknessYorick Peterse2022-08-20-0/+4
| | | | | | | | This adds an "underline-thickness" setting to the "main" section, similar to the existing "underline-offset" setting. This setting is used to specify a custom height for regular (= non-cursor) underlines. Fixes #1136
* config: reset errno before calling getline() againDaniel Eklöf2022-07-29-0/+3
| | | | Related to #1107
* input: add new Unicode input modeDaniel Eklöf2022-07-29-0/+2
| | | | | | | | | | | | | | This mode is activated through the new key-bindings.unicode-input and search-bindings.unicode-input key bindings. When active, the user can “build” a Unicode codepoint by typing its hexadecimal value. Note that there’s no visual feedback in this mode. This is intentional. This mode is intended to be a fallback for users that don’t use an IME. Closes #1116
* config: add colors.search-box-{no-,}matchDaniel Eklöf2022-07-28-0/+28
| | | | Closes #1112
* osc: add support for OSC 133;A (prompt markers)Daniel Eklöf2022-06-16-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch adds support for the OSC-133;A sequence, introduced by FinalTerm and implemented by iTerm2, Kitty and more. See https://iterm2.com/documentation-one-page.html#documentation-escape-codes.html. The shell emits the OSC just before printing the prompt. This lets the terminal know where, in the scrollback, there are prompts. We implement this using a simple boolean in the row struct ("this row has a prompt"). The prompt marker must be reflowed along with the text on window resizes. In an ideal world, erasing, or overwriting the cell where the OSC was emitted, would remove the prompt mark. Since we don't store this information in the cell struct, we can't do that. The best we can do is reset it in erase_line(). This works well enough in the "normal" screen, when used with a "normal" shell. It doesn't really work in fullscreen apps, on the alt screen. But that doesn't matter since we don't support jumping between prompts on the alt screen anyway. To be able to jump between prompts, two new key bindings have been added: prompt-prev and prompt-next, bound to ctrl+shift+z and ctrl+shift+x respectively. prompt-prev will jump to the previous, not currently visible, prompt, by moving the viewport, ensuring the prompt is at the top of the screen. prompt-next jumps to the next prompt, visible or not. Again, by moving the viewport to ensure the prompt is at the top of the screen. If we're at the bottom of the scrollback, the viewport is instead moved as far down as possible. Closes #30
* config: add a new ‘environment’ sectionDaniel Eklöf2022-06-13-0/+40
| | | | | | | | This section allows the user to define custom environment variables to be set in the child process: [environment] name=value
* config: use $HOME instead of getpwuid() to retrieve users’s home dirDaniel Eklöf2022-05-25-11/+2
| | | | | When searching for foot.ini, use $HOME instead of getpwuid() to retrieve the user’s home directory.
* config: add ctrl+shift+v and XF86 paste to SEARCH_CLIPBOARD_PASTEDaniel Eklöf2022-04-26-0/+2
| | | | | | | | | | | | | We now bind ctrl+v, ctrl+shift+v, ctrl+y and XF86Paste to pasting from the clipboard into the scrollback search buffer. Why all these? Because we can, and because all are common shortcuts for pasting: * ctrl+v: “normal” apps use this by default * ctrl+shift+v: used in terminals (including foot) * ctrl+y: Emacs * XF86Paste: special keyboard key, for pasting
* key-binding: new API, for handling sets of key bindingsDaniel Eklöf2022-04-17-1/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Up until now, our Wayland seats have been tracking key bindings. This makes sense, since the seat’s keymap determines how the key bindings are resolved. However, tying bindings to the seat/keymap alone isn’t enough, since we also depend on the current configuration (i.e. user settings) when resolving a key binding. This means configurations that doesn’t match the wayland object’s configuration, currently don’t resolve key bindings correctly. This applies to footclients where the user has overridden key bindings on the command line (e.g. --override key-bindings.foo=bar). Thus, to correctly resolve key bindings, each set of key bindings must be tied *both* to a seat/keymap, *and* a configuration. This patch introduces a key-binding manager, with an API to add/remove/lookup, and load/unload keymaps from sets of key bindings. In the API, sets are tied to a seat and terminal instance, since this makes the most sense (we need to instantiate, or incref a set whenever a new terminal instance is created). Internally, the set is tied to a seat and the terminal’s configuration. Sets are *added* when a new seat is added, and when a new terminal instance is created. Since there can only be one instance of each seat, sets are always removed when a seat is removed. Terminals on the other hand can re-use the same configuration (and typically do). Thus, sets ref-count the configuration. In other words, when instantiating a new terminal, we may not have to instantiate a new set of key bindings, but can often be incref:ed instead. Whenever the keymap changes on a seat, all key bindings sets associated with that seat reloads (re-resolves) their key bindings. Closes #931
* url-mode: add a key binding that enables “persistent” URL modeDaniel Eklöf2022-04-17-1/+2
| | | | | | | This is an alternative to ‘show-urls-launch’, where we stay in URL mode after activating an URL. Closes #964
* config: add [csd].hide-when-maximized=yes|noDaniel Eklöf2022-04-16-0/+4
| | | | | | | When enabled, the CSD titlebar will be hidden when the window is maximized. Closes #1019
* fix some small typosMerlin Büge2022-04-13-5/+5
|
* config: config_free(): pass conf struct by pointer, not by-valueDaniel Eklöf2022-04-12-26/+26
|
* config: simplify lookup of foot.iniDaniel Eklöf2022-04-12-144/+31
| | | | | | | | The old, complex, way of using a dynamic list to hold each path component made _some_ sense before, when we needed to support both ~/.config/foot.ini and ~/.config/foot/foot.ini. But now, it just over complicates things.
* config: use fallback when XDG_CONFIG_{HOME,DIRS} is set, but emptyDaniel Eklöf2022-04-07-2/+2
|
* config: fallback to /etc/xdg if XDG_CONFIG_DIRS is unsetDaniel Eklöf2022-04-07-2/+4
| | | | Closes #1008
* config: add tweak option to allow disabling sixelsjvoisin2022-04-06-0/+4
| | | | Closes #950
* config/input: add scrollback-home|end key bindings (unbound by default)Daniel Eklöf2022-02-23-0/+2
|
* config: do key binding collision handling in overridesDaniel Eklöf2022-02-16-18/+17
| | | | | This ensures we detect, and handle, collisions also for key-bindings specified as overrides.
* wip: map key combos to custom text strings (including escapes)Daniel Eklöf2022-02-16-3/+112
| | | | | | | | | | | | | With this, it is now possible to map key combos to custom escapes. The new bindings are defined in a new section, “text-bindings”, on the form “string=key combo”. The string can consist of printable characters, or \xNN style hex digits: [text-bindings] abcd = Control+a \x1b[A = Control+b Control+c Control+d # map ctrl+b/c/d to UP
* config: rename csd.color.close -> quitDaniel Eklöf2022-02-09-1/+1
| | | | | | | | | | | This fixes a compilation error on FreeBSD: ../../foot/render.c:2055:45: error: no member named 'epoll_shim_close' in 'struct config::(anonymous at ../../foot/config.h:254:9)' conf_color = &term->conf->csd.color.close; ~~~~~~~~~~~~~~~~~~~~~ ^ /usr/local/include/libepoll-shim/epoll-shim/detail/common.h:8:15: note: expanded from macro 'close': #define close epoll_shim_close
* config: ‘pipe’ is now optional ‘aux’ data in the key-binding structDaniel Eklöf2022-02-09-52/+74
| | | | | This allows us to add helper functions that e.g. compare bindings’ aux data in a generic way.
* config: rename enum config_key_binding_type -> key_binding_typeDaniel Eklöf2022-02-09-2/+2
|
* config: font->name may be NULLDaniel Eklöf2022-02-06-2/+6
| | | | | If it is, fallback to the font pattern instead, like we used to do before fcft-3.
* fcft: adapt to API changes in fcft-3.xDaniel Eklöf2022-02-05-43/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fcft no longer uses wchar_t, but plain uint32_t to represent codepoints. Since we do a fair amount of string operations in foot, it still makes sense to use something that actually _is_ a string (or character), rather than an array of uint32_t. For this reason, we switch out all wchar_t usage in foot to char32_t. We also verify, at compile-time, that char32_t used UTF-32 (which is what fcft expects). Unfortunately, there are no string functions for char32_t. To avoid having to re-implement all wcs*() functions, we add a small wrapper layer of c32*() functions. These wrapper functions take char32_t arguments, but then simply call the corresponding wcs*() function. For this to work, wcs*() must _also_ be UTF-32 compatible. We can check for the presence of the __STDC_ISO_10646__ macro. If set, wchar_t is at least 4 bytes and its internal representation is UTF-32. FreeBSD does *not* define this macro, because its internal wchar_t representation depends on the current locale. It _does_ use UTF-32 _if_ the current locale is UTF-8. Since foot enforces UTF-8, we simply need to check if __FreeBSD__ is defined. Other fcft API changes: * fcft_glyph_rasterize() -> fcft_codepoint_rasterize() * font.space_advance has been removed * ‘tags’ have been removed from fcft_grapheme_rasterize() * ‘fcft_log_init()’ removed * ‘fcft_init()’ and ‘fcft_fini()’ must be explicitly called
* config: s/of the form/on the form/Daniel Eklöf2022-02-05-1/+1
|
* config: use getline idiomaticallyPranjal Kole2022-02-05-66/+72
| | | | | | getline(3) contains an example program at the end, showing its usage. A few other changes have also been made.
* config: don't pass null strings to *printf()Pranjal Kole2022-02-05-18/+61
| | | | | | | | | | | | | musl and glibc's *printf() convert NULL strings to "(null)" [0][1], but this is undefined behaviour. context.value has to be set to two backspaces, so that the extra colon is removed. context.key is set to one backspace, so that the extra dot is removed. context.section is now set to "main" by default, so it is never NULL. [0]: https://git.musl-libc.org/cgit/musl/tree/src/stdio/vfprintf.c#n593 [1]: https://sourceware.org/git/?p=glibc.git;a=blob;f=stdio-common/vfprintf-internal.c;hb=HEAD#l1011
* config: support Copy and Paste keycodes by defaultMark Stosberg2022-01-25-0/+2
| | | | | | | | | | | | These work as expected and don't interfere with anything else. They are useful on the increasing number of keyboards with custom firmware. The keycodes enable using the same key combination for terminals as other apps. For example: by holding down a layer-switching key with a thumb, the Copy and Paste key codes can be assigned to the C and V keys on a secondary layer, making for a natural universal copy/paste key combination.
* config: convert tweak.render_timer to an enumDaniel Eklöf2022-01-13-15/+7
|
* Add irc:// to default URL schemesSimon Ser2021-12-27-0/+2
|
* config: update most parse_section_*() functions to return in each if-branchDaniel Eklöf2021-12-25-28/+20
|
* config: scrollback: add missing return for ‘lines’Daniel Eklöf2021-12-25-1/+1
| | | | The missing return meant failures were not reported correctly.
* config: csd.border_width now always reflects the full/total widthDaniel Eklöf2021-12-22-0/+6
|
* config: error out on empty key- or mouse bindingDaniel Eklöf2021-12-18-0/+6
| | | | Closes #851
* config: NOINLINE modifiers_to_str()Daniel Eklöf2021-12-11-1/+1
|
* config: resolve collisions: argv_compare() returns -1,0,+1, not a boolDaniel Eklöf2021-12-11-1/+4
|
* config: resolve collisions: return ‘false’ on failureDaniel Eklöf2021-12-11-0/+2
|
* config: use “(default)” as path in log message, if path is NULLDaniel Eklöf2021-12-11-1/+2
|
* config: remove unneeded function prototypeDaniel Eklöf2021-12-11-4/+0
|
* config: unify key- and mouse bindingsDaniel Eklöf2021-12-11-397/+211
| | | | | | | | | | | | | | With this patch, key- and mouse-bindings structs (the non-layout specific ones) are unified into a single struct. The logic that parses, and manages, the key- and mouse binding lists are almost identical. The *only* difference between a key- and a mouse binding is that key bindings have an XKB symbol, and mouse bindings a button and click-count. The new, unified, struct uses a union around these, and all functions that need to know which members to use/operate on now takes a ‘type’ parameter.
* config: do mouse binding collision detection after loading the confDaniel Eklöf2021-12-11-206/+214
|
* config: value_to_key_combos(): reset modifiers in bindingDaniel Eklöf2021-12-11-0/+1
|
* config: do key binding collision detection after loading the confDaniel Eklöf2021-12-11-199/+244
| | | | | | | | | | | | | | | | | | | | | | | | | | This allows the user to write, to swap two key bindings: [key-bindings] show-urls-launch=Control+Shift+r search-start=Control+Shift+u instead of: [key-bindings] search-start=none show-urls-launch=Control+Shift+r search-start=Control+Shift+u This should simplify the configuration for people who replace a lot of the default key bindings. This also simplifies the parsing somewhat, since we no longer has to parse a key-binding into a temporary list, ensure it doesn’t have any collisions, and then copy it into the actual key binding list. _While_ parsing a key-binding, we still need a temporary array (at least for the time being), but that temporary array is no longer visible outside the parsing function that allocates it.
* config: remove struct key_combo, use config_key_binding insteadDaniel Eklöf2021-12-11-179/+146
|
* config: improve error reporting when selection-override-modifiers conflict with mouse bindingsfeeptr@codeberg.org2021-12-04-7/+54
|
* config: move button_map out of value_to_mouse_combos for reusefeeptr@codeberg.org2021-12-02-17/+17
| | | | this mapping is only available here or in libevdev (libevdev_event_code_get_name) and it's simpler to factor it out here
* config, doc, changelog: move selection-override-modifiers to [mouse-bindings] and validate other ↵feeptr@codeberg.org2021-12-02-7/+31
| | | | | | case specifically, check for conflicts both when mouse bindings are set and when the selection-override-modifiers setting itself is set
* config: parse 'none' as empty modifiers valuefeeptr@codeberg.org2021-12-02-0/+5
|
* config, input: allow configuring select-override modifiersfeeptr@codeberg.org2021-12-02-10/+76
|
* config: add tweak.grapheme-width-method=maxDaniel Eklöf2021-11-23-1/+1
| | | | | | ‘max’ is a new value for ‘tweak.grapheme-width-method’. When enabled, the width of a grapheme cluster is that of the cluster’s widest codepoint.
* config: argv_compare(): change parameters to ‘struct argv *’Daniel Eklöf2021-11-21-40/+46
| | | | | | | | | | | | | Instead of passing raw char** pointers to argv_compare(), pass pointers to ‘struct argv’. This lets argv_compare() handle both argv’s being NULL, or one of them being NULL. That is, the caller no longer needs to check that both argv’s are non-NULL before calling argv_compare(). Furthermore, update has_key_binding_collisions() to require the pipe argv to match, in addition to matching the ‘action’, when allowing a key collision.
* config: pipe_argv_from_value(): plug memory leakDaniel Eklöf2021-11-21-22/+18
| | | | | | When parsing a key binding with a pipe-argv, we failed to free the argv vector (or to be precise, the strdup:ed entries in the array) when failing to parse the remainder of the binding.
* Merge branch 'fix-809'Daniel Eklöf2021-11-21-6/+2
|\ | | | | | | Closes #809
| * Fix parsing key-bindings config to not read past the end of the string.Arnavion2021-11-21-6/+2
| | | | | | | | | | | | | | pipe_argv_from_value itself stripped the cmd-to-exec from ctx->value, so the callers should not be doing that themselves. Fixes #809
* | Merge branch 'remove-unreachable'Craig Barnes2021-11-21-27/+4
|\ \
| * | config: Simplify render-timer option handlingXiretza2021-11-20-23/+4
| | |
| * | config: Remove some "UNREACHABLE" UB footgunsXiretza2021-11-20-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Every branch of these long if/else if/else chains returns, so the compiler can figure out on its own that the last line is never reached. If, for some reason, one of the branches does not return (as was the case after 205f1f7, fixed by b22322b), this would usually result in a compiler error ("control reaches end of non-void function"), but adding UNREACHABLE transforms this into silent undefined behaviour.
* | | config: create a copy of the section nameDaniel Eklöf2021-11-21-2/+8
| |/ |/| | | | | | | | | | | | | | | | | | | | | The parsing context keeps a pointer to the current section name. This is used when logging errors. However, the pointer was into a buffer allocated by getline(). This buffer are often re-used in the next call to getline(), or free:d. Regardless, the section name pointer is invalid after the next call to getline(), which meant all error messages were logging a correct section name.
* | config: use stack allocation for temporary buffer in value_to_enum()Craig Barnes2021-11-20-4/+5
| | | | | | | | | | | | The maximum size required for the string buffer is relatively small, known at compile-time and not likely to ever grow beyond 512 bytes. Therefore we may as well just use the stack.
* | config: fix memory leak in value_to_enum()Craig Barnes2021-11-20-0/+1
|/ | | | | | | | | This could be triggered by running, for example: foot -o tweak.render-timer=invalid For some reason LeakSanitizer was only detecting this leak when the option value was invalid, even though it was occuring in either case.
* config: letter-spacing: add missing ‘return’Daniel Eklöf2021-11-15-1/+1
| | | | | | | | | The missing return caused us to fall through to the bottom of the function, where we ended with an error message: [main].letter-spacing: 0: not a valid option: letter-spacing Closes #795
* user-notification: config: various small cleanupsCraig Barnes2021-11-14-13/+8
| | | | | | | * Rename user_notification_add() to user_notification_add_fmt() * Add new user_notification_add() helper function * Use xvasprintf() to replace user_notification_add_va() * Make better use of helper functions in config.c
* config: remove options that were deprecated in 1.8.xDaniel Eklöf2021-11-14-82/+0
| | | | | | | * [main].bell * [main].jump-label-letters * [main].url-launch * [main].osc8-underline
* config: add [colors].dim0-7Daniel Eklöf2021-11-13-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | This allows you to configure custom colors to be used when colors are being dimmed (`\E[2m`). It is implemented by color matching (just like bold-text-in-bright=palette-based); the color-to-be-dimmed is matched against the current color palette. If it matches one of the regular colors (colors 0-7), the corresponding “dim” color will be used. If it matches one of the bright colors (colors 8-15), the corresponding “regular” color will be used (but *only* if the “dim” color has been set). Otherwise, the color is dimmed by reducing its luminance. The default behavior, i.e. when dim0-7 hasn’t been configured, is to dim by reducing luminance for *all* colors. I.e. we don’t do any color matching at all. In particular, this means that dimming a bright color will *not* result in the corresponding “regular” color. Closes #776
* config: scrollback.indicator.text: use value_to_wchars()Daniel Eklöf2021-11-13-13/+2
|
* config: value_to_wchars(): free the target variableDaniel Eklöf2021-11-13-34/+11
|
* config: appease compilerDaniel Eklöf2021-11-13-1/+1
| | | | | | | | ../../foot/config.c:154:50: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] log_msg(log_class, LOG_MODULE, file, lineno, formatted_msg); ^~~~~~~~~~~~~ ../../foot/config.c:154:50: note: treat the string as an argument to avoid this log_msg(log_class, LOG_MODULE, file, lineno, formatted_msg)
* config: drop all warning logs from the tweak sectionDaniel Eklöf2021-11-13-50/+18
|
* config: value_to_enum(), return conversion success/failure as a boolDaniel Eklöf2021-11-13-79/+91
| | | | | | | Result is set through a pointer passed as an argument. Note that we assume enums are 32-bit, and explicitly cast them to int*. Static asserts have been added to ensure this invariant holds.
* config: parse_section_main(): explicit return from each branchDaniel Eklöf2021-11-13-25/+27
| | | | Add UNREACHABLE() at the bottom
* config: add value_to_dimensions()Daniel Eklöf2021-11-13-12/+13
|
* config: add {str,value}_to_uint{16,32}()Daniel Eklöf2021-11-13-92/+78
| | | | | This allows us to pass the final pointer directly to the conversion functions, as well as allowing us to print outside-range errors.
* config: add value_to_str()Daniel Eklöf2021-11-13-18/+17
| | | | Takes a pointer to a char*, free:s it, and strdups the current value.
* config: value_to_bool: return success/failDaniel Eklöf2021-11-13-26/+49
| | | | | Write boolean value to a pointer passed as argument, return conversion success/failure
* config: add value_to_enum()Daniel Eklöf2021-11-13-103/+107
|
* config: let value_to_double() log errorsDaniel Eklöf2021-11-13-13/+14
|
* config: let value_to_ulong() log errorsDaniel Eklöf2021-11-13-29/+16
|
* config: add LOG_CONTEXTUAL_{ERR,WARN,ERRNO}Daniel Eklöf2021-11-13-287/+161
| | | | | | These work like LOG_AND_NOTIFY_* but add contextual information: path of the conf file, line number, section name, key/option name and the value.