aboutsummaryrefslogtreecommitdiff
path: root/dcs.c (unfollow)
Commit message (Collapse)AuthorLines
2025-02-21DECSCUSR+DECRQSS: treat hollow cursor as a block cursorDaniel Eklöf-0/+1
If the user has configured cursor.style=hollow, make DECSCUSR 1/2 set the cursor to hollow rather than block, and make DECRQSS DECSCUSR respond as if cursor.style=block. The idea is to not expose the hollow variant in DECSCUSR in any way, to avoid having to extend it with custom encodings. Another way to think about it is this is just a slightly more discoverable way of doing: cursor.style=block cursor.block-cursor-is-hollow=yes
2024-10-23config: add color.sixelN optionsDaniel Eklöf-1/+1
These options allows you to configure the default sixel color palette.
2024-09-13xsnprintf: various improvements related to xvsnprintf() and xsnprintf()Craig Barnes-11/+11
Summary of changes: * Make xvsnprintf() static * restrict-qualify pointer arguments (as done by the libc equivalents) * Make comments and spec references more thorough * Remove pointless `n <= INT_MAX` assertion (see comment) * Use FATAL_ERROR() instead of xassert() (since the assertion is inside a shared util function but the caller is responsible for ensuring the condition holds true) * Change some callers to use size_t instead of int for the return value (negative returns are impossible and all subsequent uses are size_t) The updated comments and code were taken (and adapted) from: https://gitlab.com/craigbarnes/dte/-/blob/49260bb154bca0434462a41c061e512540ec2e49/src/util/xsnprintf.c#L6-50 This work was entirely authored by me and I hereby license this contribution under the MIT license (stated explicitly, so that there's no ambiguity w.r.t. the original license).
2024-07-01Rename various uses of "curly" in the source code with "underline"Craig Barnes-7/+7
Since "curly" could make it seem as if all underline styles are curled (to people unfamiliar with the codebase), whereas in reality only 1 is.
2024-07-01dcs: DECRQSS: styled+colored underlinesDaniel Eklöf-12/+46
2024-04-20dcs: XTGETTCAP: handle empty requestDaniel Eklöf-0/+6
If the XTGETTCAP request is empty (no capabilities in it), reply with an empty error reply. Closes #1694
2024-04-10dcs: DECRQSS: fix off-by-one when checking for space in the DCS bufferDaniel Eklöf-1/+1
2024-02-06Don't use fancy Unicode quotes, stick to ASCIIDaniel Eklöf-4/+4
2023-09-25dcs: xtgettcap: ignore queries with invalid hex encodingsDaniel Eklöf-7/+4
When we receive an XTGETTCAP query, where the capability is not correctly hex encoded, ignore it. Before this patch, we echo:ed it back to the TTY inside an error resonse.
2023-06-29sixel: special case parsing of images with an aspect ratio of 1:1Daniel Eklöf-2/+1
Images with an aspect ratio of 1:1 are by far the most common (though not the default). It makes a lot of sense, performance wise, to special case them. Specifically, the sixel_add() function benefits greatly from this, as it is the inner most, most heavily executed function when parsing a sixel image. sixel_add_many() also benefits, since allows us to drop a multiplication. Since sixel_add_many() always called first (no other call sites call sixel_add() directly), this has a noticeable effect on performance. Another thing that helps (though not as much), and not specifically with AR 1:1 images, is special casing DECGRI a bit. Up until now, it simply updated the current sixel parameter value. The problem is that the default parameter value is 0. But, a value of 0 should be treated as 1. By adding a special ‘repeat_count’ variable to the sixel struct, we can initialize it to ‘1’ when we see DECGRI, and then simply overwrite it as the parameter value gets updated. This allows us to drop an if..else when emitting the sixel.
2022-04-06config: add tweak option to allow disabling sixelsjvoisin-0/+3
Closes #950
2022-03-21dcs: don’t automatically buffer anythingDaniel Eklöf-5/+0
If a request handler doesn’t define its own put() handler, simply drop all DCS parameter data. This way, we won’t end up allocating potentially large buffers for unsupported/unimplemented DCS requests. Closes #959
2022-03-21dcs: xtgettcap: use custom put() handlerDaniel Eklöf-5/+21
Grow buffer exponentially, since XTGETTCAP requests can, theoretically, be very large.
2022-03-21dcs: decrqss: use a custom put() handlerDaniel Eklöf-22/+36
Only buffer up to two bytes, as that’s the largest DECRQSS request we support.
2022-03-21dcs: map BSU/ESU unhook handlers directly to term_{enable,disable}_app_sync_upates()Daniel Eklöf-26/+7
That is, drop the local bsu() and esu() functions.
2022-03-02dcs: prevent possibility of out-of-bounds reads in decrqss()Craig Barnes-4/+4
This could be triggered by running, for example: printf '\033P$qrxyz\033\\' ...which would cause a memcmp() of 4 bytes on a 2 byte string literal. Fixes: #960
2022-01-14dcs: decrqss: refactor: append_sgr_attr_n() is now a proper functionDaniel Eklöf-27/+28
2022-01-14dcs: decrqss: add note about Ps in the replyDaniel Eklöf-0/+11
2022-01-14dcs: decrqss: BUG on invalid cursor styleDaniel Eklöf-0/+1
2022-01-14dcs: implement DECRQSSDaniel Eklöf-0/+163
This patch adds support for DECRQSS (request Selection or Setting), for the following sub-queries: * DECSTBM Set Top and Bottom Margins * SGR Set Graphic Rendition * DECSCUSR Set Cursor Style Closes #798
2022-01-13xtgettcap: switch from a table based internal structure, to a single char arrayDaniel Eklöf-13/+51
Having the builtin terminfo DB as a table, with one entry per capability/value pair was ineffective memory-wise - we ended up adding ~20K to the final binary size. This patch changes the internal representation from a table, to a single NULL-separated (and NULL-terminated) char array: cap1-name \0 cap1-value \0 cap2-name \0 cap2-value \0 The capabilities are still sorted; to lookup a capability we need to scan from the beginning until we either find a match, or until the capabilities from the DB sort higher (lexicographically) than the searched-for capability. The terminfo char array is 3.3K - more better than before.
2022-01-13dcs: xtgettcap: handle boolean capabilitiesDaniel Eklöf-0/+8
Reply with DCS 1 + r <cap> ST
2022-01-13dcs: implement XTGETTCAPDaniel Eklöf-1/+147
We emit one DCS reply for each queried capability (like Kitty, but unlike XTerm), as this allows us to a) not skip any capabilities in the query, and b) reply with correct success/fail flag for each capability. We do not batch the entire reply - as soon as the reply for _one_ capability is done, we write it to the PTY. Closes #846
2021-04-25dcs: only log debug warnings in bsu() and esu() for unhandled paramsCraig Barnes-4/+6
2021-03-11sixel: implement P2=1 - transparent pixelsDaniel Eklöf-2/+7
When P2=1, empty pixels are transparent. This patch also changes the behavior of P2=0|2, from setting empty pixels to the default background color, to instead use the *current* background color. To implement this, a couple of changes are needed: * Sixel pixels always use alpha=1.0, except for *empty* cells when P2=1 (i.e. transparent pixels). * The renderer draws sixels with the OVER operator, instead of the SRC operator. * The renderer *must* now render the cells beneath the sixel. As an optimization, this is only done for sixels where P2=1. I.e. for fully opaque sixels, there’s no need to render the cells beneath. The sixel renderer isn’t yet hooked into the multi-threaded renderer. This means *rows* (not just the cells) beneath maybe-transparent sixels are rendered single-threaded. Closes #391.
2021-01-16debug: rename assert() to xassert(), to avoid clashing with <assert.h>Craig Barnes-5/+5
2020-12-16vt: don’t ignore extra private/intermediate charactersDaniel Eklöf-3/+3
Take ‘\E(#0’ for example - this is *not* the same as ‘\E(0’. Up until now, foot has however treated them as the same escape, because the handler for ‘\E(0’ didn’t verify there weren’t any _other_ private characters present. Fix this by turning the ‘private’ array into a single 4-byte integer. This allows us to match *all* privates with a single comparison. Private characters are added to the LSB first, and MSB last. This means we can check for single privates in pretty much the same way as before: switch (term->vt.private) { case ‘?’: ... break; } Checking for two (or more) is much uglier, but foot only supports a *single* escape with two privates, and no escapes with three or more: switch (term->vt.private) { case 0x243f: /* ‘?$’ */ ... break; } The ‘clear’ action remains simple (and fast), with a single write operation. Collecting privates is potentially _slightly_ more complex than before; we now need mask and compare, instead of simply comparing, when checking how many privates we already have. We _could_ add a counter, which would make collecting privates easier, but this would add an additional write to the ‘clean’ action which is really bad since it’s in the hot path.
2020-10-10selection: use appropriate check for PRIMARY pasteSergey Nazaryev-468/+47
Assume it could be a copy-paste typo. We should check PRIMARY, not CLIPBOARD. Without this fix, we can't use PRIMARY until we copy anything to CLIPBOARD.
2020-02-21sixel: initial supportDaniel Eklöf-3/+20
This implements basic parsing of sixel data. Lots of limitations and temporary solutions as this is still work-in-progress: * Maximum image size hardcoded to 800x800 * No HLS color format support * Image is always rendered at 0x0 in the terminal
2020-01-29dcs: fix comment: ESU is *End* synchronized updateDaniel Eklöf-1/+1
2020-01-26dcs: bsu/esu: convert warning log to debug logDaniel Eklöf-2/+2
2020-01-25dcs: remove abort() from BSU/ESUDaniel Eklöf-2/+0
2020-01-20dcs: remove assert; handler may be zero on unimplemented OCS commandDaniel Eklöf-1/+0
2020-01-12term: shorten application_synchronized_updates -> app_sync_updatesDaniel Eklöf-2/+2
2020-01-12dcs: bsu/esu: add link to specDaniel Eklöf-0/+4
2020-01-12dcs: abort() in bsu/esuDaniel Eklöf-2/+4
Since I haven't seen this in the wild, let's abort() to make sure we catch when an application does this, so we can verify it really works.
2020-01-12term/render: move {enable,disable}_application_synchronized_updates()Daniel Eklöf-3/+2
From render -> terminal
2020-01-12render: rename render_{enable,disable}_refresh()Daniel Eklöf-2/+3
2020-01-12dcs: bsu/esu: call render_{disable,enable}_refresh()Daniel Eklöf-6/+8
2020-01-12dcs: abort() in bsu/esuDaniel Eklöf-0/+2
I **really** want to know if someone is using these...
2020-01-12dcs: put: don't append data if buffer resize failedDaniel Eklöf-1/+2
2020-01-12dcs: use default param value of 0 in log messageDaniel Eklöf-1/+1
2020-01-12dcs: initial handling of DCS in generalDaniel Eklöf-0/+87
Add data structure to term->vt. This structure tracks the free-form data that is passed-through, and the handler to call at the end. Intermediates and parameters are collected by the normal VT parser. Then, when we enter the passthrough state, we call dcs_hook(). This function checks the intermediate(s) and parameters, and selects the appropriate unhook handler (and optionally does some execution already). In passthrough mode, we simply append strings to an internal buffer. This might have to be changed in the future, if we need to support a DCS that needs to execute as we go. In unhook (i.e. when the DCS is terminated), we execute the unhook handler. As a proof-of-concept, handlers for BSU/ESU (Begin/End Synchronized Update) has been added (but are left unimplemented).
2019-07-21dcs: we have no parent terminal to pass through toDaniel Eklöf-32/+0
2019-07-19dcs: sort of implement DCS passthroughDaniel Eklöf-0/+32
We now store the passthrough characters in a buffer, and call dcs_passthrough() on unhook. However, dcs_passthrough() doesn't do anything.