aboutsummaryrefslogtreecommitdiff
path: root/render.c (follow)
Commit message (Collapse)AuthorAgeLines
* composed: store compose chains in a binary search treeDaniel Eklöf2021-06-24-5/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous implementation stored compose chains in a dynamically allocated array. Adding a chain was easy: resize the array and append the new chain at the end. Looking up a compose chain given a compose chain key/index was also easy: just index into the array. However, searching for a pre-existing chain given a codepoint sequence was very slow. Since the array wasn’t sorted, we typically had to scan through the entire array, just to realize that there is no pre-existing chain, and that we need to add a new one. Since this happens for *each* codepoint in a grapheme cluster, things quickly became really slow. Things were ok:ish as long as the compose chain struct was small, as that made it possible to hold all the chains in the cache. Once the number of chains reached a certain point, or when we were forced to bump maximum number of allowed codepoints in a chain, we started thrashing the cache and things got much much worse. So what can we do? We can’t sort the array, because a) that would invalidate all existing chain keys in the grid (and iterating the entire scrollback and updating compose keys is *not* an option). b) inserting a chain becomes slow as we need to first find _where_ to insert it, and then memmove() the rest of the array. This patch uses a binary search tree to store the chains instead of a simple array. The tree is sorted on a “key”, which is the XOR of all codepoints, truncated to the CELL_COMB_CHARS_HI-CELL_COMB_CHARS_LO range. The grid now stores CELL_COMB_CHARS_LO+key, instead of CELL_COMB_CHARS_LO+index. Since the key is truncated, collisions may occur. This is handled by incrementing the key by 1. Lookup is of course slower than before, O(log n) instead of O(1). Insertion is slightly slower as well: technically it’s O(log n) instead of O(1). However, we also need to take into account the re-allocating the array will occasionally force a full copy of the array when it cannot simply be growed. But finding a pre-existing chain is now *much* faster: O(log n) instead of O(n). In most cases, the first lookup will either succeed (return a true match), or fail (return NULL). However, since key collisions are possible, it may also return false matches. This means we need to verify the contents of the chain before deciding to use it instead of inserting a new chain. But remember that this comparison was being done for each and every chain in the previous implementation. With lookups being much faster, and in particular, no longer requiring us to check the chain contents for every singlec chain, we can now use a dynamically allocated ‘chars’ array in the chain. This was previously a hardcoded array of 10 chars. Using a dynamic allocated array means looking in the array is slower, since we now need two loads: one to load the pointer, and a second to load _from_ the pointer. As a result, the base size of a compose chain (i.e. an “empty” chain) has now been reduced from 48 bytes to 32. A chain with two codepoints is 40 bytes. This means we have up to 4 codepoints while still using less, or the same amount, of memory as before. Furthermore, the Unicode random test (i.e. write random “unicode” chars) is now **faster** than current master (i.e. before text-shaping support was added), **with** test-shaping enabled. With text-shaping disabled, we’re _even_ faster.
* render: use cell cols from compose chain, not graphemeDaniel Eklöf2021-06-24-1/+2
| | | | | | fcft’s view of how many columns a grapheme cluster is may differ from our own. Make sure the rendered glyph matches the number of columns that were allocated when the cluster was printed.
* render: don’t modify the cell’s x position. Fixes broken underlinesDaniel Eklöf2021-06-24-6/+7
|
* render: we’ve already assigned ‘base’ a couple of lines higher upDaniel Eklöf2021-06-24-2/+1
|
* render: repair parenthesis after rebaseDaniel Eklöf2021-06-24-5/+5
|
* render: ensure ‘cell_cols’ have been initializedDaniel Eklöf2021-06-24-1/+1
|
* render: handle fcft_glyph_rasterize() failure correctlyDaniel Eklöf2021-06-24-3/+8
|
* render: use column count from grapheme instead of first glyph, when we have oneDaniel Eklöf2021-06-24-2/+8
|
* wip: grapheme shapingDaniel Eklöf2021-06-24-43/+85
|
* wayland: apply CSD/SSD changes in the surface configure eventDaniel Eklöf2021-06-23-11/+11
| | | | | | | | | | | | | | | | | | The configure event asks the client to change its decoration mode. The configured state should not be applied immediately. Clients must send an ack_configure in response to this event. See xdg_surface.configure and xdg_surface.ack_configure for details. In particular, ”the configured state should *not* be applied immediately”. Instead, treat CSD/SSD changes like all other window dimension related changes: store the to-be mode in win->configure, and apply it in the surface configure event. This fixes an issue where foot incorrectly resized the window when the server switched between CSD/SSD at run-time.
* config: add csd.button-color optionDaniel Eklöf2021-06-20-4/+18
| | | | | | | | This option controls the foreground color of the minimize/maximize/close buttons. I.e. the color used to draw the minimize/maximize/close glyphs. It defaults to default background color.
* render: don’t create/destroy the title update timer each timeDaniel Eklöf2021-06-18-30/+2
| | | | | Create it once when instantiating the terminal. Add a boolean to track whether the timer is running or not.
* render: use a timer instead of relying on the frame callback for title update throttlingDaniel Eklöf2021-06-18-13/+50
| | | | | | | | | | | | | | | | | | | | | Using the frame callback works most of the time, but e.g. Sway doesn’t call it while the window is hidden, and thus prevents us from updating the title in e.g. stacked views. This patch uses a timer FD instead. We store a timestamp from when the title was last updated. When the application wants to update the title, we first check if we already have a timer running, and if so, does nothing. If no timer is running, check the timestamp. If enough time has passed, update the title immediately. If not, instantiate a timer and wait for it to trigger. Set the minimum time between two updates to ~8ms (twice per frame, for a 60Hz output, and ~once per frame on a 120Hz output). Closes #591
* config: add underline-offset optionDaniel Eklöf2021-06-17-1/+5
| | | | | | | | This option allows the user to configure a custom underline offset. That is, use the user provided offset instead of the font provided one. Closes #490
* vt: emit a tab character if all cells between cursor and tab stop are emptyDaniel Eklöf2021-06-08-1/+1
| | | | | | | | | | | | | | | | | | | | | | TAB (\t) move the cursor to the next tab stop. That’s it, according to the specification. However, many terminal emulators try to keep tabs in the grid, to be able to e.g. copy them. That is, copying a text chunk containing tabs should result in tabs being pasted, not spaces. In order to do that, we need to print a tab character to the grid. To improve text reflow of tabs, we also print spaces to the subsequent cells, up until (but not including) the next tab stop. However, we can only do this if all the cells between the cursor and the next tab stop are empty, since (obviously), we cannot overwrite pre-existing characters. Finally, while some fonts render tabs as spaces (i.e. an empty glyph), some use a glyph representing “unprintable” characters, or similar. Thus, we need to exclude cells with tab characters when rendering.
* render: reverse video only swaps *default* fg/bgDaniel Eklöf2021-06-08-4/+4
| | | | | | | | | This matches XTerm behavior, and fixes vttest 11.6.6.2: Test non-VT100 -> Test ISO-6429 colors -> Test of VT102-style features with BCE -> Test of screen features
* config: add boolean option tweak.pua-double-widthDaniel Eklöf2021-06-01-7/+11
| | | | | | | When enabled, PUA (Private Usage Area) codepoints are always treated as double-width glyphs, regardless of the actual glyph width. Requires allow-overflowing-double-width-glyphs=yes
* config: add cursor.underline-thicknessDaniel Eklöf2021-05-22-18/+44
| | | | | | | | | | | | | Works in pretty much the same way as ‘beam-thickness’, except that the default value is “the font’s underline thickness”. This means, that when unset, the cursor underline thickness scales with the font size. But, when explicitly set, either to a point size value, or a pixel size, it remains fixed at that size. Closes #524
* render: stop spamming “resize” INFO logsDaniel Eklöf2021-05-17-3/+0
| | | | | | | | It _may_ be acceptable in e.g. tiling WMs, where windows are seldom resized interactively. But in a stacking WM where the typical way of resizing windows is by interactive resizes, this spams way too much.
* render: simply check for an invalid (not set) scaling factorDaniel Eklöf2021-05-17-1/+1
|
* render: set tracking point count to 0 if there’s no active selectionDaniel Eklöf2021-05-15-1/+1
|
* term: rename CELL_MULT_COL_SPACER -> CELL_SPACER, and change its definitionDaniel Eklöf2021-05-14-5/+5
| | | | | | | | | | | | | | | | | | | | | Instead of using CELL_SPACER for *all* cells that previously used CELL_MULT_COL_SPACER, include the remaining number of spacers following, and including, itself. This is encoded by adding to the CELL_SPACER value. So, a double width character will now store the character itself in the first cell (just like before), and CELL_SPACER+1 in the second cell. A three-cell character would store the character itself, then CELL_SPACER+2, and finally CELL_SPACER+1. In other words, the last spacer is always CELL_SPACER+1. CELL_SPACER+0 is used when padding at the right margin. I.e. when writing e.g. a double width character in the last column, we insert a CELL_SPACER+0 pad character, and then write the double width character in the first column on the next row.
* render: force underlines to be visibleDaniel Eklöf2021-05-12-2/+5
| | | | | | | | | | | | | | | In some cases, the underline position (typically provided by the font, mind you), end up below the cell, making it visible. Note that below the cell here means below the line. I.e. the font provided underline position is below the font provided line height... Oh well. Doing this in foot rather than fcft, since other applications typically don’t have to clip the rendered text. Closes #503
* quirk: remove plasma/kwin quirkDaniel Eklöf2021-05-12-1/+0
| | | | | | Older version of Plasma/KWin had an issue where buffer damage recorded before the buffer was attached were ignored. This appears to have been fixed now.
* render: always do a full repaint if last buffer’s dimension doesn’t matchDaniel Eklöf2021-05-12-8/+9
|
* render: add margins to buffer’s dirty region when rendering marginsDaniel Eklöf2021-05-12-0/+12
|
* shm: clear buffer’s dirty region before returning a cached bufferDaniel Eklöf2021-05-12-2/+0
| | | | A non-busy buffer should always have an empty dirty region
* render: warn if we’re forced to double buffer at least 5 timesDaniel Eklöf2021-05-12-1/+8
|
* render: code cleanup, log double buffering timeDaniel Eklöf2021-05-12-179/+185
| | | | | | | | | | | * Break out cursor cell dirtying to separate functions * Break out handling of double buffering * Handle buffers with age > 1 (we’re swapping between more than 2 buffers) * Detect full screen repaints, and skip re-applying old frame’s damage * Use an allocated array insted of a tll list for old frame’s scroll damage * When logging frame rendering time, including the amount used for double buffering.
* render: subtract current frame’s damage when there’s no scroll damageDaniel Eklöf2021-05-12-10/+6
| | | | | | | | | | | When re-applying the previous frame’s damage (due to us being forced to double buffer), subtract the current frame’s damage from the region-to-copy when there’s no scroll damage on the current frame. When the current frame doesn’t have any scroll damage, the current frame’s damage is in the same coordinate system as the previous frame’s damage, and we can safely remove it from the region we copy from.
* render: wip: re-apply last frame’s damage when forced to double bufferDaniel Eklöf2021-05-12-12/+132
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we are forced to swap between two buffers, re-apply the old frame’s damage to the current buffer, before applying the current frame’s damage. First, while applying this frame’s scroll damage, copy it to the buffer’s scroll damage list (so that we can access it via term->render.last_buf). Also, when iterating and rendering the grid, build a pixman region of the damaged regions. This is currently done on a per-row basis. This is also stored in the buffer. Now, when being forced to double buffer, first iterate the old buffer’s damage, and re-apply it to the current buffer. Then, composite the old buffer on top of the current buffer, using the old frame’s damage region as clip region. This effectively copies everything that was rendered to the last frame. Remember, this is on a per-row basis. Then we go on and render the frame as usual. Note that it would be _really_ nice if we could subtract the current frame’s damage region from the clip region (no point in copying areas we’re going to overwrite anyway). Unfortunately, that’s harder than it looks; the current frame’s damage region is only valid *after* this frame’s scroll damage have been applied, while the last frame’s damage region is only valid *before* it’s been applied. Translating one to the other isn’t easy, since scroll damage isn’t just about counting lines - there may be multiple scroll damage records, each with its own scrolling region. This creates very complex scenarios.
* shm: track busy buffers’ age, and add compile-time option to force double bufferingDaniel Eklöf2021-05-12-0/+6
| | | | | | | | | By default, age all matching buffers that are busy (i.e. in use by the compositor). This allows us to detect whether we can apply the current frame’s damage directly, or if we need to prepare the buffer first (e.g. copy old buffer, or re-apply last frame’s damage etc).
* box-drawing: add Unicode 13 U+1FB70 - U+1FB8BDaniel Eklöf2021-05-04-3/+28
| | | | Part of #471
* render: only apply alpha when we’re using the default bg for backgroundDaniel Eklöf2021-05-04-4/+6
| | | | | | | | In all other cases, alpha is disabled. This includes: * Palette- or RGB-colors matching the default background color * When any kind of reverse video is enabled (e.g. DECSCNM, or ANSI reverse)
* config: add ‘beam-thickness’ optionDaniel Eklöf2021-04-30-10/+11
| | | | | | | | | | | * Rename cursor.style value ‘bar’ to ‘beam’. ‘bar’ remains recognized, but should eventually be deprecated and then removed. * Add ‘cursor.beam-thickness’ option, a pt-or-px value specifying the thickness of the beam cursor. Defaults to 1.5pt. * Rename (and export) pt_or_px_as_pixels() to term_pt_or_px_as_pixels() * Change term_pt_or_px_as_pixels() to round point values instead of truncating them.
* render: modify background color for highlighted text when fg == bgDaniel Eklöf2021-04-24-0/+5
| | | | | | | | When rendering a selected/highlighted cell where the foreground and background colors are the same, invert the background color to make the selected text legible. Closes #455
* render: do render concealed text when it’s highlightedDaniel Eklöf2021-04-23-1/+4
|
* config: bold-text-in-bright: add ‘palette-based’ as a special valueDaniel Eklöf2021-04-17-4/+6
| | | | | | | | | When ‘bold-text-in-bright’ is set ‘to palette-based’, colors matching one of the 8 regular palette colors are brightened by using the corresponding bright palette color. Other colors, or all colors if ‘bold-text-in-bright’ is set to ‘yes|true’, are brightened by increasing the luminance.
* render: brighten: use corresponding bright palette color for base 8 colorsDaniel Eklöf2021-04-17-2/+11
| | | | | | | | When brightening one of the 8 base (“regular”) colors, use the corresponding bright palette color, instead of increasing the luminance. Closes #449
* render: no need to blend fully opaque sixel images - just blit themDaniel Eklöf2021-04-14-1/+1
|
* render: don’t let URL jump label sub-surfaces extend outside window geometryDaniel Eklöf2021-04-10-27/+58
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We have no guarantee that sub-surfaces extending outside the window geometry are rendered correctly (if at all). For example, both Sway and River will render the window border on top of the sub-surface. Future versions of Sway may clip the sub-surface. Since jump-labels are positioned slightly above, and to the left of the URLs first character, having a label on either the top row, or on the first column, will likely position it outside the window. This is handled by simply setting x/y to 0 (or, to -margin, since the label coordinate is later offsetted with the window margins). Second, if the label is very long, it may extend outside the window. This is very unusual for labels only showing the key, and not the URL itself, but could happen in this case too, if e.g. the user has configured double-width key characters. This is handled by calculating its maximum width, and then truncating the label. Although very unlikely, it is possible for a label to also extend outside the window’s vertical size. This could happen for very small font sizes, where the label’s own margins are large, relative to the font size. This case is currently not handled. Closes #443
* Merge branch 'optionally-render-box-drawing-characters-using-font-glyphs'Daniel Eklöf2021-04-10-1/+3
|\ | | | | | | Closes #430
| * config: add box-drawings-uses-font-glyphs=no|yes optionDaniel Eklöf2021-04-09-1/+3
| | | | | | | | | | | | | | | | | | When disabled, we render box drawing characters ourselves. This is the default. When enabled, we instead use font glyphs. I.e. no special treatment. Closes #430
* | render: draw underline cursor below text underlineDaniel Eklöf2021-04-09-2/+3
|/ | | | | | | This ensures the cursor is visible on cells where the text is underlined. Closes #415
* osc: implement OSC 17+19: change selection background/foreground colorsDaniel Eklöf2021-04-08-3/+3
| | | | | And of course, we also implement the corresponding reset sequences, OSC 117+119.
* config/terminal: refactor: remove “default_*” color members from terminal structDaniel Eklöf2021-04-07-8/+8
| | | | Access the original colors in the configuration instead.
* render: make sure surface buffer sizes are a multiple of the scaling factorDaniel Eklöf2021-03-25-11/+41
| | | | | | | | | | | | | | | | | | | | | The buffer attached to a surface with wl_surface_attach() must have a width and height that both are a multiple of the scale configured for that buffer: The new size of the surface is calculated based on the buffer size transformed by the inverse buffer_transform and the inverse buffer_scale. This means that at commit time the supplied buffer size must be an integer multiple of the buffer_scale. If that's not the case, an invalid_size error is sent. Due to a libwayland bug[^1], this is currently *not* being reported as an error. However, recent versions of Sway have started enforcing this, and is e.g. dropping (not rendering) sub-surfaces that does not adhere to this. [^1]: https://gitlab.freedesktop.org/wayland/wayland/-/issues/194 Closes #409
* render: render_osd(): no need to pass width/height as parametersDaniel Eklöf2021-03-25-8/+8
| | | | | | All uses of render_osd() passes buf->width/buf->height as width/height. Thus, we can simply remove the width/height parameters and have render_osd() use buf->width and buf->height directly.
* render: draw sixels before taking the render worker lockDaniel Eklöf2021-03-25-2/+2
| | | | | | | This fixes a possible deadlock; render_sixels_images() may call render_cell(), which may need to take the worker lock (when rendering either a blinking cell, or a box drawing glyph that isn’t yet in the glyph cache).
* ime: don’t pass ‘term’ to ime_update_cursor_rect()Daniel Eklöf2021-03-25-2/+2
| | | | | | | | | In all instances where we call ime_update_cursor_rect(), the ‘term’ argument is the same as seat->kbd_focus. So, let ime_update_cursor_rect() use that directly instead. Also make ime_send_cursor_rect() static (i.e. local to ime.c).
* ime: move preedit state from terminal struct to the seat structDaniel Eklöf2021-03-25-34/+56
| | | | | | | | | | | | | | | | | This ensures different seat’s don’t step on each others IME pre-edit state. It also removes most dependencies on having a valid term pointer for many IME operations. We’re still not all the way, since we support disabling IME with a private mode, which is per terminal, not seat. Thus, we still require the seat to have keyboard focus on one of our windows. Closes #324. But note that *rendering* of multiple seat’s IME pre-edit strings is still broken.
* render: sixels: render cursor, if it’s partially covered by an opaque sixelDaniel Eklöf2021-03-11-1/+3
|
* sixel: implement P2=1 - transparent pixelsDaniel Eklöf2021-03-11-30/+44
| | | | | | | | | | | | | | | | | | | | | | | | When P2=1, empty pixels are transparent. This patch also changes the behavior of P2=0|2, from setting empty pixels to the default background color, to instead use the *current* background color. To implement this, a couple of changes are needed: * Sixel pixels always use alpha=1.0, except for *empty* cells when P2=1 (i.e. transparent pixels). * The renderer draws sixels with the OVER operator, instead of the SRC operator. * The renderer *must* now render the cells beneath the sixel. As an optimization, this is only done for sixels where P2=1. I.e. for fully opaque sixels, there’s no need to render the cells beneath. The sixel renderer isn’t yet hooked into the multi-threaded renderer. This means *rows* (not just the cells) beneath maybe-transparent sixels are rendered single-threaded. Closes #391.
* render: jump-labels: case insensitive comparison when looking for matching keysDaniel Eklöf2021-03-04-1/+1
|
* url-mode: snapshot screen state when entering URL modeDaniel Eklöf2021-02-26-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | | Previously, we automatically exited URL mode whenever we received data on the PTY. This was done since we don’t know _what_ has changed on the screen, and we don’t want to display misleading jump labels. However, this becomes a problem in curses-like applications that periodically updates part of the screen. For example, a statusbar with a clock. This patch changes this behavior; instead of cancelling URL mode when receiving PTY data, we snapshot the grid when entering URL mode. When *rendering*, we use the snapshot:ed grid, while PTY updates modify the “real” grid. Snapshot:ing the grid means taking a full/deep copy of the current grid, including sixel images etc. Finally, it isn’t necessary to “damage” the entire view when *entering* URL mode, since we’re at that point the renderer is in sync with the grid. But we *do* need to damage the entire view when exiting URL mode, since the grid changes on the “real” grid hasn’t been tracked by the renderer.
* urls: add key binding that toggles whether URLs are displayed on jump-labelDaniel Eklöf2021-02-21-2/+19
| | | | | | | | | | | | | | | | | By default, the URL isn’t shown on the jump-label. For auto-detect URLs, doing so is virtually always useless, as the URL is already visible in the grid. For OSC-8 URLs however, the URL is often _not_ visible in the grid. Many times, seeing the URL is still not needed (if you’re doing ‘ls --hyperlink’, you already know what the URIs are). But it is still useful to have a way to show the URLs. This patch adds a new key binding action that can be used in url-mode to toggle the URL on and off in the jump label. It is bound to ctrl+t by default.
* urls: remove free-form ‘text’ member from URL structDaniel Eklöf2021-02-21-12/+2
|
* url-mode: multiple URL (parts) with the same ID is assigned a single key sequenceDaniel Eklöf2021-02-21-0/+6
| | | | | | | | | | In case an URL is split up into multiple parts, those parts are now treated as a single URL when it comes to key assignment. Only the *first* URL part is actually assigned a key combo. The other parts are ignored. We still highlight them, but for all other purposes they are ignored.
* wayland: drop ‘_surface’ suffix from subsurface struct instancesDaniel Eklöf2021-02-17-21/+21
|
* render-timer: use wayl_win_subsurface_new/destroy()Daniel Eklöf2021-02-17-2/+3
|
* scrollback-indicator: use wayl_win_subsurface_new/destroy()Daniel Eklöf2021-02-17-34/+9
|
* search: use wayl_win_subsurface_new/destroy()Daniel Eklöf2021-02-17-9/+9
|
* csd: use wayl_win_subsurface_new/destroy()Daniel Eklöf2021-02-17-5/+5
|
* url-mode: convert struct wl_url to use wayl_win_subsurface_new()Daniel Eklöf2021-02-17-2/+2
|
* render: block all signals in the rendering threadsDaniel Eklöf2021-02-11-0/+5
|
* Convert all but 2 remaining uses of xassert(false) to BUG("...")Craig Barnes2021-02-10-2/+2
|
* Convert some more uses of xassert(false) to BUG("...")Craig Barnes2021-02-09-1/+1
|
* Convert some uses of xassert(false) to BUG("some error message")Craig Barnes2021-02-09-3/+2
|
* render: use portable HAS_INCLUDE() wrapper instead of __has_include()Craig Barnes2021-02-09-1/+3
|
* render: urls: blank out keys already pressedDaniel Eklöf2021-02-07-6/+3
|
* render: urls: fix string formatter in swprintf()Daniel Eklöf2021-02-07-1/+1
|
* render: urls: don’t use/allocate maximum allowed characters unless neededDaniel Eklöf2021-02-07-1/+1
|
* render: render_osd(): remove ‘alpha’ parameter - it’s always 0xffffDaniel Eklöf2021-02-07-8/+6
|
* render: urls: reduce vertical marginDaniel Eklöf2021-02-07-5/+6
|
* render: urls: uppercase the activation key sequenceDaniel Eklöf2021-02-07-0/+4
|
* render: urls: add TODO: highlight already entered keysDaniel Eklöf2021-02-07-0/+6
|
* render: urls: don’t display URLs whose key sequence doesn’t matchDaniel Eklöf2021-02-07-1/+10
|
* url-mode: underline URLs using the color from colors.urlsDaniel Eklöf2021-02-07-0/+9
| | | | | | | | | | | | | | | | | | | | | | This is implemented by allocating one of the (few!) remaining bits in the cells’ attribute struct to indicate the cell should be “URL highlighted”. render_cell() looks at this bit and draws an underline using the color from colors.urls (defaults to regular3 - i.e. yellow). A new function, url_tag_cells(), iterates the currently detected URLs and sets the new ‘url’ attribute flag on the affected cells. Note: this is done in a separate function to keep urls_collect() free from as many dependencies as possible. urls_reset() is updated to *clear* the ‘url’ flag (and thus implicitly also results in a grid refresh, _if_ there were any URLs). We now exit URL mode on *any* client application input. This needs to be so since we can’t know if the URLs we previously detected are still valid.
* url-mode: store absolute row numbers in start/end coordinatesDaniel Eklöf2021-02-07-3/+29
| | | | | | | | | | | | | | | | | This allows us to update the jump label positions when the viewport changes. This in turn allows us to stay in URL mode while the user is using the mouse to scroll in the scrollback history. Scrolling with the keyboard is currently not possible, since input handling in URL mode does not recognize “regular” key bindings. We _could_ add scrollback up/down bindings to URL mode too, but lets not, for the time being. (Note: an alternative to this patch is to disallow mouse scrolling too. Then we could have kept the URL start/end as viewport local coordinates).
* config: use a bitfield for flags tracking whether to use custom colors for CSD or notDaniel Eklöf2021-02-07-5/+5
|
* config: add colors.jump_labels and colors.urlsDaniel Eklöf2021-02-07-2/+10
| | | | | | | | | | * colors.jump_labels configures the foreground and background colors used when rendering URL jump labels. Defaults to “regular0 regular3” (i.e. black on yellow). * colors.urls configures the color to use when highlighting URLs in URL mode. Note that we aren’t currently doing any highlighting... Defaults to regular3 (i.e. yellow).
* config: use a packed bitfield for “use custom color” flagsDaniel Eklöf2021-02-07-1/+1
|
* render: urls: tweak positioningDaniel Eklöf2021-02-07-4/+6
| | | | Don’t offset the labels too much vertically, _or_ horizontally.
* render: reduce URL jump label marginsDaniel Eklöf2021-02-07-1/+1
|
* render: url labels: don’t position outside windowDaniel Eklöf2021-02-07-2/+11
|
* render: urls: positioning: place a bit further away from the starting positionDaniel Eklöf2021-02-07-2/+2
|
* urls: initial support for detecting URLs and rendering jump-labelsDaniel Eklöf2021-02-07-26/+97
| | | | The jump labels work, but is currently hardcoded to use xdg-open
* Send text_input_rectangle requests for text-inputTadeo Kondrak2021-01-29-1/+30
|
* config: promote tweak.resize-delay-ms to a real, supported optionDaniel Eklöf2021-01-26-3/+3
|
* render: remove unneeded paranthesesDaniel Eklöf2021-01-26-1/+1
|
* render: don’t center content while doing an interactive resizeDaniel Eklöf2021-01-26-1/+1
|
* render: remove debug loggingDaniel Eklöf2021-01-26-4/+1
|
* render: codespell: tiemout -> timeoutDaniel Eklöf2021-01-26-1/+1
|
* render: delay TIOCSWINSZ while doing an interactive resizeDaniel Eklöf2021-01-26-12/+92
| | | | | | | | | | | | | | | | | | | Instead of disabling content centering, delay the TIOCSWINSZ (a.k.a delay sending the new dimensions to the client) by a small amount while doing an interactive resize. Non-interactive resizes are still immediate. For now, force a resize when the user stops the interactive resize. This ensures the client application receives the new dimensions immediately. It still works without the last, forced, resize, but there typically be a small delay until the client application receives the final dimensions. Closes #301 Closes #283
* render: don’t center content while we’re being resizedDaniel Eklöf2021-01-26-1/+1
| | | | | Doing so causes the content to jump around while interactively resizing the window.
* ime: fix rendering of pre-edit cursor when positioned after the pre-edit stringDaniel Eklöf2021-01-26-1/+12
| | | | | | | | | | | | We failed to convert the byte-indices to cell indices, resulting in a box cursor covering the entire pre-edit string. Note that in addition to fixing the translation from byte index to cell index, the rendered had to be updated to dirty one extra cell from the original grid. Without this, we left trailing cursors behind us when the user deleted text from the pre-edit string.
* search: ad-hoc workaround for combining characters with positive x-offsetsDaniel Eklöf2021-01-26-2/+8
| | | | | | | | | | | | When rendering the search input box, do the same ad-hoc workaround for combining characters with a positive x-offset as we do when rendering normal grid cells. In this case, we don’t *know* when we’re dealing with combining characters. But we can detect zero-width characters. For these, check their glyph’s x-offset. If positive, adjust it like we do when rendering combining glyphs in the main grid, to ensure the glyph is positioned over the _previous_ character, not the next.
* render: set thread name in a portable wayJan Beich2021-01-23-2/+8
| | | | | | | | | | | | | | | | | | prctl is Linux-only but pthread_setname_np is same as PR_SET_NAME. Solaris and FreeBSD >= 13 have pthread_setname_np similar to Linux. DragonFly, OpenBSD, FreeBSD < 13 lack pthread_setname_np but provide pthread_set_name_np which doesn't return a value. NetBSD requires 3 arguments for pthread_setname_np where the last one is void *. render.c:8:10: fatal error: 'sys/prctl.h' file not found #include <sys/prctl.h> ^~~~~~~~~~~~~ render.c:1234:9: error: implicit declaration of function 'prctl' is invalid in C99 [-Werror,-Wimplicit-function-declaration] if (prctl(PR_SET_NAME, proc_title, 0, 0, 0) < 0) ^ render.c:1234:15: error: use of undeclared identifier 'PR_SET_NAME' if (prctl(PR_SET_NAME, proc_title, 0, 0, 0) < 0) ^
* debug: rename assert() to xassert(), to avoid clashing with <assert.h>Craig Barnes2021-01-16-66/+66
|
* config: line-height, letter-spacing: values are in pt by default, but we allow pxDaniel Eklöf2021-01-11-4/+4
| | | | | | | | If the value is specified without a unit, then the value is assumed to be in points, subject to DPI scaling. The value can optionally have a ‘px’ suffix, in which case the value is treated as a raw pixel count.