From 41a8f2fc6556e7b8c9832ede21c6b45f624207cf Mon Sep 17 00:00:00 2001 From: Daniel Eklöf Date: Tue, 10 Aug 2021 18:33:18 +0200 Subject: render: run the “overflowing glyphs” prepass *before* rendering sixels MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This fixes an issue where the left-most column of a sixel was “overwritten” by the cell content. This patch also rewrites the prepass logic, to try to reduce the number of loads performed. The new logic loops each row from left to right, looking for dirty cells. When a dirty cell is found, we first scan backwards, until we find a non-overflowing cell. That cell is unaffected by the overflowing cell we’re currently dealing with. We can also stop as soon as we see a dirty cell, since that cell will already have been dealt with. Then, we scan forward, dirtying cells until we see a non-overflowing cell. That first non-overflowing cell is also dirtied, but after that we break. The last loop, that scans forward, advances the same cell pointer used in the outer loop. --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) (limited to 'CHANGELOG.md') diff --git a/CHANGELOG.md b/CHANGELOG.md index a22e77e2..671fb78b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -74,6 +74,8 @@ scaling factor. * Slow-to-terminate client applications causing other footclient instances to freeze when closing a footclient window. +* Underlying cell content showing through in the left-most column of + sixels. ### Security -- cgit v1.3