From 567a8de3b08392f049b6a2e3ce7d2a5a8ba4e0ed Mon Sep 17 00:00:00 2001 From: Jan Beich Date: Tue, 19 Jan 2021 14:34:30 +0000 Subject: client/server: switch to POSIX header for sockaddr_un client.c:13:10: fatal error: 'linux/un.h' file not found #include ^~~~~~~~~~~~ client.c:195:24: error: variable has incomplete type 'struct sockaddr_un' struct sockaddr_un addr = {.sun_family = AF_UNIX}; ^ client.c:195:12: note: forward declaration of 'struct sockaddr_un' struct sockaddr_un addr = {.sun_family = AF_UNIX}; ^ server.c:11:10: fatal error: 'linux/un.h' file not found #include ^~~~~~~~~~~~ server.c:307:24: error: variable has incomplete type 'struct sockaddr_un' struct sockaddr_un addr; ^ server.c:307:12: note: forward declaration of 'struct sockaddr_un' struct sockaddr_un addr; ^ server.c:347:24: error: variable has incomplete type 'struct sockaddr_un' struct sockaddr_un addr = {.sun_family = AF_UNIX}; ^ server.c:347:12: note: forward declaration of 'struct sockaddr_un' struct sockaddr_un addr = {.sun_family = AF_UNIX}; ^ server.c:394:24: error: variable has incomplete type 'struct sockaddr_un' struct sockaddr_un addr = {.sun_family = AF_UNIX}; ^ server.c:394:12: note: forward declaration of 'struct sockaddr_un' struct sockaddr_un addr = {.sun_family = AF_UNIX}; ^ --- client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'client.c') diff --git a/client.c b/client.c index 80eb8b40..9a347562 100644 --- a/client.c +++ b/client.c @@ -9,7 +9,7 @@ #include #include -#include +#include #define LOG_MODULE "foot-client" #define LOG_ENABLE_DBG 0 -- cgit v1.3 From 0bb928e02fa9ce4ec36cf2f1683e7a4e0c5e09dc Mon Sep 17 00:00:00 2001 From: Daniel Eklöf Date: Thu, 21 Jan 2021 12:15:40 +0100 Subject: client: explicitly use a 64-bit type for ‘total_len’ MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This fixes an out-of-range comparison in 32-bit builds: client.c:289:19: error: result of comparison of constant 4294967296 with expression of type 'size_t' (aka 'unsigned int') is always false [-Werror,-Wtautological-constant-out-of-range-compare] if (total_len >= 1llu << (8 * sizeof(uint32_t)) || ~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ --- client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'client.c') diff --git a/client.c b/client.c index 9a347562..dead7117 100644 --- a/client.c +++ b/client.c @@ -263,7 +263,7 @@ main(int argc, char *const *argv) }; /* Total packet length, not (yet) including argv[] */ - size_t total_len = ( + uint64_t total_len = ( sizeof(data) + cwd_len + term_len + -- cgit v1.3