From 49034bb759edc0d137783844213677d6db074dcb Mon Sep 17 00:00:00 2001 From: Daniel Eklöf Date: Mon, 22 Jul 2019 20:19:27 +0200 Subject: csi: let CSI 0 q mean "switch to user configured cursor style" According to the specs, \E[0 q means a blinking block cursor. However, since it also states that \E[1 q *also* is a blinking block cursor, and that it is the default, *and* given that fact that parameter-less CSIs typically means "reset", let's make it mean "reset to the user configured cursor style". --- csi.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) (limited to 'csi.c') diff --git a/csi.c b/csi.c index 62ab20cd..9487d8b3 100644 --- a/csi.c +++ b/csi.c @@ -929,7 +929,12 @@ csi_dispatch(struct terminal *term, uint8_t final) case 'q': { int param = vt_param_get(term, 0, 0); switch (param) { - case 0: case 1: /* blinking block */ + case 0: + term->cursor_style = term->default_cursor_style; + term->cursor_blinking = false; /* TODO: configurable */ + break; + + case 1: /* blinking block */ case 2: /* steady block */ term->cursor_style = CURSOR_BLOCK; break; @@ -945,7 +950,8 @@ csi_dispatch(struct terminal *term, uint8_t final) break; } - term->cursor_blinking = param == 0 || param & 1; + if (param != 0) + term->cursor_blinking = param & 1; if (term->cursor_blinking) LOG_WARN("unimplemented: blinking cursor"); break; -- cgit v1.3