From 8a5f2915e9d327d1517d1da49ce7e2303fe61d36 Mon Sep 17 00:00:00 2001 From: Daniel Eklöf Date: Mon, 25 Sep 2023 16:37:32 +0200 Subject: dcs: xtgettcap: ignore queries with invalid hex encodings When we receive an XTGETTCAP query, where the capability is not correctly hex encoded, ignore it. Before this patch, we echo:ed it back to the TTY inside an error resonse. --- dcs.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) (limited to 'dcs.c') diff --git a/dcs.c b/dcs.c index 7ce1a868..601f1172 100644 --- a/dcs.c +++ b/dcs.c @@ -111,14 +111,11 @@ static void xtgettcap_reply(struct terminal *term, const char *hex_cap_name, size_t len) { char *name = hex_decode(hex_cap_name, len); - if (name == NULL) - goto err; + if (name == NULL) { + LOG_WARN("XTGETTCAP: invalid hex encoding, ignoring capability"); + return; + } -#if 0 - const struct foot_terminfo_entry *entry = - bsearch(name, terminfo_capabilities, ALEN(terminfo_capabilities), - sizeof(*entry), &terminfo_entry_compar); -#endif const char *value; bool valid_capability = lookup_capability(name, &value); xassert(!valid_capability || value != NULL); -- cgit v1.3