From 9a498038d681e65748b5223d814758a6b7a47693 Mon Sep 17 00:00:00 2001 From: Daniel Eklöf Date: Tue, 24 Nov 2020 19:00:57 +0100 Subject: resize: don’t reflow text on alt screen MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Alt screen applications normally reflow/readjust themselves on a window resize. When we do it too, the result is graphical glitches/flashes since our re-flowed text is rendered in one frame, and the application re-flowed text soon thereafter. We can’t avoid rendering some kind of re-flowed frame, since we don’t know when, or even if, the application will update itself. To avoid glitches, we need to render, as closely as possible, what the application itself will render shortly. This is actually pretty simple; we just need to copy the visible content over from the old grid to the new grid. We don’t bother with text re-flow, but simply truncate long lines. To simplify things, we simply cancel any active selection (since often times, it will be corrupted anyway when the application redraws itself). Since we’re not reflowing text, there’s no need to translate e.g. the cursor position - we just keep the current position (but bounded to the new dimensions). Fun thing: ‘less’ gets corrupted if we don’t leave the cursor at the (new) bottom row. To handle this, we check if the cursor (before resize) is at the bottom row, and if so, we move it to the new bottom row. Closes #221 --- grid.h | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) (limited to 'grid.h') diff --git a/grid.h b/grid.h index cbe60536..1066e28f 100644 --- a/grid.h +++ b/grid.h @@ -6,11 +6,16 @@ void grid_swap_row(struct grid *grid, int row_a, int row_b); struct row *grid_row_alloc(int cols, bool initialize); void grid_row_free(struct row *row); -void grid_reflow( + +void grid_resize_without_reflow( + struct grid *grid, int new_rows, int new_cols, + int old_screen_rows, int new_screen_rows); + +void grid_resize_and_reflow( struct grid *grid, int new_rows, int new_cols, int old_screen_rows, int new_screen_rows, size_t tracking_points_count, - struct coord *const tracking_points[static tracking_points_count], + struct coord *const _tracking_points[static tracking_points_count], size_t compose_count, const struct composed composed[static compose_count]); -- cgit v1.3