From b0bf8ca5f7034f6d95bc3b58082e719a81d99859 Mon Sep 17 00:00:00 2001 From: Daniel Eklöf Date: Fri, 19 Jul 2024 15:04:28 +0200 Subject: osc/notify: add support for OSC-99, kitty desktop notifications This adds limited support for OSC-99, kitty desktop notifications[^1]. We support everything defined by the "protocol", except: * 'a': action to perform on notification activation. Since we don't trigger the notification ourselves (over D-Bus), we don't know a) which ID the notification got, or b) when it is clicked. * ... and that's it. Everything else is supported To be explicit, we *do* support: * Chunked notifications (d=0|1), allowing the application to append data to a notification in chunks, before it's finally displayed. * Plain UTF-8, or base64-encoded UTF-8 payload (e=0|1). * Notification identifier (i=xyz). * Payload type (p=title|body). * When to honor the notification (o=always|unfocused|invisible), with the following quirks: - we don't know when the window is invisible, thus it's treated as 'unfocused'. - the foot option 'notify-focus-inhibit' overrides 'always' * Urgency (u=0|1|2) [^1]: https://sw.kovidgoyal.net/kitty/desktop-notifications/ --- notify.c | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) (limited to 'notify.c') diff --git a/notify.c b/notify.c index 7a208479..09e230a0 100644 --- a/notify.c +++ b/notify.c @@ -12,14 +12,18 @@ #include "log.h" #include "config.h" #include "spawn.h" +#include "terminal.h" #include "xmalloc.h" void -notify_notify(const struct terminal *term, const char *title, const char *body) +notify_notify(const struct terminal *term, const char *title, const char *body, + enum notify_when when, enum notify_urgency urgency) { LOG_DBG("notify: title=\"%s\", msg=\"%s\"", title, body); - if (term->conf->notify_focus_inhibit && term->kbd_focus) { + if ((term->conf->notify_focus_inhibit || when != NOTIFY_ALWAYS) + && term->kbd_focus) + { /* No notifications while we're focused */ return; } @@ -33,10 +37,17 @@ notify_notify(const struct terminal *term, const char *title, const char *body) char **argv = NULL; size_t argc = 0; + const char *urgency_str = + urgency == NOTIFY_URGENCY_LOW + ? "low" + : urgency == NOTIFY_URGENCY_NORMAL + ? "normal" : "critical"; + if (!spawn_expand_template( - &term->conf->notify, 4, - (const char *[]){"app-id", "window-title", "title", "body"}, - (const char *[]){term->app_id ? term->app_id : term->conf->app_id, term->window_title, title, body}, + &term->conf->notify, 5, + (const char *[]){"app-id", "window-title", "title", "body", "urgency"}, + (const char *[]){term->app_id ? term->app_id : term->conf->app_id, + term->window_title, title, body, urgency_str}, &argc, &argv)) { return; -- cgit v1.3