From 1a8ccb0ffaeda73df855fd3fb70a83e718faa9ec Mon Sep 17 00:00:00 2001 From: Daniel Eklöf Date: Sat, 16 May 2020 21:36:08 +0200 Subject: selection/render: sync cells' 'selected' bit before rendering For performance reasons, we track whether a cell is selected or not using a bit in a cell's attributes. This makes it easy for the renderer to determine if the cells should be rendered as selected or not - it just have to look at the 'selected' bit instead of doing a complex range check against the current selection. This works nicely in most cases. But, if the cell is updated, the 'selected' bit is cleared. This results in the renderer rendering the cell normally, i.e. _not_ selected. Checking for this, and re-setting the 'selected' bit when the cell is updated (printed to) is way too expensive as it is in the hot path. Instead, sync the 'selected' bits just before rendering. This isn't so bad as it may sound; if there is no selection this is a no-op. Even if there is a selection, only those cells whose 'selected' bit have been cleared are dirtied (and thus re-rendered) - these cells would have been re-rendered anyway. --- selection.h | 1 + 1 file changed, 1 insertion(+) (limited to 'selection.h') diff --git a/selection.h b/selection.h index adb66821..87d25fc5 100644 --- a/selection.h +++ b/selection.h @@ -13,6 +13,7 @@ void selection_start( struct terminal *term, int col, int row, enum selection_kind kind); void selection_update(struct terminal *term, int col, int row); void selection_finalize(struct terminal *term, uint32_t serial); +void selection_dirty_cells(struct terminal *term); void selection_cancel(struct terminal *term); void selection_extend(struct terminal *term, int col, int row, uint32_t serial); -- cgit v1.3