From 92187d2e4e1980b31ff2aa174d7f917d0945e175 Mon Sep 17 00:00:00 2001 From: Daniel Eklöf Date: Fri, 22 May 2026 11:18:15 +0200 Subject: sixel: clamp max width/height in 'CSI ? 2 ; 3 ; W ; H S' This ensures the user cannot raise the maximum sixel size, where width*height cannot be represented as an integer. Note, we should consider moving all sixel width/height variables from int to size_t. But, since it doesn't make any sense with overly large sixel images, clamping the max width/height is enough. Add a static_assert() that checks SIXEL_MAX_WIDTH * SIXEL_MAX_HEIGHT doesn't overflow. Closes #2343 --- sixel.h | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'sixel.h') diff --git a/sixel.h b/sixel.h index ab8a5050..5c18da1c 100644 --- a/sixel.h +++ b/sixel.h @@ -2,10 +2,14 @@ #include "terminal.h" -#define SIXEL_MAX_COLORS 1024u -#define SIXEL_MAX_WIDTH 10000u +#define SIXEL_MAX_COLORS 1024u +#define SIXEL_MAX_WIDTH 10000u #define SIXEL_MAX_HEIGHT 10000u +static_assert(SIXEL_MAX_WIDTH * SIXEL_MAX_HEIGHT == + (size_t)SIXEL_MAX_WIDTH * SIXEL_MAX_HEIGHT, + "sixel max size triggers integer overflow"); + typedef void (*sixel_put)(struct terminal *term, uint8_t c); void sixel_fini(struct terminal *term); -- cgit v1.3