From a72b2688bda87a20d029e80eaf8d6686ca95003e Mon Sep 17 00:00:00 2001 From: Daniel Eklöf Date: Wed, 2 Jun 2021 17:48:57 +0200 Subject: slave/spawn: restore SIGHUP handler after fork(), before exec() Foot installs a SIG_IGN handler for SIGHUP. Ignored signals are inherited in sub-processes. Thus, we need to restore it to SIG_DFL before exec:ing. --- slave.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'slave.c') diff --git a/slave.c b/slave.c index 6a431d02..8e800214 100644 --- a/slave.c +++ b/slave.c @@ -274,10 +274,12 @@ slave_spawn(int ptmx, int argc, const char *cwd, char *const *argv, _exit(errno_copy); } - /* Restore signal mask */ + /* Restore signal mask, and SIG_IGN'd signals */ sigset_t mask; sigemptyset(&mask); - if (sigprocmask(SIG_SETMASK, &mask, NULL) < 0) { + if (sigprocmask(SIG_SETMASK, &mask, NULL) < 0 || + sigaction(SIGHUP, &(struct sigaction){.sa_handler = SIG_DFL}, NULL) < 0) + { const int errno_copy = errno; LOG_ERRNO_P(errno, "failed to restore signals"); (void)!write(fork_pipe[1], &errno_copy, sizeof(errno_copy)); -- cgit v1.3