From 23cf80667a36aaff1865fc50afab3f98a796cf14 Mon Sep 17 00:00:00 2001 From: Craig Barnes Date: Sat, 12 Feb 2022 12:04:57 +0000 Subject: Explicitly initialize sigaction::sa_mask members with sigemptyset(3) Not doing so before calling sigaction(3) is "undefined" according to POSIX[1]: > Applications shall call either sigemptyset() or sigfillset() at least > once for each object of type sigset_t prior to any other use of that > object. If such an object is not initialized in this way, but is > nonetheless supplied as an argument to any of pthread_sigmask(), > sigaction(), sigaddset(), sigdelset(), sigismember(), sigpending(), > sigprocmask(), sigsuspend(), sigtimedwait(), sigwait(), or > sigwaitinfo(), the results are undefined. The use of designated initializers means that sa_mask members were still being initialized, but sigset_t is an opaque type and implicit initialization doesn't necessarily produce the same results as using sigemptyset(3) (although it typically does on most implementations). [1]: https://pubs.opengroup.org/onlinepubs/9699919799/functions/sigaddset.html --- spawn.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'spawn.c') diff --git a/spawn.c b/spawn.c index d02ab131..8c5c33d2 100644 --- a/spawn.c +++ b/spawn.c @@ -45,7 +45,9 @@ spawn(struct reaper *reaper, const char *cwd, char *const argv[], goto child_err; /* Restore ignored (SIG_IGN) signals */ - if (sigaction(SIGHUP, &(struct sigaction){.sa_handler = SIG_DFL}, NULL) < 0) + struct sigaction dfl = {.sa_handler = SIG_DFL}; + sigemptyset(&dfl.sa_mask); + if (sigaction(SIGHUP, &dfl, NULL) < 0) goto child_err; if (cwd != NULL && chdir(cwd) < 0) { -- cgit v1.3