From 8c50a7afd401686f645fb26676fbcaedb8d4ab62 Mon Sep 17 00:00:00 2001 From: Daniel Eklöf Date: Thu, 25 Nov 2021 19:22:52 +0100 Subject: osc8: update URI ranges as we print data, *not* when the URI is closed MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit At first, an OSC-8 URI range was added when we received the closing OSC-8 escape (i.e. with an empty URI). But, this meant that cursor movements while the OSC-8 escape was in effect wasn’t handled correctly, since we’d add a range that spanned the cursor movements. Attempts were made to handle this in the cursor movement functions, by closing and re-opening the URI. However, there are too many corner cases to make this a viable approach. Scrolling is one such example, line-wrapping another. This patch takes a different approach; emit, or update the URI range when we print to the grid. This models the intended behavior much more closely, where an active OSC-8 URI act like any other SGR attribute - it is applied to all cells printed to, but otherwise have no effect. To avoid killing performance, this is only done in the “generic” printer. This means OSC-8 open/close calls must now “switch” the ASCII printer. Note that the “fast” printer still needs to *erase* pre-existing OSC-8 URIs. Closes #816 --- terminal.h | 1 - 1 file changed, 1 deletion(-) (limited to 'terminal.h') diff --git a/terminal.h b/terminal.h index b0526803..1f3913ae 100644 --- a/terminal.h +++ b/terminal.h @@ -185,7 +185,6 @@ struct vt { struct { uint64_t id; char *uri; - struct coord begin; } osc8; struct { -- cgit v1.3