From 4bad85b59334467ac839ed2dd91abb6625bc5b89 Mon Sep 17 00:00:00 2001 From: Daniel Eklöf Date: Sun, 7 Feb 2021 14:52:04 +0100 Subject: misc: when free:ing tll lists, prefer tll_remove() over tll_free() In many places we have the following pattern: tll_foreach(list, it) free(it->item.thing); tll_free(list); Since all tll functions are macros, and thus inlined, and since tll_free in itself expands to a tll_foreach(), the above pattern expands to more native code than necessary. This is somewhat smaller: tll_foreach(list, it) { free(it->item.thing); tll_remove(list, it); } --- url-mode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'url-mode.c') diff --git a/url-mode.c b/url-mode.c index 40f3372f..df870677 100644 --- a/url-mode.c +++ b/url-mode.c @@ -540,15 +540,15 @@ urls_reset(struct terminal *term) wl_subsurface_destroy(it->item.sub_surf); if (it->item.surf != NULL) wl_surface_destroy(it->item.surf); + tll_remove(term->window->urls, it); } - tll_free(term->window->urls); } tll_foreach(term->urls, it) { tag_cells_for_url(term, &it->item, false); url_destroy(&it->item); + tll_remove(term->urls, it); } - tll_free(term->urls); memset(term->url_keys, 0, sizeof(term->url_keys)); render_refresh(term); -- cgit v1.3