diff options
| author | Xiretza <xiretza@xiretza.xyz> | 2021-11-19 15:51:52 +0000 |
|---|---|---|
| committer | Xiretza <xiretza@xiretza.xyz> | 2021-11-20 10:58:44 +0000 |
| commit | 02bb2768f176164099a30b74504c86e1accb7bb1 (patch) | |
| tree | bd25f4e58c6538360f1f116d0449c7a41c03544e | |
| parent | Merge branch 'letter-spacing-regression' (diff) | |
config: Remove some "UNREACHABLE" UB footguns
Every branch of these long if/else if/else chains returns, so the
compiler can figure out on its own that the last line is never reached.
If, for some reason, one of the branches does not return (as was the
case after 205f1f7, fixed by b22322b), this would usually result in a compiler
error ("control reaches end of non-void function"), but adding UNREACHABLE
transforms this into silent undefined behaviour.
| -rw-r--r-- | config.c | 4 |
1 files changed, 0 insertions, 4 deletions
@@ -1012,8 +1012,6 @@ parse_section_main(struct context *ctx) LOG_CONTEXTUAL_ERR("not a valid option: %s", key); return false; } - - UNREACHABLE(); } static bool @@ -2340,8 +2338,6 @@ parse_section_tweak(struct context *ctx) LOG_CONTEXTUAL_ERR("not a valid option: %s", key); return false; } - - UNREACHABLE(); } static bool |
