aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Eklöf <daniel@ekloef.se>2021-06-19 13:56:39 +0000
committerDaniel Eklöf <daniel@ekloef.se>2021-06-19 13:56:39 +0000
commit1a755d0da2075ba0cccaaacd616f31eec697b08a (patch)
tree70cd029435745974836c3db86bce01e9b22eb814
parentterm: fix regression after merging #599 (diff)
uri: hostname_is_localhost(): don’t crash if hostname == NULL
-rw-r--r--CHANGELOG.md1
-rw-r--r--uri.c7
2 files changed, 5 insertions, 3 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 6ea8eec3..0fb4c8e6 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -186,6 +186,7 @@
_compose_ definitions.
* Window title not being updated while window is hidden
(https://codeberg.org/dnkl/foot/issues/591).
+* Crash on badly formatted URIs in e.g. OSC-8 URLs.
### Security
diff --git a/uri.c b/uri.c
index 51cd8093..e747991d 100644
--- a/uri.c
+++ b/uri.c
@@ -270,7 +270,8 @@ hostname_is_localhost(const char *hostname)
if (gethostname(this_host, sizeof(this_host)) < 0)
this_host[0] = '\0';
- return (strcmp(hostname, "") == 0 ||
- strcmp(hostname, "localhost") == 0 ||
- strcmp(hostname, this_host) == 0);
+ return (hostname != NULL && (
+ strcmp(hostname, "") == 0 ||
+ strcmp(hostname, "localhost") == 0 ||
+ strcmp(hostname, this_host) == 0));
}