aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Eklöf <daniel@ekloef.se>2020-10-22 16:41:47 +0000
committerDaniel Eklöf <daniel@ekloef.se>2020-10-22 16:41:47 +0000
commit4283e96865e79977f446b762733da47c829301bb (patch)
treef045a47bfef8c8b4c228cc95dc50b799c6b6f1b3
parentMerge branch 'custom-bold-italic-fonts' (diff)
render: blink switches between foreground and dimmed foreground
-rw-r--r--CHANGELOG.md5
-rw-r--r--render.c6
2 files changed, 8 insertions, 3 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index b5e7a719..a0cb347f 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -48,6 +48,11 @@
### Changed
+
+* Blinking text now uses the foreground color, but dimmed down in its
+ off state, instead of the background color.
+
+
### Deprecated
### Removed
### Fixed
diff --git a/render.c b/render.c
index 2d15fb81..fa9a967b 100644
--- a/render.c
+++ b/render.c
@@ -399,9 +399,6 @@ render_cell(struct terminal *term, pixman_image_t *pix,
}
}
- if (cell->attrs.blink && term->blink.state == BLINK_OFF)
- _fg = _bg;
-
pixman_color_t fg = color_hex_to_pixman(_fg);
pixman_color_t bg = color_hex_to_pixman_with_alpha(
_bg,
@@ -411,6 +408,9 @@ render_cell(struct terminal *term, pixman_image_t *pix,
if (cell->attrs.dim)
color_dim(&fg);
+ if (cell->attrs.blink && term->blink.state == BLINK_OFF)
+ color_dim(&fg);
+
if (term->is_searching && !is_selected) {
color_dim_for_search(&fg);
color_dim_for_search(&bg);