aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Eklöf <daniel@ekloef.se>2025-01-27 05:34:20 +0000
committerDaniel Eklöf <daniel@ekloef.se>2025-01-27 05:34:20 +0000
commit43206e66016175407abd11c415c7135c293a0c50 (patch)
tree61e18e113b5dde9254afc45fc8701eb60b96f2d2
parentrender: resize: configure with only one dimension being zero (diff)
config: fix memory leak on e.g. "not a valid XKB key name" errors
-rw-r--r--config.c9
1 files changed, 4 insertions, 5 deletions
diff --git a/config.c b/config.c
index a0d32869..12336e3d 100644
--- a/config.c
+++ b/config.c
@@ -1928,7 +1928,8 @@ value_to_key_combos(struct context *ctx, int action,
if (idx == 0) {
LOG_CONTEXTUAL_ERR(
"empty binding not allowed (set to 'none' to unmap)");
- goto err;
+ free(copy);
+ return false;
}
remove_from_key_bindings_list(bindings, action, aux);
@@ -1946,10 +1947,8 @@ value_to_key_combos(struct context *ctx, int action,
return true;
err:
- if (idx > 0) {
- for (size_t i = 0; i < used_combos; i++)
- free_key_binding(&new_combos[i]);
- }
+ for (size_t i = 0; i < used_combos; i++)
+ free_key_binding(&new_combos[i]);
free(copy);
return false;
}