aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Eklöf <daniel@ekloef.se>2020-08-11 08:44:27 +0000
committerDaniel Eklöf <daniel@ekloef.se>2020-08-14 05:38:56 +0000
commit517d13fbce3ae56f154343671c325c000a7de040 (patch)
tree56fb4766ebf26c2a9e5819d438fc1a8017db0371
parentinput: mouse-bindings: check selection is enabled/possible and that pointer is on grid (diff)
config: don't allow Shift in mouse bindings
Shift is a special modifier that is used to enable selection when the client application is grabbing the mouse.
-rw-r--r--config.c5
-rw-r--r--doc/footrc.5.scd4
2 files changed, 9 insertions, 0 deletions
diff --git a/config.c b/config.c
index d46b5f8e..40a7e81b 100644
--- a/config.c
+++ b/config.c
@@ -1026,6 +1026,11 @@ parse_mouse_combos(struct config *conf, const char *combos, key_combo_list_t *ke
*key = '\0';
if (!parse_modifiers(conf, combo, key - combo, &modifiers, path, lineno))
goto err;
+ if (modifiers.shift) {
+ LOG_AND_NOTIFY_ERR("%s:%d: Shift cannot be used in mosue bindings",
+ path, lineno);
+ goto err;
+ }
key++; /* Skip past the '+' */
}
diff --git a/doc/footrc.5.scd b/doc/footrc.5.scd
index 64f9c500..d5ea808d 100644
--- a/doc/footrc.5.scd
+++ b/doc/footrc.5.scd
@@ -369,6 +369,10 @@ of the modifiers *must* be valid XKB key names, and the button name
*must* be a valid libinput name. You can find the button names using
*libinput debug-events*.
+Note that *Shift* cannot be used as a modifier in mouse bindings since
+it is used to enable selection when the client application is grabbing
+the mouse.
+
The trailing *COUNT* is optional and specifies the click count
required to trigger the binding. The default if *COUNT* is omitted is
_1_.