aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Eklöf <daniel@ekloef.se>2023-07-19 14:34:42 +0000
committerDaniel Eklöf <daniel@ekloef.se>2023-07-19 14:42:41 +0000
commit899b768b744c74e88e54e6d8eb32f53accea79d8 (patch)
treec575ff07d5209c25ec53ebe86c3b8bf1c4eec9b9
parentchangelog: spelling: sacling -> scaling (diff)
render: disable transparency when we’re fullscreened
The wayland protocol recommends (or mandates?) that compositors render a black background behind fullscreened transparent windows. I.e. you never see what’s _actually_ behind the window. So, if you have a white, but semi-transparent background in foot, it’ll be rendered in a shade of gray. Given this, it’s better to simply disable transparency while we’re fullscreened. That way, we at least get the "correct" background color. Closes #1416
-rw-r--r--CHANGELOG.md3
-rw-r--r--render.c31
2 files changed, 32 insertions, 2 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5e051081..9958e293 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -51,8 +51,11 @@
configuration) from the monitor we were most recently mapped on,
instead of the one least recently.
* Starlight theme (the default theme) updated to [V4][starlight-v4]
+* Background transparency (alpha) is now disabled in fullscreened
+ windows ([#1416][1416]).
[starlight-v4]: https://github.com/CosmicToast/starlight/blob/v4/CHANGELOG.md#v4
+[1416]: https://codeberg.org/dnkl/foot/issues/1416
### Deprecated
diff --git a/render.c b/render.c
index 11149b16..7d7c6348 100644
--- a/render.c
+++ b/render.c
@@ -526,8 +526,35 @@ render_cell(struct terminal *term, pixman_image_t *pix,
uint32_t swap = _fg;
_fg = _bg;
_bg = swap;
- } else if (cell->attrs.bg_src == COLOR_DEFAULT)
- alpha = term->colors.alpha;
+ }
+
+ else if (cell->attrs.bg_src == COLOR_DEFAULT) {
+ if (term->window->is_fullscreen) {
+ /*
+ * Note: disable transparency when fullscreened.
+ *
+ * This is because the wayland protocol recommends
+ * (mandates even?) the compositor render a black
+ * background behind fullscreened transparent windows.
+ *
+ * In other words, transparency does not work when
+ * fullscreened, in the sense that you don't see
+ * what's behind the window.
+ *
+ * And if we keep our alpha channel, the background
+ * color will just look weird. For example, if the
+ * background color is white, and alpha is 0.5, then
+ * the window will be drawn in a shade of gray while
+ * fullscreened.
+ *
+ * By disabling the alpha channel, the window will at
+ * least be rendered in the intended background color.
+ */
+ xassert(alpha == 0xffff);
+ } else {
+ alpha = term->colors.alpha;
+ }
+ }
}
if (unlikely(is_selected && _fg == _bg)) {