diff options
| author | Daniel Eklöf <daniel@ekloef.se> | 2021-07-14 18:14:10 +0000 |
|---|---|---|
| committer | Daniel Eklöf <daniel@ekloef.se> | 2021-07-14 18:14:10 +0000 |
| commit | 9658e9cc18cd671d6016479280796510e42b23a4 (patch) | |
| tree | be8c96413caada7f350902b2ee50bb89d331a9db | |
| parent | Revert "render: don’t assume PIXMAN_a8r8g8b8 for color glyphs" (diff) | |
render: tiocswinsz: don’t remove/close the fd passed as argument
There’s a chance the resize timeout FD was closed, and *reused*, after
epoll() told us the FD is readable, but before our callback runs.
Thus, closing the FD provided as an argument is dangerous, as it may
refer to something completely different.
| -rw-r--r-- | render.c | 6 |
1 files changed, 4 insertions, 2 deletions
@@ -3119,8 +3119,10 @@ fdm_tiocswinsz(struct fdm *fdm, int fd, int events, void *data) if (events & EPOLLIN) tiocswinsz(term); - fdm_del(fdm, fd); - term->window->resize_timeout_fd = -1; + if (term->window->resize_timeout_fd >= 0) { + fdm_del(fdm, term->window->resize_timeout_fd); + term->window->resize_timeout_fd = -1; + } return true; } |
