aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Eklöf <daniel@ekloef.se>2021-11-15 18:22:06 +0000
committerDaniel Eklöf <daniel@ekloef.se>2021-11-15 18:22:06 +0000
commitb22322bfd104949b93d1df22ff36689747917448 (patch)
tree3222e69507708983e216824cd0531dc34c8c5006
parentMerge branch 'footclient-xdg-desktop' (diff)
config: letter-spacing: add missing ‘return’
The missing return caused us to fall through to the bottom of the function, where we ended with an error message: [main].letter-spacing: 0: not a valid option: letter-spacing Closes #795
-rw-r--r--CHANGELOG.md5
-rw-r--r--config.c2
2 files changed, 6 insertions, 1 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index ca4d8a7d..b65f0b63 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -46,6 +46,11 @@
### Deprecated
### Removed
### Fixed
+
+* Regression: `letter-spacing` resulting in a “not a valid option”
+ error (https://codeberg.org/dnkl/foot/issues/795).
+
+
### Security
### Contributors
diff --git a/config.c b/config.c
index 905f26d6..2f12e201 100644
--- a/config.c
+++ b/config.c
@@ -956,7 +956,7 @@ parse_section_main(struct context *ctx)
return value_to_pt_or_px(ctx, &conf->line_height);
else if (strcmp(key, "letter-spacing") == 0)
- value_to_pt_or_px(ctx, &conf->letter_spacing);
+ return value_to_pt_or_px(ctx, &conf->letter_spacing);
else if (strcmp(key, "horizontal-letter-offset") == 0)
return value_to_pt_or_px(ctx, &conf->horizontal_letter_offset);