diff options
| author | Daniel Eklöf <daniel@ekloef.se> | 2021-01-16 11:27:58 +0000 |
|---|---|---|
| committer | Daniel Eklöf <daniel@ekloef.se> | 2021-01-21 10:58:07 +0000 |
| commit | b2a3cdb7230e0740dc1e476f1e0a6c6b62302836 (patch) | |
| tree | 5e58fa24c8237657aa730bc15e7daee49721c0e9 | |
| parent | Add xsnprintf() and remove some unnecessary strlen(3) calls (diff) | |
input: don’t enable keyboard repeat timer when repeat rate is zero
wayland-client-protocol.h:
Negative values for either rate or delay are illegal. A rate of
zero will disable any repeating (regardless of the value of
delay).
This fixes a division-by-zero crash.
| -rw-r--r-- | CHANGELOG.md | 1 | ||||
| -rw-r--r-- | input.c | 3 |
2 files changed, 4 insertions, 0 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md index 8acc6666..ff7e943a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -54,6 +54,7 @@ (https://codeberg.org/dnkl/foot/issues/291). * Sixel “current geometry” query response not being bounded by the current window dimensions (fixes `lsix` output) +* Crash on keyboard input when repeat rate was zero (i.e. no repeat). ### Security @@ -569,6 +569,9 @@ start_repeater(struct seat *seat, uint32_t key) if (seat->kbd.repeat.dont_re_repeat) return true; + if (seat->kbd.repeat.rate == 0) + return true; + struct itimerspec t = { .it_value = {.tv_sec = 0, .tv_nsec = seat->kbd.repeat.delay * 1000000}, .it_interval = {.tv_sec = 0, .tv_nsec = 1000000000 / seat->kbd.repeat.rate}, |
