diff options
| author | Daniel Eklöf <daniel@ekloef.se> | 2021-08-17 16:31:42 +0000 |
|---|---|---|
| committer | Daniel Eklöf <daniel@ekloef.se> | 2021-08-17 16:31:42 +0000 |
| commit | b4402a6aa5228d8428ab7129bdfc07f94ed5bc03 (patch) | |
| tree | 76aac779bba85d1a65a7a5c80b4a5fcf20c9105e | |
| parent | Merge branch 'selection-modify-only-use-one-cell-bit' (diff) | |
term: check visual-focus, not kbd-focus when enabling/disabling cursor blink
term_cursor_blink_update() is called when the visual focus changes
state (i.e. when our top-level surface is activated de-activated).
Checking keyboard focus worked on Sway, but on e.g. GNOME, the order
in which keyboard focus and visual focus are updated is different, and
we ended up either making the cursor invisible, or visible, but not
blinking, when changing focus back to the window.
Closes #686
| -rw-r--r-- | CHANGELOG.md | 3 | ||||
| -rw-r--r-- | terminal.c | 4 |
2 files changed, 5 insertions, 2 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md index 8e78f7aa..da164b8a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -93,6 +93,9 @@ freeze when closing a footclient window. * Underlying cell content showing through in the left-most column of sixels. +* Blinking cursor stops blinking, or becoming invisible, when + switching focus from, and then back to a terminal window on GNOME + (https://codeberg.org/dnkl/foot/issues/686). ### Security @@ -2456,11 +2456,11 @@ void term_cursor_blink_update(struct terminal *term) { bool enable = term->cursor_blink.decset || term->cursor_blink.deccsusr; - bool activate = !term->shutdown.in_progress && enable && term->kbd_focus; + bool activate = !term->shutdown.in_progress && enable && term->visual_focus; LOG_DBG("decset=%d, deccsrusr=%d, focus=%d, shutting-down=%d, enable=%d, activate=%d", term->cursor_blink.decset, term->cursor_blink.deccsusr, - term->kbd_focus, term->shutdown.in_progress, + term->visual_focus, term->shutdown.in_progress, enable, activate); if (activate && term->cursor_blink.fd < 0) { |
