aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Eklöf <daniel@ekloef.se>2024-07-23 10:15:29 +0000
committerDaniel Eklöf <daniel@ekloef.se>2024-07-23 10:15:29 +0000
commitd0a542515549a71fa2fb7456326ab99c378d929a (patch)
tree9d230d3665cf80992d6521fc474ce2697ac85531
parentnotify: clean up logging messages (diff)
notify: add_icon(): check return value of write()
-rw-r--r--notify.c11
1 files changed, 7 insertions, 4 deletions
diff --git a/notify.c b/notify.c
index 9a9311ee..f8c2bfe1 100644
--- a/notify.c
+++ b/notify.c
@@ -303,11 +303,14 @@ add_icon(struct notification_icon *icon, const char *id, const char *symbolic_na
return;
}
- write(fd, data, data_sz);
- close(fd);
+ if (write(fd, data, data_sz) != (ssize_t)data_sz) {
+ LOG_ERRNO("failed to write icon data to temporary file");
+ } else {
+ LOG_DBG("wrote icon data to %s", name);
+ icon->tmp_file_on_disk = xstrdup(name);
+ }
- LOG_DBG("wrote icon data to %s", name);
- icon->tmp_file_on_disk = xstrdup(name);
+ close(fd);
}
LOG_DBG("added icon to cache: ID=%s: sym=%s, file=%s",