diff options
| author | Daniel Eklöf <daniel@ekloef.se> | 2021-10-16 14:58:59 +0000 |
|---|---|---|
| committer | Daniel Eklöf <daniel@ekloef.se> | 2021-10-16 14:58:59 +0000 |
| commit | d4b365b55c98ab1cccc2c08677ced04cd5438327 (patch) | |
| tree | 86977444848da78697dc426a07aeb16c74bcccbe | |
| parent | doc: foot.1: reporting bugs: move “search existing issues” (diff) | |
pgo: full-inner: add --override tweak.grapheme-shaping=no
Grapheme shaping is now enabled by default in foot. However, when
generating the profiling data in PGO builds, this results in skewed
optimizations.
The end result is worse benchmark results regardless of whether
grapheme-shaping is enabled or not (when running the benchmarks).
| -rw-r--r-- | CHANGELOG.md | 2 | ||||
| -rw-r--r-- | INSTALL.md | 6 | ||||
| -rwxr-xr-x | pgo/full-inner.sh | 1 |
3 files changed, 8 insertions, 1 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md index 3c5f0135..c445a445 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -47,6 +47,8 @@ itself, and fcft has been compiled with support for it. * Default value of `[tweak].grapheme-width-method` changed from `double-width` to `wcswidth`. +* INSTALL.md: `--override tweak.grapheme-shaping=no` added to PGO + command line. ### Deprecated @@ -398,7 +398,11 @@ We will use the script `scripts/generate-alt-random-writes.py`: ```sh ./footclient --version foot_tmp_file=$(mktemp) -./foot --config=/dev/null --term=xterm sh -c "<path-to-generate-alt-random-writes.py> --scroll --scroll-region --colors-regular --colors-bright --colors-256 --colors-rgb --attr-bold --attr-italic --attr-underline --sixel ${foot_tmp_file} && cat ${foot_tmp_file}" +./foot \ + --config=/dev/null \ + --override tweak.grapheme-shaping=no \ + --term=xterm \ + sh -c "<path-to-generate-alt-random-writes.py> --scroll --scroll-region --colors-regular --colors-bright --colors-256 --colors-rgb --attr-bold --attr-italic --attr-underline --sixel ${foot_tmp_file} && cat ${foot_tmp_file}" rm ${foot_tmp_file} ``` diff --git a/pgo/full-inner.sh b/pgo/full-inner.sh index e6168081..599d6aad 100755 --- a/pgo/full-inner.sh +++ b/pgo/full-inner.sh @@ -18,6 +18,7 @@ cd "${blddir}" "${blddir}"/footclient --version "${blddir}"/foot \ --config=/dev/null \ + --override tweak.grapheme-shaping=no \ --term=xterm \ sh -c " set -eux |
