aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Eklöf <daniel@ekloef.se>2019-08-03 19:30:06 +0000
committerDaniel Eklöf <daniel@ekloef.se>2019-08-03 19:30:06 +0000
commite2229c7e2eeb1b0245cc2c7b9c9188f95867e344 (patch)
treee46d31d76144bef98beb4aef4376e276bcbcf90f
parentterm: cell erase: reset *all* attributes *except* background (diff)
osc: bug: uneven clipboard bytes where not buffered correctly
When responding to a OSC 52 clipboard request, we need to base64 encode the clipboard data. This is done in, potentially, several calls. Since we need at least 3 bytes to be able to produce any base64 output, we may have to buffer up to 2 bytes between the callback calls with clipboard data. This was being done incorrectly, where both bytes were written to index 0 in the buffer.
-rw-r--r--osc.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/osc.c b/osc.c
index 2381f35c..16a1d1b8 100644
--- a/osc.c
+++ b/osc.c
@@ -111,10 +111,12 @@ from_clipboard_cb(const char *text, size_t size, void *user)
if (left == 0)
return;
+ assert(ctx->idx == 0);
+
int remaining = left % 3;
for (int i = remaining; i > 0; i--)
- ctx->buf[0] = text[size - i];
- ctx->idx = remaining;
+ ctx->buf[ctx->idx++] = text[size - i];
+ assert(ctx->idx == remaining);
char *chunk = base64_encode((const uint8_t *)t, left / 3 * 3);
assert(chunk != NULL);