aboutsummaryrefslogtreecommitdiff
path: root/CHANGELOG.md
diff options
context:
space:
mode:
authorDaniel Eklöf <daniel@ekloef.se>2020-05-16 19:09:59 +0000
committerDaniel Eklöf <daniel@ekloef.se>2020-05-16 19:16:11 +0000
commite4a2d41f51785452ccb0bdb24ac5577203ff0da3 (patch)
treed051ad20558ba14b3d821a9158d7fd54541489be /CHANGELOG.md
parentselection: on_row_in_view() -> on_rows_in_view(), and now takes a range (diff)
selection: don't automatically no-op operations if selection isn't enabled
When the client is capturing the mouse, selection can only be done by holding done shift. This is why a lot of selection functions are no-ops if selection isn't currently enabled. However, there are many cases where we actually need to modify the selection. In particular, selection_cancel(). Thus, only check for enabled selection when we're dealing with user input. Bonus: this also fixes a bug where an ongoing selection were finalized as soon as the user released shift, even if he was still holding down the mouse button.
Diffstat (limited to 'CHANGELOG.md')
-rw-r--r--CHANGELOG.md8
1 files changed, 8 insertions, 0 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index bce49494..c10c01d9 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -24,6 +24,14 @@
### Deprecated
### Removed
### Fixed
+
+* Do not stop an ongoing selection when `shift` is released. When the
+ client application is capturing mouse events, one must hold down
+ `shift` to start a selection. This selection is now finalized only
+ when the mouse button is released - not as soon as `shift` is
+ released.
+
+
### Security