aboutsummaryrefslogtreecommitdiff
path: root/csi.c
diff options
context:
space:
mode:
authorDaniel Eklöf <daniel@ekloef.se>2022-07-22 08:44:33 +0000
committerDaniel Eklöf <daniel@ekloef.se>2022-07-22 08:44:33 +0000
commit87e4004960265494fcab21c71fff48b4f8b0af33 (patch)
treeb463c9e31ad43b47fec8ae07cfee91c59cc43e00 /csi.c
parentgrid: reflow: require col count > 0 when skipping line truncation (diff)
csi: clamp color index for ‘CSI 38/48 ; 5 ; idx m’ sequences
Indexed color values are stored in the cell attributes as color indices (into the 256-color table). However, the index from the CSI was not validated in any way, meaning you can do something like this: echo -e ‘\e[38:5:1024m CRASH \e[m’ and foot will crash on an out-of-bounds access. Fix by clamping the color index. Closes #1111
Diffstat (limited to 'csi.c')
-rw-r--r--csi.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/csi.c b/csi.c
index 57cae6b3..659839f0 100644
--- a/csi.c
+++ b/csi.c
@@ -128,7 +128,8 @@ csi_sgr(struct terminal *term)
term->vt.params.v[i + 1].value == 5)
{
src = COLOR_BASE256;
- color = term->vt.params.v[i + 2].value;
+ color = min(term->vt.params.v[i + 2].value,
+ ALEN(term->colors.table) - 1);
i += 2;
}
@@ -149,7 +150,8 @@ csi_sgr(struct terminal *term)
term->vt.params.v[i].sub.value[0] == 5)
{
src = COLOR_BASE256;
- color = term->vt.params.v[i].sub.value[1];
+ color = min(term->vt.params.v[i].sub.value[1],
+ ALEN(term->colors.table) - 1);
}
/*