diff options
| author | Daniel Eklöf <daniel@ekloef.se> | 2022-03-19 17:59:15 +0000 |
|---|---|---|
| committer | Daniel Eklöf <daniel@ekloef.se> | 2022-03-20 12:29:29 +0000 |
| commit | 1e63dddb89a27de702fced65d7b6ba3b39812bb9 (patch) | |
| tree | a8d05fbefb5cd35d977df06c4b8a197d516f2011 /input.c | |
| parent | char32: only include stdc-predef.h if it is available (diff) | |
input: don’t allow non-significant modifiers when matching untranslated symbols
When matching “untranslated” bindings (by matching the base symbol of
the key, e.g. ctrl+shift+2 in US layout), require that no
non-significant modifiers are active.
This fixes an issue where AltGr was “ignored”, and would cause certain
combinations to match a key binding.
Example: ctrl+altgr+0, on many European layouts matched against the
default ctrl+0 (reset the font size), instead of emitting ^]
To make this work, we now need to filter out “locked”
modifiers (e.g. NumLock and CapsLock). Otherwise having e.g. NumLock
active would prevent *all* untranslated matching to fail.
Closes #983
Diffstat (limited to 'input.c')
| -rw-r--r-- | input.c | 19 |
1 files changed, 14 insertions, 5 deletions
@@ -1030,6 +1030,12 @@ get_current_modifiers(const struct seat *seat, } } +static xkb_mod_mask_t +get_locked_modifiers(const struct seat *seat) +{ + return xkb_state_serialize_mods(seat->kbd.xkb_state, XKB_STATE_MODS_LOCKED); +} + struct kbd_ctx { xkb_layout_index_t layout; xkb_keycode_t key; @@ -1488,8 +1494,11 @@ key_press_release(struct seat *seat, struct terminal *term, uint32_t serial, xkb_mod_mask_t mods, consumed; get_current_modifiers(seat, &mods, &consumed, key); - xkb_mod_mask_t bind_mods = mods & seat->kbd.bind_significant; - xkb_mod_mask_t bind_consumed = consumed & seat->kbd.bind_significant; + const xkb_mod_mask_t locked = get_locked_modifiers(seat); + const xkb_mod_mask_t bind_mods + = mods & seat->kbd.bind_significant & ~locked; + const xkb_mod_mask_t bind_consumed = + consumed & seat->kbd.bind_significant & ~locked; xkb_layout_index_t layout_idx = xkb_state_key_get_layout(seat->kbd.xkb_state, key); @@ -1504,7 +1513,7 @@ key_press_release(struct seat *seat, struct terminal *term, uint32_t serial, start_repeater(seat, key); search_input( - seat, term, key, sym, bind_mods, bind_consumed, + seat, term, key, sym, mods, consumed, locked, raw_syms, raw_count, serial); return; } @@ -1514,7 +1523,7 @@ key_press_release(struct seat *seat, struct terminal *term, uint32_t serial, start_repeater(seat, key); urls_input( - seat, term, key, sym, bind_mods, bind_consumed, + seat, term, key, sym, mods, consumed, locked, raw_syms, raw_count, serial); return; } @@ -1553,7 +1562,7 @@ key_press_release(struct seat *seat, struct terminal *term, uint32_t serial, goto maybe_repeat; } - if (bind->mods != bind_mods) + if (bind->mods != bind_mods || bind_mods != (mods & ~locked)) continue; /* Match untranslated symbols */ |
