aboutsummaryrefslogtreecommitdiff
path: root/input.c
diff options
context:
space:
mode:
authorDaniel Eklöf <daniel@ekloef.se>2021-01-04 17:32:00 +0000
committerDaniel Eklöf <daniel@ekloef.se>2021-01-04 17:32:00 +0000
commit9d8ca321d6913c2dd084f683e2845f9b4ad7ca66 (patch)
treeb0119bb7df1d2c12af9a0f5188b84a4b389d180d /input.c
parentMerge branch 'hex2nibble' (diff)
input: don’t assert when receiving a button release without a press event
Diffstat (limited to 'input.c')
-rw-r--r--input.c21
1 files changed, 20 insertions, 1 deletions
diff --git a/input.c b/input.c
index b1154e9f..fe9e143a 100644
--- a/input.c
+++ b/input.c
@@ -1537,6 +1537,11 @@ wl_pointer_button(void *data, struct wl_pointer *wl_pointer,
assert(it->item.button != button);
#endif
+ /*
+ * Remember which surface "owns" this button, so that we can
+ * send motion and button release events to that surface, even
+ * if the pointer is no longer over it.
+ */
tll_push_back(
seat->mouse.buttons,
((struct button_tracker){
@@ -1559,7 +1564,21 @@ wl_pointer_button(void *data, struct wl_pointer *wl_pointer,
break;
}
}
- assert(have_button);
+
+ if (!have_button) {
+ /*
+ * Seen on Sway with slurp
+ *
+ * 1. Run slurp
+ * 2. Press, and hold left mouse button
+ * 3. Press escape, to cancel slurp
+ * 4. Release mouse button
+ * 5. BAM!
+ */
+ LOG_WARN("stray button release event");
+ return;
+ }
+
seat->mouse.last_released_button = button;
}