diff options
| author | Daniel Eklöf <daniel@ekloef.se> | 2025-01-09 06:55:29 +0000 |
|---|---|---|
| committer | Daniel Eklöf <daniel@ekloef.se> | 2025-01-09 06:55:29 +0000 |
| commit | 20466e7fa49a454a56cdb204cd70c06b442183ad (patch) | |
| tree | 66edfcf809618df064f6a30d1c18b4946fc5002b /render.c | |
| parent | Merge branch 'ignore-title-and-app-id-report-queries' (diff) | |
| parent | Revert "config: don't allow colors.flash-alpha to be 1.0" (diff) | |
Merge branch 'opaque-flash'
Diffstat (limited to 'render.c')
| -rw-r--r-- | render.c | 23 |
1 files changed, 1 insertions, 22 deletions
@@ -1862,7 +1862,7 @@ render_overlay_single_pixel(struct terminal *term, enum overlay_style style, } } -static void +void render_overlay(struct terminal *term) { struct wayl_sub_surface *overlay = &term->window->overlay; @@ -1898,27 +1898,6 @@ render_overlay(struct terminal *term) break; case OVERLAY_FLASH: - /* - * A compositor will not send a frame callback for our main - * window if it is fully occluded (for example, by a fully - * opaque overlay...). This causes the overlay to stuck. - * - * For regular buffers, it _should_ be enough to *not* hint - * the compositor it's opaque. But at least some compositor - * special cases single-pixel buffers, and actually look at - * their pixel value. - * - * Thus, we have two options: implement frame callback - * handling for the overlay sub-surface, or ensure we don't - * use a fully opaque surface. Since no overlays are fully - * opaque by default, and the flash surface is the only one - * that can be configured to be opaque (colors.flash-alpha), - * and since adding frame callback handling adds a lot of - * boilerplate code... let's go with the simpler solution of - * not allowing colors.flash-alpha to be 1.0. - */ - xassert(term->conf->colors.flash_alpha != 0xffff); - color = color_hex_to_pixman_with_alpha( term->conf->colors.flash, term->conf->colors.flash_alpha); |
