aboutsummaryrefslogtreecommitdiff
path: root/render.c
diff options
context:
space:
mode:
authorDaniel Eklöf <daniel@ekloef.se>2025-01-02 08:08:24 +0000
committerDaniel Eklöf <daniel@ekloef.se>2025-01-02 08:10:51 +0000
commit56d2c3e990509d18de31e6009e0d0c6254f99b67 (patch)
treefa79862424f122da23e68816a0713b502406f7ac /render.c
parentterm: limit app-id to 2048 characters (diff)
config: don't allow colors.flash-alpha to be 1.0
A compositor will not send a frame callback for our main window if it is fully occluded (for example, by a fully opaque overlay...). This causes the overlay to stuck. For regular buffers, it _should_ be enough to *not* hint the compositor it's opaque. But at least some compositor special cases single-pixel buffers, and actually look at their pixel value. Thus, we have two options: implement frame callback handling for the overlay sub-surface, or ensure we don't use a fully opaque surface. Since no overlays are fully opaque by default, and the flash surface is the only one that can be configured to be opaque (colors.flash-alpha), and since adding frame callback handling adds a lot of boilerplate code... let's go with the simpler solution of
Diffstat (limited to 'render.c')
-rw-r--r--render.c21
1 files changed, 21 insertions, 0 deletions
diff --git a/render.c b/render.c
index ed6b802e..8fc741b5 100644
--- a/render.c
+++ b/render.c
@@ -1898,6 +1898,27 @@ render_overlay(struct terminal *term)
break;
case OVERLAY_FLASH:
+ /*
+ * A compositor will not send a frame callback for our main
+ * window if it is fully occluded (for example, by a fully
+ * opaque overlay...). This causes the overlay to stuck.
+ *
+ * For regular buffers, it _should_ be enough to *not* hint
+ * the compositor it's opaque. But at least some compositor
+ * special cases single-pixel buffers, and actually look at
+ * their pixel value.
+ *
+ * Thus, we have two options: implement frame callback
+ * handling for the overlay sub-surface, or ensure we don't
+ * use a fully opaque surface. Since no overlays are fully
+ * opaque by default, and the flash surface is the only one
+ * that can be configured to be opaque (colors.flash-alpha),
+ * and since adding frame callback handling adds a lot of
+ * boilerplate code... let's go with the simpler solution of
+ * not allowing colors.flash-alpha to be 1.0.
+ */
+ xassert(term->conf->colors.flash_alpha != 0xffff);
+
color = color_hex_to_pixman_with_alpha(
term->conf->colors.flash,
term->conf->colors.flash_alpha);