aboutsummaryrefslogtreecommitdiff
path: root/render.c
diff options
context:
space:
mode:
authorDaniel Eklöf <daniel@ekloef.se>2019-10-28 16:58:44 +0000
committerDaniel Eklöf <daniel@ekloef.se>2019-10-28 16:58:44 +0000
commit89cec15920d680c76e4d7177b158f9105a989a96 (patch)
treede2636cdba70765c635f45105b06ba382314bcc3 /render.c
parentPKGBUILD: fix breakage after pacman 5.2 upgrade (diff)
render: regression: don't apply scroll damage when view is in scrollback
When user has scrolled back in the output history, new output should not trigger scrolling. This was true for normal cell rendering, which renders the cells *in view*, not caring where the "front" of the output is. However, we still applied scroll damage. I.e. we memmoved part of the screen. The fix is simple; only apply scroll damage when the view is at the front of the output.
Diffstat (limited to 'render.c')
-rw-r--r--render.c27
1 files changed, 15 insertions, 12 deletions
diff --git a/render.c b/render.c
index ff05d501..de5c2246 100644
--- a/render.c
+++ b/render.c
@@ -528,21 +528,24 @@ grid_render(struct terminal *term)
* by the cursor, since only the final cell matters. */
all_clean = false;
}
- }
+ }
- tll_foreach(term->grid->scroll_damage, it) {
- switch (it->item.type) {
- case DAMAGE_SCROLL:
- grid_render_scroll(term, buf, &it->item);
- break;
+ if (term->grid->view == term->grid->offset) {
+ tll_foreach(term->grid->scroll_damage, it) {
+ switch (it->item.type) {
+ case DAMAGE_SCROLL:
+ grid_render_scroll(term, buf, &it->item);
+ break;
- case DAMAGE_SCROLL_REVERSE:
- grid_render_scroll_reverse(term, buf, &it->item);
- break;
- }
+ case DAMAGE_SCROLL_REVERSE:
+ grid_render_scroll_reverse(term, buf, &it->item);
+ break;
+ }
- tll_remove(term->grid->scroll_damage, it);
- }
+ tll_remove(term->grid->scroll_damage, it);
+ }
+ } else
+ tll_free(term->grid->scroll_damage);
if (term->render.workers.count > 0) {