aboutsummaryrefslogtreecommitdiff
path: root/render.c
diff options
context:
space:
mode:
authorDaniel Eklöf <daniel@ekloef.se>2020-12-20 11:25:12 +0000
committerDaniel Eklöf <daniel@ekloef.se>2020-12-20 14:46:32 +0000
commita2ce0622c5396774c64245bb6cbd6b7dbd0d339d (patch)
tree5b56f3445f9f1fa928762ded725f5220d29fe782 /render.c
parentmeson: add wl_proto_headers to pgo executable (diff)
render: fix rounding error when calculating background color with alpha
We use pre-multiplied alpha color channels, but were having bad rounding errors due to the alpha divider being truncated to an integer. The algorithm for pre-multiplying a color channel is: alpha_divider = 0xffff / alpha pre_mult_color = color / alpha_divider In order to fix the rounding errors, we could turn ‘alpha_divider’ into a double. That however would introduce a performance penalty since now we’d need to do floating point math for each cell. The algorithm can be trivially converted to: pre_mult_color = color * alpha / 0xffff Since both color and alpa values are < 65536, the multiplication is “safe”; it will not overflow an uint32_t. Closes #249
Diffstat (limited to 'render.c')
-rw-r--r--render.c10
1 files changed, 3 insertions, 7 deletions
diff --git a/render.c b/render.c
index df22dd6e..f66e277e 100644
--- a/render.c
+++ b/render.c
@@ -213,14 +213,10 @@ attrs_to_font(const struct terminal *term, const struct attributes *attrs)
static inline pixman_color_t
color_hex_to_pixman_with_alpha(uint32_t color, uint16_t alpha)
{
- if (alpha == 0)
- return (pixman_color_t){0, 0, 0, 0};
-
- int alpha_div = 0xffff / alpha;
return (pixman_color_t){
- .red = ((color >> 16 & 0xff) | (color >> 8 & 0xff00)) / alpha_div,
- .green = ((color >> 8 & 0xff) | (color >> 0 & 0xff00)) / alpha_div,
- .blue = ((color >> 0 & 0xff) | (color << 8 & 0xff00)) / alpha_div,
+ .red = ((color >> 16 & 0xff) | (color >> 8 & 0xff00)) * alpha / 0xffff,
+ .green = ((color >> 8 & 0xff) | (color >> 0 & 0xff00)) * alpha / 0xffff,
+ .blue = ((color >> 0 & 0xff) | (color << 8 & 0xff00)) * alpha / 0xffff,
.alpha = alpha,
};
}