diff options
| author | Daniel Eklöf <daniel@ekloef.se> | 2020-10-29 17:06:04 +0000 |
|---|---|---|
| committer | Daniel Eklöf <daniel@ekloef.se> | 2020-10-29 17:06:04 +0000 |
| commit | beaf220f394984c97395b079eab260b225ee5378 (patch) | |
| tree | 50cc25e8e8f01622ec95d99a075338e3cca617b1 /render.c | |
| parent | Merge branch 'drag-and-drop' (diff) | |
tiocswinsz: fix compilation error on e.g. ppc64
On some platforms, TIOCSWINSZ has a very large value, >
0x80000000.
On some platforms, the `request` argument to `ioctl(3)` is an `int`.
For platforms where both of the above is true, gcc will warn (and
error out if compiled with `-Werror`) on:
ioctl(fd, TIOCSWINSZ, ...)
To silence this warning, we need to cast `TIOCSWINSZ` to an
integer.
However, doing this on platforms where `request` is an `unsigned long`
will result in `TIOCSWINSZ` being sign-extended (and thus we end up
with an invalid value).
It seems that casting to `unsigned int` works in both cases; it
silences the long -> int conversion warning, while also preserving the
correct value in all cases.
Diffstat (limited to 'render.c')
| -rw-r--r-- | render.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -2206,7 +2206,7 @@ maybe_resize(struct terminal *term, int width, int height, bool force) term->margins.left, term->margins.right, term->margins.top, term->margins.bottom); /* Signal TIOCSWINSZ */ - if (term->ptmx >= 0 && ioctl(term->ptmx, TIOCSWINSZ, + if (term->ptmx >= 0 && ioctl(term->ptmx, (unsigned int)TIOCSWINSZ, &(struct winsize){ .ws_row = term->rows, .ws_col = term->cols, |
