diff options
| author | Daniel Eklöf <daniel@ekloef.se> | 2026-05-11 12:14:46 +0000 |
|---|---|---|
| committer | Daniel Eklöf <daniel@ekloef.se> | 2026-05-12 14:40:24 +0000 |
| commit | cc6b29fe3a98a1575af4eb6644504a2fff619b5c (patch) | |
| tree | ccbaf9bd801e51427614a50a6fe62c6f72b1a31d /render.c | |
| parent | search/url/unicode-mode: set last-shortcut-sym (diff) | |
render: cursor: improve handling of fg == bg
We already detect if the final cursor colors (foreground/background)
are identical.
If they were, we replaced them with the default fg/bg.
Unfortunately, this can still result in an invisible cursor. For
example, if the current cell's default bg matches the current cell's
fg.
Instead, update the colors in two steps:
1. First, use the provided (cell's) fg/bg
2. If they too match, invert the cursor color
This should ensure the cursor is always visible
Closes #2323
Diffstat (limited to 'render.c')
| -rw-r--r-- | render.c | 19 |
1 files changed, 14 insertions, 5 deletions
@@ -614,12 +614,21 @@ cursor_colors_for_cell(const struct terminal *term, const struct cell *cell, *text_color = *bg; } - if (text_color->red == cursor_color->red && - text_color->green == cursor_color->green && - text_color->blue == cursor_color->blue) + if (unlikely(text_color->red == cursor_color->red && + text_color->green == cursor_color->green && + text_color->blue == cursor_color->blue)) { - *text_color = color_hex_to_pixman(term->colors.bg, gamma_correct); - *cursor_color = color_hex_to_pixman(term->colors.fg, gamma_correct); + *text_color = *bg; + *cursor_color = *fg; + + if (text_color->red == cursor_color->red && + text_color->green == cursor_color->green && + text_color->blue == cursor_color->blue) + { + cursor_color->red = ~cursor_color->red; + cursor_color->green = ~cursor_color->green; + cursor_color->blue = ~cursor_color->blue; + } } } |
