aboutsummaryrefslogtreecommitdiff
path: root/scripts
diff options
context:
space:
mode:
authorDaniel Eklöf <daniel@ekloef.se>2021-03-21 10:55:03 +0000
committerDaniel Eklöf <daniel@ekloef.se>2021-03-21 15:22:08 +0000
commit0c85905972fdc739fb140e32c3389c08e769bfff (patch)
tree827a31068637de9585c70b1d64d603259769e38d /scripts
parentdoc: benchmark: update "workstation" benchmarks with 1.7.0 results (diff)
input: must have all required modifiers to un-shift a symbol
When detecting, and repairing, “broken” key bindings (where the key binding itself explicitly lists a modifier that is consumed by the final symbol - e.g “Shift+W”), don’t just look for an intersection between the set of modifiers needed to produce the final symbol, and the modifiers listed in the key combo. Instead, check if the key combo has *all* the required modifiers. Example: Shift+AltGr+w produces Page_Down. I.e. Page_Down is the _shifted_ symbol, ‘w’ is the un-shifted symbol, and Shift+AltGr are the modifiers required to shift ‘w’ to Page_Down. If we have the key combo Shift+Page_Down, foot would, correctly, determine that Page_Down is a shifted symbol. It would find the Shift+AltGr modifier set, and since the intersection of “Shift+AltGr” and “Shift” (from our key combo) is non-empty, foot would (incorrectly) determine that we can, and should, replace Page_Down with its un-shifted symbol ‘w’. This is completely wrong, since Shift+w does _not_ produce Page_Down. Closes #407
Diffstat (limited to 'scripts')
0 files changed, 0 insertions, 0 deletions