diff options
| author | Daniel Eklöf <daniel@ekloef.se> | 2026-03-10 06:46:03 +0000 |
|---|---|---|
| committer | Daniel Eklöf <daniel@ekloef.se> | 2026-03-10 07:25:08 +0000 |
| commit | 657db18a4ec4df93689c3eaae03b70f851724001 (patch) | |
| tree | dbbc4cc9b4b895a1c66305ab5686bfb20fddfbd9 /selection.h | |
| parent | meson: clang: add -Wno-wc2y-extensions (diff) | |
wayland: do all surface unmap and roundtrips before waiting for pre-apply damage
The pre-apply damage thread may be running when we destroy a terminal
instance, and we need to wait for it to finish before destroying the
underlying buffer.
c291194a4e593bbbb91420e81fa0111508084448 did this, but failed to
realize the thread may get re-started in the roundtrips done later in
wayl_win_destroy(); after the wait added in
c291194a4e593bbbb91420e81fa0111508084448, we unmap all
surfaces (including the main grid), and roundtrip. This means the
compositor will release the currently active buffer, and that means
_we_ will trigger the pre-apply damage thread on it. This introduces a
race, where wayl_win_destroy() may reach its shm_purge() calls before
the pre-apply damage thread has finished. That typically causes foot
to crash.
Closes #2288
Diffstat (limited to 'selection.h')
0 files changed, 0 insertions, 0 deletions
