aboutsummaryrefslogtreecommitdiff
path: root/server.c
diff options
context:
space:
mode:
authorCismonX <admin@cismon.net>2026-09-05 22:17:29 +0000
committerDaniel Eklöf <daniel@ekloef.se>2026-09-10 06:28:00 +0000
commit96b717b7480314239736b19ae26db245385407b6 (patch)
tree7c4b7a55e9a2b135095122071cecdf3faeec0dd4 /server.c
parentfoot.ini: `color-theme-switch-1`, `color-theme-switch-2` -> `color-theme-switch-dark`, `color-theme- (diff)
server: fix use-after-free during shutdown
When terminal shutdown is in progress, calling client_destroy() results in subsequent fdm_shutdown() (registered by term_shutdown()) always called with a dangling 'struct terminal' pointer. This may happen when footclient and the client application exit simultaneously in a short window. See #2432 for more information. Fixed by not calling client_destroy() when terminal shutdown is in progress. The client will eventually be destroyed in term_shutdown_handler() (invoked from shutdown_maybe_done()), so there's no resource leak.
Diffstat (limited to 'server.c')
-rw-r--r--server.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/server.c b/server.c
index 25963325..46560d5c 100644
--- a/server.c
+++ b/server.c
@@ -426,11 +426,9 @@ shutdown:
fdm_del(fdm, fd);
client->fd = -1;
- if (client->instance != NULL &&
- !client->instance->terminal->shutdown.in_progress)
- {
+ if (client->instance != NULL)
term_shutdown(client->instance->terminal);
- } else
+ else
client_destroy(client);
return true;