aboutsummaryrefslogtreecommitdiff
path: root/shm.c
diff options
context:
space:
mode:
authorDaniel Eklöf <daniel@ekloef.se>2024-07-30 14:33:19 +0000
committerDaniel Eklöf <daniel@ekloef.se>2024-07-30 14:33:19 +0000
commit0a5ba708e4a8448a0d29d4e263f939c9d1d2b953 (patch)
tree2b7cf3474d07b987d37956d1b4d6fc0485a81bbb /shm.c
parentreadme: IRC: update link to point to the web interface (diff)
notify: don't close FD 0
This fixes a regression where closing a terminal instance, or hard- or soft-resetting a terminal caused FD 0 to be closed. This meant it became re-usable. Usually, by memfd_create() when allocating a new surface buffer. So far nothing _really_ bad has happened. But what if FD 0 is now used by a memfd, and we close _another_ terminal instance? This causes our memfd to be closed. And then, when e.g. trying to scroll the terminal content: fallocate() fails with bad FD.
Diffstat (limited to 'shm.c')
-rw-r--r--shm.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/shm.c b/shm.c
index 879745d4..04cec211 100644
--- a/shm.c
+++ b/shm.c
@@ -255,7 +255,7 @@ instantiate_offset(struct buffer_private *buf, off_t new_offset)
void *mmapped = MAP_FAILED;
struct wl_buffer *wl_buf = NULL;
- pixman_image_t **pix = xcalloc(buf->public.pix_instances, sizeof(*pix));
+ pixman_image_t **pix = xcalloc(buf->public.pix_instances, sizeof(pix[0]));
mmapped = (uint8_t *)pool->real_mmapped + new_offset;