diff options
| author | Daniel Eklöf <daniel@ekloef.se> | 2026-01-10 06:36:17 +0000 |
|---|---|---|
| committer | Daniel Eklöf <daniel@ekloef.se> | 2026-01-28 08:31:32 +0000 |
| commit | 3a2eb80d83d59d194a3d07da227431c634892ff5 (patch) | |
| tree | d5dd1bafe8f4cc8ec10da78355f0f1c021d11329 /sixel.c | |
| parent | input: execute: add missing 'return true' to a couple of switch cases (diff) | |
input: ignore release events after a keyboard shortcut was triggered
This fixes an issue with the kitty keyboard protocol, where 'release'
events associated with a shortcut was sent to the client application.
Example: user triggers "scroll up". We scroll up. No key event(s) are
sent to the client application. Then the user releases the keys. we
don't do any shortcut handling on release events, and so we continue
with the normal input processing. If the kitty keyboard protocol has
been enabled (and specifically, release event reporting has been
enabled), then we'll emit a 'release' escape sequence. This in itself
is wrong, since the client application never saw the corresponding
press event. But we _also_ reset the viewport. The effect (in this
example), is that it's impossible to scroll up in the scrollback
history.
Note that we don't ignore _any_ release event, only the release event
for the (final) symbol that triggered the shortcut.
This should allow e.g. modifier keys release events to be processed
normally, if released before the shortcut key.
This is somewhat important, since the client application will have
received press events for the modifier keys leading up to the
shortcut (if modifier press/release events have been enabled in the
kitty keyboard protocol - _Report all keys as escape codes_).
Closes #2257
Diffstat (limited to 'sixel.c')
0 files changed, 0 insertions, 0 deletions
